Re: [PATCH 13/30] ARM: omap2+: fix omap_hdq_init compilation

2011-10-03 Thread Tony Lindgren
* Santosh Shilimkar santosh.shilim...@ti.com [111002 21:37]:
 On Sunday 02 October 2011 08:15 PM, Arnd Bergmann wrote:
  The definition of the device must depend on the hardware
  we run on, not on the kernel configuration.
  
  arch/arm/mach-omap2/devices.c:624:13: error: 'OMAP_HDQ_BASE' undeclared 
  here (not in a function)
  
  Signed-off-by: Arnd Bergmann a...@arndb.de
  ---
 Acked-by: Santosh Shilimkar santosh.shilim...@ti.com

Acked-by: Tony Lindgren t...@atomide.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 13/30] ARM: omap2+: fix omap_hdq_init compilation

2011-10-02 Thread Arnd Bergmann
The definition of the device must depend on the hardware
we run on, not on the kernel configuration.

arch/arm/mach-omap2/devices.c:624:13: error: 'OMAP_HDQ_BASE' undeclared here 
(not in a function)

Signed-off-by: Arnd Bergmann a...@arndb.de
---
 arch/arm/mach-omap2/devices.c |   10 ++
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 1077ad6..392f2b0 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -29,6 +29,7 @@
 #include mach/gpio.h
 #include plat/mmc.h
 #include plat/dma.h
+#include plat/cpu.h
 #include plat/omap_hwmod.h
 #include plat/omap_device.h
 #include plat/omap4-keypad.h
@@ -615,10 +616,8 @@ void __init omap242x_init_mmc(struct 
omap_mmc_platform_data **mmc_data)
 
 /*-*/
 
-#if defined(CONFIG_HDQ_MASTER_OMAP) || defined(CONFIG_HDQ_MASTER_OMAP_MODULE)
 #if defined(CONFIG_SOC_OMAP2430) || defined(CONFIG_SOC_OMAP3430)
 #define OMAP_HDQ_BASE  0x480B2000
-#endif
 static struct resource omap_hdq_resources[] = {
{
.start  = OMAP_HDQ_BASE,
@@ -641,10 +640,13 @@ static struct platform_device omap_hdq_dev = {
 };
 static inline void omap_hdq_init(void)
 {
-   (void) platform_device_register(omap_hdq_dev);
+   if (cpu_is_omap2430() || cpu_is_omap3430())
+   (void) platform_device_register(omap_hdq_dev);
 }
 #else
-static inline void omap_hdq_init(void) {}
+static inline void omap_hdq_init(void)
+{
+}
 #endif
 
 /*---*/
-- 
1.7.5.4

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 13/30] ARM: omap2+: fix omap_hdq_init compilation

2011-10-02 Thread Santosh Shilimkar
On Sunday 02 October 2011 08:15 PM, Arnd Bergmann wrote:
 The definition of the device must depend on the hardware
 we run on, not on the kernel configuration.
 
 arch/arm/mach-omap2/devices.c:624:13: error: 'OMAP_HDQ_BASE' undeclared here 
 (not in a function)
 
 Signed-off-by: Arnd Bergmann a...@arndb.de
 ---
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html