Re: [PATCH 1a/3] watchdog: omap: clearify device tree documentation
On 04/24/2015 07:10 PM, Felipe Balbi wrote: On Fri, Apr 24, 2015 at 10:20:50PM +0200, Uwe Kleine-König wrote: ti,hwmods doesn't belong into the compatible section but is a property on it's own. Also reformat the section of required properties to match the usual style of dt binding documents. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de looks great to me, thanks Reviewed-by: Felipe Balbi ba...@ti.com Acked-by: Felipe Balbi ba...@ti.com Reviewed-by: and Acked-by: are mutually exclusive. Guenter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1a/3] watchdog: omap: clearify device tree documentation
On Sun, Apr 26, 2015 at 08:29:20AM -0700, Guenter Roeck wrote:
On 04/24/2015 07:10 PM, Felipe Balbi wrote:
On Fri, Apr 24, 2015 at 10:20:50PM +0200, Uwe Kleine-König wrote:
ti,hwmods doesn't belong into the compatible section but is a property
on it's own. Also reformat the section of required properties to match the
usual style of dt binding documents.
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
looks great to me, thanks
Reviewed-by: Felipe Balbi ba...@ti.com
Acked-by: Felipe Balbi ba...@ti.com
Reviewed-by: and Acked-by: are mutually exclusive.
Really? Acked means you like it and Reviewed by means you looked deeper
into it. Maybe reviewing without liking isn't likely, *shrug*.
The command
$ git rev-list linus/master | while read cmmt; do git cat-file commit
$cmmt | awk -v cmmt=$cmmt '$1 ~ /(Acked|Reviewed)-by:/ { $1 = ; print cmmt
$0 }' | sort; done | uniq -d
should catch all commits that have duplicate tags. There are a few,
*shrugagain*.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1a/3] watchdog: omap: clearify device tree documentation
On 04/26/2015 12:12 PM, Uwe Kleine-König wrote: On Sun, Apr 26, 2015 at 08:29:20AM -0700, Guenter Roeck wrote: On 04/24/2015 07:10 PM, Felipe Balbi wrote: On Fri, Apr 24, 2015 at 10:20:50PM +0200, Uwe Kleine-König wrote: ti,hwmods doesn't belong into the compatible section but is a property on it's own. Also reformat the section of required properties to match the usual style of dt binding documents. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de looks great to me, thanks Reviewed-by: Felipe Balbi ba...@ti.com Acked-by: Felipe Balbi ba...@ti.com Reviewed-by: and Acked-by: are mutually exclusive. Really? Acked means you like it and Reviewed by means you looked deeper into it. Maybe reviewing without liking isn't likely, *shrug*. SubmittingPatches says about Acked-by: ... to signify and record their approval ... has at least reviewed the patch and has indicated acceptance and about Reviewed-by: ... indicates that the patch has been reviewed and found acceptable ... Maybe I should have used the term redundant. *shrugtoo*. Guenter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1a/3] watchdog: omap: clearify device tree documentation
On Fri, Apr 24, 2015 at 10:20:50PM +0200, Uwe Kleine-König wrote: ti,hwmods doesn't belong into the compatible section but is a property on it's own. Also reformat the section of required properties to match the usual style of dt binding documents. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de looks great to me, thanks Reviewed-by: Felipe Balbi ba...@ti.com Acked-by: Felipe Balbi ba...@ti.com --- Hello Felipe, what about this patch before the previously sent patch 1? Best regards Uwe Documentation/devicetree/bindings/watchdog/omap-wdt.txt | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/watchdog/omap-wdt.txt b/Documentation/devicetree/bindings/watchdog/omap-wdt.txt index c227970671ea..597e19d18dca 100644 --- a/Documentation/devicetree/bindings/watchdog/omap-wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/omap-wdt.txt @@ -1,10 +1,8 @@ TI Watchdog Timer (WDT) Controller for OMAP Required properties: -compatible: -- ti,omap3-wdt for OMAP3 -- ti,omap4-wdt for OMAP4 -- ti,hwmods: Name of the hwmod associated to the WDT +- compatible : ti,omap3-wdt for OMAP3 or ti,omap4-wdt for OMAP4 +- ti,hwmods : Name of the hwmod associated to the WDT Examples: -- 2.1.4 -- balbi signature.asc Description: Digital signature
[PATCH 1a/3] watchdog: omap: clearify device tree documentation
ti,hwmods doesn't belong into the compatible section but is a property on it's own. Also reformat the section of required properties to match the usual style of dt binding documents. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- Hello Felipe, what about this patch before the previously sent patch 1? Best regards Uwe Documentation/devicetree/bindings/watchdog/omap-wdt.txt | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/watchdog/omap-wdt.txt b/Documentation/devicetree/bindings/watchdog/omap-wdt.txt index c227970671ea..597e19d18dca 100644 --- a/Documentation/devicetree/bindings/watchdog/omap-wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/omap-wdt.txt @@ -1,10 +1,8 @@ TI Watchdog Timer (WDT) Controller for OMAP Required properties: -compatible: -- ti,omap3-wdt for OMAP3 -- ti,omap4-wdt for OMAP4 -- ti,hwmods: Name of the hwmod associated to the WDT +- compatible : ti,omap3-wdt for OMAP3 or ti,omap4-wdt for OMAP4 +- ti,hwmods : Name of the hwmod associated to the WDT Examples: -- 2.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
