Re: [PATCH 2/2] mfd: twl6030: Disable IRQ during suspend
Hi Todd, On Mon, Sep 26, 2011 at 04:44:24PM -0700, Todd Poynor wrote: > Module IRQs may still be disabled by DPM at the time the TWL6030 > ISR runs, causing handle_simple_irq() to silently do nothing. > This may result in missing TWL RTC alarm wakeups, for example, > since the RTC child module ISR is not called to ack the IRQ. > > Disable the TWL6030 IRQ during suspend, enable it at DPM resume > time, at which time the child module IRQs will be re-enabled. Applied as well, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] mfd: twl6030: Disable IRQ during suspend
On Tuesday 27 September 2011 05:14 AM, Todd Poynor wrote: > Module IRQs may still be disabled by DPM at the time the TWL6030 > ISR runs, causing handle_simple_irq() to silently do nothing. > This may result in missing TWL RTC alarm wakeups, for example, > since the RTC child module ISR is not called to ack the IRQ. > > Disable the TWL6030 IRQ during suspend, enable it at DPM resume > time, at which time the child module IRQs will be re-enabled. > > Signed-off-by: Todd Poynor Acked-by: Santosh Shilimkar Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2] mfd: twl6030: Disable IRQ during suspend
Module IRQs may still be disabled by DPM at the time the TWL6030 ISR runs, causing handle_simple_irq() to silently do nothing. This may result in missing TWL RTC alarm wakeups, for example, since the RTC child module ISR is not called to ack the IRQ. Disable the TWL6030 IRQ during suspend, enable it at DPM resume time, at which time the child module IRQs will be re-enabled. Signed-off-by: Todd Poynor --- drivers/mfd/twl6030-irq.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c index 7d6553c..5c08ecd 100644 --- a/drivers/mfd/twl6030-irq.c +++ b/drivers/mfd/twl6030-irq.c @@ -109,7 +109,13 @@ static int twl6030_irq_pm_notifier(struct notifier_block *notifier, twl_irq_wake_enabled = false; } + disable_irq(twl_irq); break; + + case PM_POST_SUSPEND: + enable_irq(twl_irq); + break; + default: break; } -- 1.7.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
