Re: [PATCH 28/30] ARM: omap: select CPU_FREQ_TABLE where needed
On Monday 03 October 2011 11:09:33 Santosh Shilimkar wrote: diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig index bb8f4a6..f7ef9f4 100644 --- a/arch/arm/plat-omap/Kconfig +++ b/arch/arm/plat-omap/Kconfig @@ -217,6 +217,11 @@ config OMAP_PM_NOOP endchoice +config OMAP_CPU_FREQ + def_bool y + depends on CPU_FREQ + select CPU_FREQ_TABLE + endmenu With CPUFREQ series from Kevin [1], I don't think we need this any-more. I guess if it's needed, it should at least be moved to the new cpufreq location. More so, I didn't find OMAP_CPU_FREQ is being used anywhere on mainline. Yes, OMAP_CPU_FREQ is a symbol that is intentionally unused, with the only purpose of selecting CPU_FREQ_TABLE if any omap platform together with CPU_FREQ is enabled. Let's drop this patch for now, if it is still needed as I think, I can do a patch during the 3.2 cycle for the right location. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 28/30] ARM: omap: select CPU_FREQ_TABLE where needed
On Monday 03 October 2011 02:45 PM, Arnd Bergmann wrote: On Monday 03 October 2011 11:09:33 Santosh Shilimkar wrote: diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig index bb8f4a6..f7ef9f4 100644 --- a/arch/arm/plat-omap/Kconfig +++ b/arch/arm/plat-omap/Kconfig @@ -217,6 +217,11 @@ config OMAP_PM_NOOP endchoice +config OMAP_CPU_FREQ + def_bool y + depends on CPU_FREQ + select CPU_FREQ_TABLE + endmenu With CPUFREQ series from Kevin [1], I don't think we need this any-more. I guess if it's needed, it should at least be moved to the new cpufreq location. Probably you are right. CPU_FREQ_TABLE is selected today if CPU_FREQ_STAT or CPU_FREQ_GOV_ONDEMAND is selected. Without these two enabled, in won't be selected. More so, I didn't find OMAP_CPU_FREQ is being used anywhere on mainline. Yes, OMAP_CPU_FREQ is a symbol that is intentionally unused, with the only purpose of selecting CPU_FREQ_TABLE if any omap platform together with CPU_FREQ is enabled. I see. This wasn't clear to me. Let's drop this patch for now, if it is still needed as I think, I can do a patch during the 3.2 cycle for the right location. Ok. Regards Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 28/30] ARM: omap: select CPU_FREQ_TABLE where needed
The omap platform requires CPU_FREQ_TABLE support to be enabled for its CPU_FREQ implementations, so automatically select that when CPU_FREQ is enabled. Signed-off-by: Arnd Bergmann a...@arndb.de --- arch/arm/plat-omap/Kconfig |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig index bb8f4a6..f7ef9f4 100644 --- a/arch/arm/plat-omap/Kconfig +++ b/arch/arm/plat-omap/Kconfig @@ -217,6 +217,11 @@ config OMAP_PM_NOOP endchoice +config OMAP_CPU_FREQ + def_bool y + depends on CPU_FREQ + select CPU_FREQ_TABLE + endmenu endif -- 1.7.5.4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 28/30] ARM: omap: select CPU_FREQ_TABLE where needed
On Sunday 02 October 2011 08:15 PM, Arnd Bergmann wrote: The omap platform requires CPU_FREQ_TABLE support to be enabled for its CPU_FREQ implementations, so automatically select that when CPU_FREQ is enabled. Signed-off-by: Arnd Bergmann a...@arndb.de --- arch/arm/plat-omap/Kconfig |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig index bb8f4a6..f7ef9f4 100644 --- a/arch/arm/plat-omap/Kconfig +++ b/arch/arm/plat-omap/Kconfig @@ -217,6 +217,11 @@ config OMAP_PM_NOOP endchoice +config OMAP_CPU_FREQ + def_bool y + depends on CPU_FREQ + select CPU_FREQ_TABLE + endmenu With CPUFREQ series from Kevin [1], I don't think we need this any-more. More so, I didn't find OMAP_CPU_FREQ is being used anywhere on mainline. Regards Santosh [1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg56288.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
