Re: [PATCH 4/7] ARM: OMAP2+: Fix zoom LCD backlight if TWL_CORE is not selected

2012-02-24 Thread Sergei Shtylyov 

Hello.

On 24-02-2012 4:54, Tony Lindgren wrote:


Otherwise we get:



arch/arm/mach-omap2/board-zoom-display.c:64: undefined reference to 
`twl_i2c_read_u8'
arch/arm/mach-omap2/board-zoom-display.c:65: undefined reference to 
`twl_i2c_read_u8'
arch/arm/mach-omap2/board-zoom-display.c:84: undefined reference to 
`twl_i2c_write_u8'
arch/arm/mach-omap2/board-zoom-display.c:86: undefined reference to 
`twl_i2c_write_u8'
arch/arm/mach-omap2/board-zoom-display.c:91: undefined reference to 
`twl_i2c_write_u8'
arch/arm/mach-omap2/board-zoom-display.c:92: undefined reference to 
`twl_i2c_write_u8'
arch/arm/mach-omap2/board-zoom-display.c:72: undefined reference to 
`twl_i2c_write_u8'



Signed-off-by: Tony Lindgrent...@atomide.com

[...]


diff --git a/arch/arm/mach-omap2/board-zoom-display.c 
b/arch/arm/mach-omap2/board-zoom-display.c
index d4683ba..7f75fcd 100644
--- a/arch/arm/mach-omap2/board-zoom-display.c
+++ b/arch/arm/mach-omap2/board-zoom-display.c
@@ -53,8 +53,11 @@ static void zoom_panel_disable_lcd(struct omap_dss_device 
*dssdev)
  #define TWL_LED_PWMON 0x0
  #define TWL_LED_PWMOFF0x1

+
  static int zoom_set_bl_intensity(struct omap_dss_device *dssdev, int level)
  {
+


   Empty lines not needed.


+#ifdef CONFIG_TWL4030_CORE
unsigned char c;
u8 mux_pwm, enb_pwm;



WBR, Sergei
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/7] ARM: OMAP2+: Fix zoom LCD backlight if TWL_CORE is not selected

2012-02-24 Thread Tony Lindgren 
* Sergei Shtylyov sshtyl...@ru.mvista.com [120224 03:23]:
 
 On 24-02-2012 4:54, Tony Lindgren wrote:
 --- a/arch/arm/mach-omap2/board-zoom-display.c
 +++ b/arch/arm/mach-omap2/board-zoom-display.c
 @@ -53,8 +53,11 @@ static void zoom_panel_disable_lcd(struct omap_dss_device 
 *dssdev)
   #define TWL_LED_PWMON  0x0
   #define TWL_LED_PWMOFF 0x1
 
 +
   static int zoom_set_bl_intensity(struct omap_dss_device *dssdev, int level)
   {
 +
 
Empty lines not needed.

Thanks removing those.

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/7] ARM: OMAP2+: Fix zoom LCD backlight if TWL_CORE is not selected

2012-02-23 Thread Tony Lindgren 
Otherwise we get:

arch/arm/mach-omap2/board-zoom-display.c:64: undefined reference to 
`twl_i2c_read_u8'
arch/arm/mach-omap2/board-zoom-display.c:65: undefined reference to 
`twl_i2c_read_u8'
arch/arm/mach-omap2/board-zoom-display.c:84: undefined reference to 
`twl_i2c_write_u8'
arch/arm/mach-omap2/board-zoom-display.c:86: undefined reference to 
`twl_i2c_write_u8'
arch/arm/mach-omap2/board-zoom-display.c:91: undefined reference to 
`twl_i2c_write_u8'
arch/arm/mach-omap2/board-zoom-display.c:92: undefined reference to 
`twl_i2c_write_u8'
arch/arm/mach-omap2/board-zoom-display.c:72: undefined reference to 
`twl_i2c_write_u8'

Signed-off-by: Tony Lindgren t...@atomide.com
---
 arch/arm/mach-omap2/board-zoom-display.c |6 ++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-zoom-display.c 
b/arch/arm/mach-omap2/board-zoom-display.c
index d4683ba..7f75fcd 100644
--- a/arch/arm/mach-omap2/board-zoom-display.c
+++ b/arch/arm/mach-omap2/board-zoom-display.c
@@ -53,8 +53,11 @@ static void zoom_panel_disable_lcd(struct omap_dss_device 
*dssdev)
 #define TWL_LED_PWMON  0x0
 #define TWL_LED_PWMOFF 0x1
 
+
 static int zoom_set_bl_intensity(struct omap_dss_device *dssdev, int level)
 {
+
+#ifdef CONFIG_TWL4030_CORE
unsigned char c;
u8 mux_pwm, enb_pwm;
 
@@ -90,6 +93,9 @@ static int zoom_set_bl_intensity(struct omap_dss_device 
*dssdev, int level)
c = ((50 * (100 - level)) / 100) + 1;
twl_i2c_write_u8(TWL4030_MODULE_PWM1, 0x7F, TWL_LED_PWMOFF);
twl_i2c_write_u8(TWL4030_MODULE_PWM1, c, TWL_LED_PWMON);
+#else
+   pr_warn(Backlight not enabled\n);
+#endif
 
return 0;
 }

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html