Re: [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset
Tero Kristo t-kri...@ti.com writes:
From: Rajendra Nayak rna...@ti.com
With no driver handling DSP/TESLA, if brought out of reset, it stays
active and does not assert standby.
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Tero Kristo t-kri...@ti.com
Subject says 'OMAP4: suspend'. How does HWMOD_INIT_NO_RESET affect
suspend?
Kevin
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index ef0524c..81d90da 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -1160,6 +1160,7 @@ static struct omap_hwmod omap44xx_dsp_hwmod = {
.name = dsp,
.class = omap44xx_dsp_hwmod_class,
.clkdm_name = tesla_clkdm,
+ .flags = HWMOD_INIT_NO_RESET,
.mpu_irqs = omap44xx_dsp_irqs,
.rst_lines = omap44xx_dsp_resets,
.rst_lines_cnt = ARRAY_SIZE(omap44xx_dsp_resets),
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset
Hi Kevin,
On Tuesday 28 February 2012 05:58 AM, Kevin Hilman wrote:
Tero Kristot-kri...@ti.com writes:
From: Rajendra Nayakrna...@ti.com
With no driver handling DSP/TESLA, if brought out of reset, it stays
active and does not assert standby.
Signed-off-by: Rajendra Nayakrna...@ti.com
Signed-off-by: Tero Kristot-kri...@ti.com
Subject says 'OMAP4: suspend'. How does HWMOD_INIT_NO_RESET affect
suspend?
The v2 of this patch posted by Tero has a better $subject as suggested
by Benoit which says 'ARM: OMAP4: hwmod_data: Do not get DSP out of
reset at boot time'
The intention of this patch is to *not* get DSP out of reset at boot,
because once out of reset DSP needs some code that executes a 'wfi'
equivalent for it to assert a standby and allow suspend to sleep.
regards,
Rajendra
Kevin
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index ef0524c..81d90da 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -1160,6 +1160,7 @@ static struct omap_hwmod omap44xx_dsp_hwmod = {
.name = dsp,
.class =omap44xx_dsp_hwmod_class,
.clkdm_name = tesla_clkdm,
+ .flags = HWMOD_INIT_NO_RESET,
.mpu_irqs = omap44xx_dsp_irqs,
.rst_lines = omap44xx_dsp_resets,
.rst_lines_cnt = ARRAY_SIZE(omap44xx_dsp_resets),
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset
On 2/23/2012 2:56 PM, Shilimkar, Santosh wrote: $Subject s/dsp/DSP s/tesla/TESLA Even better... remove tesla :-) This is an internal codename that at some point should be removed from the clkdm name. I just did not have the time to do that for OMAP4, but it will not exist anymore on OMAP5. Nit: The subject should be: ARM: OMAP4: hwmod data: Do not get DSP out of reset at boot time Regards, Benoit On Thu, Feb 23, 2012 at 6:51 PM, Tero Kristot-kri...@ti.com wrote: From: Rajendra Nayakrna...@ti.com With no driver handling DSP/TESLA, if brought out of reset, it stays active and does not assert standby. Which lead to IVHA PD not transitiong and hence gating CHIP retention. You may want to add these bits as well. Signed-off-by: Rajendra Nayakrna...@ti.com Signed-off-by: Tero Kristot-kri...@ti.com --- Patch is fine though script needs to be updated I guess Regards Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset
From: Rajendra Nayak rna...@ti.com
With no driver handling DSP/TESLA, if brought out of reset, it stays
active and does not assert standby.
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Tero Kristo t-kri...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index ef0524c..81d90da 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -1160,6 +1160,7 @@ static struct omap_hwmod omap44xx_dsp_hwmod = {
.name = dsp,
.class = omap44xx_dsp_hwmod_class,
.clkdm_name = tesla_clkdm,
+ .flags = HWMOD_INIT_NO_RESET,
.mpu_irqs = omap44xx_dsp_irqs,
.rst_lines = omap44xx_dsp_resets,
.rst_lines_cnt = ARRAY_SIZE(omap44xx_dsp_resets),
--
1.7.4.1
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
