[PATCH 5/6] gpio/omap: fix trigger type to unsigned

2012-02-23 Thread Tarun Kanti DebBarma 
The GPIO trigger parameter is of type unsigned.
enum {
IRQ_TYPE_NONE   = 0x,
IRQ_TYPE_EDGE_RISING= 0x0001,
IRQ_TYPE_EDGE_FALLING   = 0x0002,
IRQ_TYPE_EDGE_BOTH  = (IRQ_TYPE_EDGE_FALLING | 
IRQ_TYPE_EDGE_RISING),
IRQ_TYPE_LEVEL_HIGH = 0x0004,
IRQ_TYPE_LEVEL_LOW  = 0x0008,
IRQ_TYPE_LEVEL_MASK = (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH),
IRQ_TYPE_SENSE_MASK = 0x000f,

IRQ_TYPE_PROBE  = 0x0010,
...
};
Even though gpio_irq_type(struct irq_data *d, unsigned type) has the right type
of parameter, the subsequent called functions set_gpio_triggering() and
set_gpio_trigger() wrongly makes it signed integer. Fix this.

Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com
---
 drivers/gpio/gpio-omap.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 3dd4b3a..67535c8 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -232,7 +232,7 @@ static void _set_gpio_debounce(struct gpio_bank *bank, 
unsigned gpio,
 }
 
 static inline void set_gpio_trigger(struct gpio_bank *bank, int gpio,
-   int trigger)
+   unsigned trigger)
 {
void __iomem *base = bank-base;
u32 gpio_bit = 1  gpio;
@@ -314,7 +314,8 @@ static void _toggle_gpio_edge_triggering(struct gpio_bank 
*bank, int gpio)
 static void _toggle_gpio_edge_triggering(struct gpio_bank *bank, int gpio) {}
 #endif
 
-static int _set_gpio_triggering(struct gpio_bank *bank, int gpio, int trigger)
+static int _set_gpio_triggering(struct gpio_bank *bank, int gpio,
+   unsigned trigger)
 {
void __iomem *reg = bank-base;
void __iomem *base = bank-base;
-- 
1.7.0.4

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/6] gpio/omap: fix trigger type to unsigned

2012-02-23 Thread Felipe Balbi 
On Thu, Feb 23, 2012 at 05:40:30PM +0530, Tarun Kanti DebBarma wrote:
 The GPIO trigger parameter is of type unsigned.
 enum {
 IRQ_TYPE_NONE   = 0x,
 IRQ_TYPE_EDGE_RISING= 0x0001,
 IRQ_TYPE_EDGE_FALLING   = 0x0002,
 IRQ_TYPE_EDGE_BOTH  = (IRQ_TYPE_EDGE_FALLING | 
 IRQ_TYPE_EDGE_RISING),
 IRQ_TYPE_LEVEL_HIGH = 0x0004,
 IRQ_TYPE_LEVEL_LOW  = 0x0008,
 IRQ_TYPE_LEVEL_MASK = (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH),
 IRQ_TYPE_SENSE_MASK = 0x000f,
 
 IRQ_TYPE_PROBE  = 0x0010,
 ...
 };
 Even though gpio_irq_type(struct irq_data *d, unsigned type) has the right 
 type
 of parameter, the subsequent called functions set_gpio_triggering() and
 set_gpio_trigger() wrongly makes it signed integer. Fix this.
 
 Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com

Cool, I guess sparse would also have caught that error :-)

Acked-by: Felipe Balbi ba...@ti.com

-- 
balbi


signature.asc
Description: Digital signature

Re: [PATCH 5/6] gpio/omap: fix trigger type to unsigned

2012-02-23 Thread Shubhrajyoti 
On Thursday 23 February 2012 05:40 PM, Tarun Kanti DebBarma wrote:
 The GPIO trigger parameter is of type unsigned.
 enum {
 IRQ_TYPE_NONE   = 0x,
 IRQ_TYPE_EDGE_RISING= 0x0001,
 IRQ_TYPE_EDGE_FALLING   = 0x0002,
 IRQ_TYPE_EDGE_BOTH  = (IRQ_TYPE_EDGE_FALLING | 
 IRQ_TYPE_EDGE_RISING),
 IRQ_TYPE_LEVEL_HIGH = 0x0004,
 IRQ_TYPE_LEVEL_LOW  = 0x0008,
 IRQ_TYPE_LEVEL_MASK = (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH),
 IRQ_TYPE_SENSE_MASK = 0x000f,

 IRQ_TYPE_PROBE  = 0x0010,
 ...
 };
 Even though gpio_irq_type(struct irq_data *d, unsigned type) has the right 
 type
 of parameter, the subsequent called functions set_gpio_triggering() and
 set_gpio_trigger() wrongly makes it signed integer. Fix this.

 Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com
 ---
  drivers/gpio/gpio-omap.c |5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

 diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
 index 3dd4b3a..67535c8 100644
 --- a/drivers/gpio/gpio-omap.c
 +++ b/drivers/gpio/gpio-omap.c
 @@ -232,7 +232,7 @@ static void _set_gpio_debounce(struct gpio_bank *bank, 
 unsigned gpio,
  }
  
  static inline void set_gpio_trigger(struct gpio_bank *bank, int gpio,
 - int trigger)
 + unsigned trigger)
  {
   void __iomem *base = bank-base;
   u32 gpio_bit = 1  gpio;
 @@ -314,7 +314,8 @@ static void _toggle_gpio_edge_triggering(struct gpio_bank 
 *bank, int gpio)
  static void _toggle_gpio_edge_triggering(struct gpio_bank *bank, int gpio) {}
  #endif
  
 -static int _set_gpio_triggering(struct gpio_bank *bank, int gpio, int 
 trigger)
 +static int _set_gpio_triggering(struct gpio_bank *bank, int gpio,
 + unsigned trigger)
you meant unsigned int ? could it be made u32.
  {
   void __iomem *reg = bank-base;
   void __iomem *base = bank-base;

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/6] gpio/omap: fix trigger type to unsigned

2012-02-23 Thread Russell King - ARM Linux 
On Thu, Feb 23, 2012 at 06:09:16PM +0530, Shubhrajyoti wrote:
 On Thursday 23 February 2012 05:40 PM, Tarun Kanti DebBarma wrote:
  -static int _set_gpio_triggering(struct gpio_bank *bank, int gpio, int 
  trigger)
  +static int _set_gpio_triggering(struct gpio_bank *bank, int gpio,
  +   unsigned trigger)
 you meant unsigned int ? could it be made u32.

In C, unsigned is the same as unsigned int.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html