Re: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.
On 2/21/2011 8:03 PM, Shilimkar, Santosh wrote:
-Original Message-
From: Cousson, Benoit [mailto:b-cous...@ti.com]
Sent: Monday, February 21, 2011 11:41 PM
To: Shilimkar, Santosh
Cc: linux-omap@vger.kernel.org; Balbi, Felipe; R, Sricharan
Subject: Re: [PATCH 5/6] omap4: Initialise the l3 device with the
hwmod data.
On 2/21/2011 2:46 PM, Shilimkar, Santosh wrote:
From: sricharanr.sricha...@ti.com
The l3 interconnect device is build with all the data required
to handle the error logging. The data is extracted from the
hwmod data base.
Signed-off-by: sricharanr.sricha...@ti.com
Signed-off-by: sricharanr.sricha...@ti.com
Tested-by: sricharanr.sricha...@ti.com
Mmm, I'm not sure the tested-by is meaningfull in your case, since
you wrote the code and so everybody will assume you tested it.
One s-o-b should be probably enough.
Well he tested whole series including the patch from Felipe.
So a tested-by on whole series doesn't hurt, right ?
Just for record, I have seen tested by applied on whole series
Where as some of the patches in this series are just comment
updates.
Cc: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/devices.c | 23 +++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-
omap2/devices.c
index 2d46f55..25fa2ad 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -57,6 +57,29 @@ static int __init omap3_l3_init(void)
}
postcore_initcall(omap3_l3_init);
+static int __init omap4_l3_init(void)
+{
+ int l;
+ struct omap_hwmod *oh;
+ struct omap_device *od;
+ char oh_name[12];
+
+ l = snprintf(oh_name, 12, l3_main_1);
+
+ oh = omap_hwmod_lookup(oh_name);
+
+ if (!oh)
+ pr_err(could not look up %s\n, oh_name);
+
+ od = omap_device_build(omap4-l3-interconnect, 0, oh, NULL,
In order to stick to the OMAP device naming convention and to have
something not dependent of the chip version, I think we'd better
name
the device like that: omap_l3_noc. Since it is a Arteris Network
On
Chip on OMAP4. We will not have to change it for OMAP5 then.
On OMAP3 the name can then be omap_l3_smx for the Sonics MX
interconnect.
Device name changes are fine but file name changes as per this.
dosn't look right if they are like
omap_l3_noc.c
omap_l3_smx.c
Why do you think that does not look right?
May be we can rename them like below
omap_l3_3xxx.c
omap_l3_4xxx.c
The point is that it will really depend of the amount of SoC specifics
data are in this file. If most of the code is reusable on OMAP5 for
example, then it makes sense to use the name of the IP.
If that's not the case, then you'd better use the SoC name.
Regards,
Benoit
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.
-Original Message- From: Cousson, Benoit [mailto:b-cous...@ti.com] Sent: Monday, March 07, 2011 3:52 PM To: Shilimkar, Santosh Cc: linux-omap@vger.kernel.org; Balbi, Felipe; R, Sricharan Subject: Re: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data. On 2/21/2011 8:03 PM, Shilimkar, Santosh wrote: [] In order to stick to the OMAP device naming convention and to have something not dependent of the chip version, I think we'd better name the device like that: omap_l3_noc. Since it is a Arteris Network On Chip on OMAP4. We will not have to change it for OMAP5 then. On OMAP3 the name can then be omap_l3_smx for the Sonics MX interconnect. Device name changes are fine but file name changes as per this. dosn't look right if they are like omap_l3_noc.c omap_l3_smx.c Why do you think that does not look right? No strong preference but noc, smx didn't look ok to me. May be we can rename them like below omap_l3_3xxx.c omap_l3_4xxx.c The point is that it will really depend of the amount of SoC specifics data are in this file. If most of the code is reusable on OMAP5 for example, then it makes sense to use the name of the IP. If that's not the case, then you'd better use the SoC name. Ok. So let's go with the IP names then. New file names will be as above. omap_l3_3xxx.c omap_l3_4xxx.c Regards, Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.
-Original Message- From: Santosh Shilimkar [mailto:santosh.shilim...@ti.com] Sent: Monday, March 07, 2011 4:49 PM To: Benoit Cousson Cc: linux-omap@vger.kernel.org; Felipe Balbi; Sricharan R Subject: RE: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data. [] Ok. So let's go with the IP names then. New file names will be as above. omap_l3_3xxx.c omap_l3_4xxx.c Sorry I mean ... omap_l3_noc.c omap_l3_smx.c Regards, Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.
-Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Friday, March 04, 2011 11:38 PM To: Santosh Shilimkar Cc: Benoit Cousson; linux-omap@vger.kernel.org; Felipe Balbi; Sricharan R Subject: Re: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data. * Santosh Shilimkar santosh.shilim...@ti.com [110303 22:19]: From: Tony Lindgren [mailto:t...@atomide.com] Also one Signed-off-by is enough like Benoit pointed out :) Ohhh... I missed this I first comment :) One SOB is enough. Santosh, can you do a pull request for me on this series when the issues are fixed? Against omap-for-linus branch please. Sure will do. Regards, Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.
* Santosh Shilimkar santosh.shilim...@ti.com [110221 11:01]: -Original Message- From: Cousson, Benoit [mailto:b-cous...@ti.com] Sent: Monday, February 21, 2011 11:41 PM To: Shilimkar, Santosh Cc: linux-omap@vger.kernel.org; Balbi, Felipe; R, Sricharan Subject: Re: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data. On 2/21/2011 2:46 PM, Shilimkar, Santosh wrote: From: sricharanr.sricha...@ti.com The l3 interconnect device is build with all the data required to handle the error logging. The data is extracted from the hwmod data base. Signed-off-by: sricharanr.sricha...@ti.com Signed-off-by: sricharanr.sricha...@ti.com Tested-by: sricharanr.sricha...@ti.com Mmm, I'm not sure the tested-by is meaningfull in your case, since you wrote the code and so everybody will assume you tested it. One s-o-b should be probably enough. Well he tested whole series including the patch from Felipe. So a tested-by on whole series doesn't hurt, right ? Just for record, I have seen tested by applied on whole series Where as some of the patches in this series are just comment updates. Well Signed-off-by also means Tested-by. If not, it should be specifically mentioned when the patch is posted. Something like PLEASE NOTE THAT THIS PATCH IS COMPLETELY UNTESTED. Also one Signed-off-by is enough like Benoit pointed out :) Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.
-Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Friday, March 04, 2011 12:01 AM To: Santosh Shilimkar Cc: Benoit Cousson; linux-omap@vger.kernel.org; Felipe Balbi; Sricharan R Subject: Re: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data. * Santosh Shilimkar santosh.shilim...@ti.com [110221 11:01]: -Original Message- From: Cousson, Benoit [mailto:b-cous...@ti.com] Sent: Monday, February 21, 2011 11:41 PM To: Shilimkar, Santosh Cc: linux-omap@vger.kernel.org; Balbi, Felipe; R, Sricharan Subject: Re: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data. On 2/21/2011 2:46 PM, Shilimkar, Santosh wrote: From: sricharanr.sricha...@ti.com The l3 interconnect device is build with all the data required to handle the error logging. The data is extracted from the hwmod data base. Signed-off-by: sricharanr.sricha...@ti.com Signed-off-by: sricharanr.sricha...@ti.com Tested-by: sricharanr.sricha...@ti.com Mmm, I'm not sure the tested-by is meaningfull in your case, since you wrote the code and so everybody will assume you tested it. One s-o-b should be probably enough. Well he tested whole series including the patch from Felipe. So a tested-by on whole series doesn't hurt, right ? Just for record, I have seen tested by applied on whole series Where as some of the patches in this series are just comment updates. Well Signed-off-by also means Tested-by. If not, it should be specifically mentioned when the patch is posted. Something like PLEASE NOTE THAT THIS PATCH IS COMPLETELY UNTESTED. Sure. Also one Signed-off-by is enough like Benoit pointed out :) Ohhh... I missed this I first comment :) One SOB is enough. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.
From: sricharan r.sricha...@ti.com
The l3 interconnect device is build with all the data required
to handle the error logging. The data is extracted from the
hwmod data base.
Signed-off-by: sricharan r.sricha...@ti.com
Signed-off-by: sricharan r.sricha...@ti.com
Tested-by: sricharan r.sricha...@ti.com
Cc: Benoit Cousson b-cous...@ti.com
---
arch/arm/mach-omap2/devices.c | 23 +++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 2d46f55..25fa2ad 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -57,6 +57,29 @@ static int __init omap3_l3_init(void)
}
postcore_initcall(omap3_l3_init);
+static int __init omap4_l3_init(void)
+{
+ int l;
+ struct omap_hwmod *oh;
+ struct omap_device *od;
+ char oh_name[12];
+
+ l = snprintf(oh_name, 12, l3_main_1);
+
+ oh = omap_hwmod_lookup(oh_name);
+
+ if (!oh)
+ pr_err(could not look up %s\n, oh_name);
+
+ od = omap_device_build(omap4-l3-interconnect, 0, oh, NULL,
+0, NULL, 0, 0);
+
+ WARN(IS_ERR(od), could not build omap_device for %s\n, oh_name);
+
+ return PTR_ERR(od);
+}
+postcore_initcall(omap4_l3_init);
+
#if defined(CONFIG_VIDEO_OMAP2) || defined(CONFIG_VIDEO_OMAP2_MODULE)
static struct resource cam_resources[] = {
--
1.7.0.4
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.
On 2/21/2011 2:46 PM, Shilimkar, Santosh wrote:
From: sricharanr.sricha...@ti.com
The l3 interconnect device is build with all the data required
to handle the error logging. The data is extracted from the
hwmod data base.
Signed-off-by: sricharanr.sricha...@ti.com
Signed-off-by: sricharanr.sricha...@ti.com
Tested-by: sricharanr.sricha...@ti.com
Mmm, I'm not sure the tested-by is meaningfull in your case, since you
wrote the code and so everybody will assume you tested it.
One s-o-b should be probably enough.
Cc: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/devices.c | 23 +++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 2d46f55..25fa2ad 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -57,6 +57,29 @@ static int __init omap3_l3_init(void)
}
postcore_initcall(omap3_l3_init);
+static int __init omap4_l3_init(void)
+{
+ int l;
+ struct omap_hwmod *oh;
+ struct omap_device *od;
+ char oh_name[12];
+
+ l = snprintf(oh_name, 12, l3_main_1);
+
+ oh = omap_hwmod_lookup(oh_name);
+
+ if (!oh)
+ pr_err(could not look up %s\n, oh_name);
+
+ od = omap_device_build(omap4-l3-interconnect, 0, oh, NULL,
In order to stick to the OMAP device naming convention and to have
something not dependent of the chip version, I think we'd better name
the device like that: omap_l3_noc. Since it is a Arteris Network On
Chip on OMAP4. We will not have to change it for OMAP5 then.
On OMAP3 the name can then be omap_l3_smx for the Sonics MX interconnect.
Please note that the L4 is in both case a Sonics 3220. But I don't think
the L4 is managed by this series.
Maybe the driver file name should be renamed accordingly.
Regards,
Benoit
+0, NULL, 0, 0);
+
+ WARN(IS_ERR(od), could not build omap_device for %s\n, oh_name);
+
+ return PTR_ERR(od);
+}
+postcore_initcall(omap4_l3_init);
+
#if defined(CONFIG_VIDEO_OMAP2) || defined(CONFIG_VIDEO_OMAP2_MODULE)
static struct resource cam_resources[] = {
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.
-Original Message-
From: Cousson, Benoit [mailto:b-cous...@ti.com]
Sent: Monday, February 21, 2011 11:41 PM
To: Shilimkar, Santosh
Cc: linux-omap@vger.kernel.org; Balbi, Felipe; R, Sricharan
Subject: Re: [PATCH 5/6] omap4: Initialise the l3 device with the
hwmod data.
On 2/21/2011 2:46 PM, Shilimkar, Santosh wrote:
From: sricharanr.sricha...@ti.com
The l3 interconnect device is build with all the data required
to handle the error logging. The data is extracted from the
hwmod data base.
Signed-off-by: sricharanr.sricha...@ti.com
Signed-off-by: sricharanr.sricha...@ti.com
Tested-by: sricharanr.sricha...@ti.com
Mmm, I'm not sure the tested-by is meaningfull in your case, since
you wrote the code and so everybody will assume you tested it.
One s-o-b should be probably enough.
Well he tested whole series including the patch from Felipe.
So a tested-by on whole series doesn't hurt, right ?
Just for record, I have seen tested by applied on whole series
Where as some of the patches in this series are just comment
updates.
Cc: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/devices.c | 23 +++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-
omap2/devices.c
index 2d46f55..25fa2ad 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -57,6 +57,29 @@ static int __init omap3_l3_init(void)
}
postcore_initcall(omap3_l3_init);
+static int __init omap4_l3_init(void)
+{
+ int l;
+ struct omap_hwmod *oh;
+ struct omap_device *od;
+ char oh_name[12];
+
+ l = snprintf(oh_name, 12, l3_main_1);
+
+ oh = omap_hwmod_lookup(oh_name);
+
+ if (!oh)
+ pr_err(could not look up %s\n, oh_name);
+
+ od = omap_device_build(omap4-l3-interconnect, 0, oh, NULL,
In order to stick to the OMAP device naming convention and to have
something not dependent of the chip version, I think we'd better
name
the device like that: omap_l3_noc. Since it is a Arteris Network
On
Chip on OMAP4. We will not have to change it for OMAP5 then.
On OMAP3 the name can then be omap_l3_smx for the Sonics MX
interconnect.
Device name changes are fine but file name changes as per this.
dosn't look right if they are like
omap_l3_noc.c
omap_l3_smx.c
May be we can rename them like below
omap_l3_3xxx.c
omap_l3_4xxx.c
Please note that the L4 is in both case a Sonics 3220. But I don't
think
the L4 is managed by this series.
Maybe the driver file name should be renamed accordingly.
L4 is not included.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
