Re: [PATCH 7/8] 34XX: PM: Workaround to disable mmc

2008-06-18 Thread Högander Jouni
ext Madhusudhan Chikkature [EMAIL PROTECTED] writes:

 - Original Message - 
 From: Högander Jouni [EMAIL PROTECTED]
 To: ext Felipe Balbi [EMAIL PROTECTED]
 Cc: linux-omap@vger.kernel.org
 Sent: Tuesday, June 17, 2008 5:39 PM
 Subject: Re: [PATCH 7/8] 34XX: PM: Workaround to disable mmc


 ext Felipe Balbi [EMAIL PROTECTED] writes:

 On Tue, 17 Jun 2008 10:31:11 +0300, Jouni Hogander
 [EMAIL PROTECTED] wrote:
 Current hsmmc is not pm friendly. Disable it because it prevents omap3
 retention

 Disabling will just hide the bug. Better making it modular
 and let mmc guys dig on it.

 Ok, I can change it, if this set needs to be sent again. I think
 disabling mmc increases visibility of its PM problems. I mean missing
 mmc driver is more visible than missing PM in this case.


 What do you need to make it more pm friendly?

 Not to prevent omap retention.
 When are you expecting the omap to go into retention? Is it in the
 suspend path?

I expect it to enter retention when suspending yes. It should also
enter retention dynamically. I mean when mpu enters wfi in pm_idle loop.

-- 
Jouni Högander

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 7/8] 34XX: PM: Workaround to disable mmc

2008-06-17 Thread Jouni Hogander
Current hsmmc is not pm friendly. Disable it because it prevents omap3
retention

Signed-off-by: Jouni Hogander [EMAIL PROTECTED]
---
 arch/arm/configs/omap_3430sdp_defconfig |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/configs/omap_3430sdp_defconfig 
b/arch/arm/configs/omap_3430sdp_defconfig
index 947c25f..ee902ae 100644
--- a/arch/arm/configs/omap_3430sdp_defconfig
+++ b/arch/arm/configs/omap_3430sdp_defconfig
@@ -1043,7 +1043,7 @@ CONFIG_USB_ZERO=y
 # CONFIG_USB_G_SERIAL is not set
 # CONFIG_USB_MIDI_GADGET is not set
 # CONFIG_USB_G_PRINTER is not set
-CONFIG_MMC=y
+# CONFIG_MMC is not set
 # CONFIG_MMC_DEBUG is not set
 # CONFIG_MMC_UNSAFE_RESUME is not set
 
-- 
1.5.5

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 7/8] 34XX: PM: Workaround to disable mmc

2008-06-17 Thread Felipe Balbi


On Tue, 17 Jun 2008 10:31:11 +0300, Jouni Hogander
[EMAIL PROTECTED] wrote:
 Current hsmmc is not pm friendly. Disable it because it prevents omap3
 retention

Disabling will just hide the bug. Better making it modular
and let mmc guys dig on it.

What do you need to make it more pm friendly?

-- 
Best Regards,

Felipe Balbi
http://felipebalbi.com
[EMAIL PROTECTED]

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 7/8] 34XX: PM: Workaround to disable mmc

2008-06-17 Thread Högander Jouni
ext Felipe Balbi [EMAIL PROTECTED] writes:

 On Tue, 17 Jun 2008 10:31:11 +0300, Jouni Hogander
 [EMAIL PROTECTED] wrote:
 Current hsmmc is not pm friendly. Disable it because it prevents omap3
 retention

 Disabling will just hide the bug. Better making it modular
 and let mmc guys dig on it.

Ok, I can change it, if this set needs to be sent again. I think
disabling mmc increases visibility of its PM problems. I mean missing
mmc driver is more visible than missing PM in this case.


 What do you need to make it more pm friendly?

Not to prevent omap retention.


 -- 
 Best Regards,

 Felipe Balbi
 http://felipebalbi.com
 [EMAIL PROTECTED]




-- 
Jouni Högander

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH 7/8] 34XX: PM: Workaround to disable mmc

2008-06-17 Thread Woodruff, Richard
 On Tue, 17 Jun 2008 10:31:11 +0300, Jouni Hogander
 [EMAIL PROTECTED] wrote:
  Current hsmmc is not pm friendly. Disable it because it prevents omap3
  retention

 Disabling will just hide the bug. Better making it modular
 and let mmc guys dig on it.

 What do you need to make it more pm friendly?

Madhu recently traded work arounds in one of our MMC trees.  A rest of command 
line was used instead of toggle of idle handshakes.  Hardware designers did 
confirm it being needed.  I'll forward a version.

Regards,
Richard W.


Re: [PATCH 7/8] 34XX: PM: Workaround to disable mmc

2008-06-17 Thread Koen Kooi

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


Op 17 jun 2008, om 14:09 heeft Högander Jouni het volgende geschreven:


ext Felipe Balbi [EMAIL PROTECTED] writes:


On Tue, 17 Jun 2008 10:31:11 +0300, Jouni Hogander
[EMAIL PROTECTED] wrote:
Current hsmmc is not pm friendly. Disable it because it prevents  
omap3

retention


Disabling will just hide the bug. Better making it modular
and let mmc guys dig on it.


Ok, I can change it, if this set needs to be sent again. I think
disabling mmc increases visibility of its PM problems. I mean missing
mmc driver is more visible than missing PM in this case.


My rootfs and kernel are on SD, so disabling SD results in the biggest  
powersaving possible: not turning on the board ;)

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFIV7BlMkyGM64RGpERAlcJAJ412DshyLeAvZhrCa0beMXsZPy2UgCeL/KQ
UKjp5Lb11vjTd9P/lSovNCU=
=36Pq
-END PGP SIGNATURE-
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 7/8] 34XX: PM: Workaround to disable mmc

2008-06-17 Thread Madhusudhan Chikkature


- Original Message - 
From: Högander Jouni [EMAIL PROTECTED]

To: ext Felipe Balbi [EMAIL PROTECTED]
Cc: linux-omap@vger.kernel.org
Sent: Tuesday, June 17, 2008 5:39 PM
Subject: Re: [PATCH 7/8] 34XX: PM: Workaround to disable mmc



ext Felipe Balbi [EMAIL PROTECTED] writes:


On Tue, 17 Jun 2008 10:31:11 +0300, Jouni Hogander
[EMAIL PROTECTED] wrote:

Current hsmmc is not pm friendly. Disable it because it prevents omap3
retention


Disabling will just hide the bug. Better making it modular
and let mmc guys dig on it.


Ok, I can change it, if this set needs to be sent again. I think
disabling mmc increases visibility of its PM problems. I mean missing
mmc driver is more visible than missing PM in this case.



What do you need to make it more pm friendly?


Not to prevent omap retention.
When are you expecting the omap to go into retention? Is it in the suspend 
path?


Regards,
Madhu




--
Best Regards,

Felipe Balbi
http://felipebalbi.com
[EMAIL PROTECTED]





--
Jouni Högander

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html