Re: [PATCH RFC] ARM: dts: am335x: update USB DT references

2014-04-23 Thread Tony Lindgren 
* Benoit Cousson bcous...@baylibre.com [140422 07:14]:
 Hi Leigh,
 
 On 16/04/2014 13:26, Leigh Brown wrote:
 In ARM: dts: am33xx: correcting dt node unit address for usb, the
 usb_ctrl_mod and cppi41dma nodes were updated with the correct register
 addresses.  However, the dts files that reference these nodes were not
 updated, and those devices are no longer being enabled.
 
 This patch corrects the references for the affected dts files.
 
 Thanks for the fix. BTW, why is it a RFC? Do you plan to send an updated
 version?
 
 FYI, even with this fix, the BBB still does not have a working MUSB on
 3.15-rc2. Have you observed that as well?
 
 Signed-off-by: Leigh Brown le...@solinno.co.uk
 
 If this is a final version, I'll apply it for -rc3.

Looks like I already have this in omap-for-v3.15/fixes-v2, sorry
looks like I never replied to this one.

Regards,

Tony 
 
 ---
   arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
   arch/arm/boot/dts/am335x-evm.dts  | 4 ++--
   arch/arm/boot/dts/am335x-evmsk.dts| 4 ++--
   arch/arm/boot/dts/am335x-igep0033.dtsi| 4 ++--
   4 files changed, 8 insertions(+), 8 deletions(-)
 
 diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi 
 b/arch/arm/boot/dts/am335x-bone-common.dtsi
 index e3f27ec..2e7d932 100644
 --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
 +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
 @@ -183,7 +183,7 @@
   usb {
  status = okay;
 
 -control@44e1 {
 +control@44e10620 {
  status = okay;
  };
 
 @@ -204,7 +204,7 @@
  dr_mode = host;
  };
 
 -dma-controller@07402000  {
 +dma-controller@47402000  {
  status = okay;
  };
   };
 diff --git a/arch/arm/boot/dts/am335x-evm.dts 
 b/arch/arm/boot/dts/am335x-evm.dts
 index 28ae040..77df10d 100644
 --- a/arch/arm/boot/dts/am335x-evm.dts
 +++ b/arch/arm/boot/dts/am335x-evm.dts
 @@ -331,7 +331,7 @@
   usb {
  status = okay;
 
 -control@44e1 {
 +control@44e10620 {
  status = okay;
  };
 
 @@ -352,7 +352,7 @@
  dr_mode = host;
  };
 
 -dma-controller@07402000  {
 +dma-controller@47402000  {
  status = okay;
  };
   };
 diff --git a/arch/arm/boot/dts/am335x-evmsk.dts 
 b/arch/arm/boot/dts/am335x-evmsk.dts
 index ec08f6f..ab23885 100644
 --- a/arch/arm/boot/dts/am335x-evmsk.dts
 +++ b/arch/arm/boot/dts/am335x-evmsk.dts
 @@ -364,7 +364,7 @@
   usb {
  status = okay;
 
 -control@44e1 {
 +control@44e10620 {
  status = okay;
  };
 
 @@ -385,7 +385,7 @@
  dr_mode = host;
  };
 
 -dma-controller@07402000  {
 +dma-controller@47402000  {
  status = okay;
  };
   };
 diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi 
 b/arch/arm/boot/dts/am335x-igep0033.dtsi
 index 7063311..5942e7d 100644
 --- a/arch/arm/boot/dts/am335x-igep0033.dtsi
 +++ b/arch/arm/boot/dts/am335x-igep0033.dtsi
 @@ -202,7 +202,7 @@
   usb {
  status = okay;
 
 -control@44e1 {
 +control@44e10620 {
  status = okay;
  };
 
 @@ -223,7 +223,7 @@
  dr_mode = host;
  };
 
 -dma-controller@07402000  {
 +dma-controller@47402000  {
  status = okay;
  };
   };
 
 
 
 -- 
 Benoît Cousson
 BayLibre
 Embedded Linux Technology Lab
 www.baylibre.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] ARM: dts: am335x: update USB DT references

2014-04-23 Thread Ezequiel Garcia 
On Apr 23, Tony Lindgren wrote:
 * Benoit Cousson bcous...@baylibre.com [140422 07:14]:
  Hi Leigh,
  
  On 16/04/2014 13:26, Leigh Brown wrote:
  In ARM: dts: am33xx: correcting dt node unit address for usb, the
  usb_ctrl_mod and cppi41dma nodes were updated with the correct register
  addresses.  However, the dts files that reference these nodes were not
  updated, and those devices are no longer being enabled.
  
  This patch corrects the references for the affected dts files.

Maybe someone can take care of using phandles instead?

This way, the board's dts files would be immune to such .dtsi changes.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] ARM: dts: am335x: update USB DT references

2014-04-23 Thread Benoit Cousson 

Hi Tony,

On 23/04/2014 16:48, Tony Lindgren wrote:

* Benoit Cousson bcous...@baylibre.com [140422 07:14]:

Hi Leigh,

On 16/04/2014 13:26, Leigh Brown wrote:

In ARM: dts: am33xx: correcting dt node unit address for usb, the
usb_ctrl_mod and cppi41dma nodes were updated with the correct register
addresses.  However, the dts files that reference these nodes were not
updated, and those devices are no longer being enabled.

This patch corrects the references for the affected dts files.


Thanks for the fix. BTW, why is it a RFC? Do you plan to send an updated
version?

FYI, even with this fix, the BBB still does not have a working MUSB on
3.15-rc2. Have you observed that as well?


Signed-off-by: Leigh Brown le...@solinno.co.uk


If this is a final version, I'll apply it for -rc3.


Looks like I already have this in omap-for-v3.15/fixes-v2, sorry
looks like I never replied to this one.


:-)

OK, I'll let you handle this one.

Thanks,
Benoit



Regards,

Tony


---
  arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
  arch/arm/boot/dts/am335x-evm.dts  | 4 ++--
  arch/arm/boot/dts/am335x-evmsk.dts| 4 ++--
  arch/arm/boot/dts/am335x-igep0033.dtsi| 4 ++--
  4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi 
b/arch/arm/boot/dts/am335x-bone-common.dtsi
index e3f27ec..2e7d932 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -183,7 +183,7 @@
  usb {
status = okay;

-   control@44e1 {
+   control@44e10620 {
status = okay;
};

@@ -204,7 +204,7 @@
dr_mode = host;
};

-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
  };
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 28ae040..77df10d 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -331,7 +331,7 @@
  usb {
status = okay;

-   control@44e1 {
+   control@44e10620 {
status = okay;
};

@@ -352,7 +352,7 @@
dr_mode = host;
};

-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
  };
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts 
b/arch/arm/boot/dts/am335x-evmsk.dts
index ec08f6f..ab23885 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -364,7 +364,7 @@
  usb {
status = okay;

-   control@44e1 {
+   control@44e10620 {
status = okay;
};

@@ -385,7 +385,7 @@
dr_mode = host;
};

-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
  };
diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi 
b/arch/arm/boot/dts/am335x-igep0033.dtsi
index 7063311..5942e7d 100644
--- a/arch/arm/boot/dts/am335x-igep0033.dtsi
+++ b/arch/arm/boot/dts/am335x-igep0033.dtsi
@@ -202,7 +202,7 @@
  usb {
status = okay;

-   control@44e1 {
+   control@44e10620 {
status = okay;
};

@@ -223,7 +223,7 @@
dr_mode = host;
};

-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
  };




--
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com



--
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] ARM: dts: am335x: update USB DT references

2014-04-23 Thread Benoit Cousson 

Hi Ezequiel,

On 23/04/2014 17:17, Ezequiel Garcia wrote:

On Apr 23, Tony Lindgren wrote:

* Benoit Cousson bcous...@baylibre.com [140422 07:14]:

Hi Leigh,

On 16/04/2014 13:26, Leigh Brown wrote:

In ARM: dts: am33xx: correcting dt node unit address for usb, the
usb_ctrl_mod and cppi41dma nodes were updated with the correct register
addresses.  However, the dts files that reference these nodes were not
updated, and those devices are no longer being enabled.

This patch corrects the references for the affected dts files.


Maybe someone can take care of using phandles instead?

This way, the board's dts files would be immune to such .dtsi changes.


Indeed, that will avoid such issues.

Are you volunteer for that cleanup ? :-)

Thanks,
Benoit


--
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] ARM: dts: am335x: update USB DT references

2014-04-23 Thread Ezequiel Garcia 
On Apr 23, Benoit Cousson wrote:
 Hi Ezequiel,
 
 On 23/04/2014 17:17, Ezequiel Garcia wrote:
 On Apr 23, Tony Lindgren wrote:
 * Benoit Cousson bcous...@baylibre.com [140422 07:14]:
 Hi Leigh,
 
 On 16/04/2014 13:26, Leigh Brown wrote:
 In ARM: dts: am33xx: correcting dt node unit address for usb, the
 usb_ctrl_mod and cppi41dma nodes were updated with the correct register
 addresses.  However, the dts files that reference these nodes were not
 updated, and those devices are no longer being enabled.
 
 This patch corrects the references for the affected dts files.
 
 Maybe someone can take care of using phandles instead?
 
 This way, the board's dts files would be immune to such .dtsi changes.
 
 Indeed, that will avoid such issues.
 
 Are you volunteer for that cleanup ? :-)
 

Sure, I've already done that for my custom dts. It's a simple change.

If someone feels like doing this before I get to send the patches,
be my guest :-)
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] ARM: dts: am335x: update USB DT references

2014-04-22 Thread Benoit Cousson 

Hi Leigh,

On 16/04/2014 13:26, Leigh Brown wrote:

In ARM: dts: am33xx: correcting dt node unit address for usb, the
usb_ctrl_mod and cppi41dma nodes were updated with the correct register
addresses.  However, the dts files that reference these nodes were not
updated, and those devices are no longer being enabled.

This patch corrects the references for the affected dts files.


Thanks for the fix. BTW, why is it a RFC? Do you plan to send an updated 
version?


FYI, even with this fix, the BBB still does not have a working MUSB on 
3.15-rc2. Have you observed that as well?



Signed-off-by: Leigh Brown le...@solinno.co.uk


If this is a final version, I'll apply it for -rc3.

Thanks,
Benoit



---
  arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
  arch/arm/boot/dts/am335x-evm.dts  | 4 ++--
  arch/arm/boot/dts/am335x-evmsk.dts| 4 ++--
  arch/arm/boot/dts/am335x-igep0033.dtsi| 4 ++--
  4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi 
b/arch/arm/boot/dts/am335x-bone-common.dtsi
index e3f27ec..2e7d932 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -183,7 +183,7 @@
  usb {
status = okay;

-   control@44e1 {
+   control@44e10620 {
status = okay;
};

@@ -204,7 +204,7 @@
dr_mode = host;
};

-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
  };
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 28ae040..77df10d 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -331,7 +331,7 @@
  usb {
status = okay;

-   control@44e1 {
+   control@44e10620 {
status = okay;
};

@@ -352,7 +352,7 @@
dr_mode = host;
};

-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
  };
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts 
b/arch/arm/boot/dts/am335x-evmsk.dts
index ec08f6f..ab23885 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -364,7 +364,7 @@
  usb {
status = okay;

-   control@44e1 {
+   control@44e10620 {
status = okay;
};

@@ -385,7 +385,7 @@
dr_mode = host;
};

-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
  };
diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi 
b/arch/arm/boot/dts/am335x-igep0033.dtsi
index 7063311..5942e7d 100644
--- a/arch/arm/boot/dts/am335x-igep0033.dtsi
+++ b/arch/arm/boot/dts/am335x-igep0033.dtsi
@@ -202,7 +202,7 @@
  usb {
status = okay;

-   control@44e1 {
+   control@44e10620 {
status = okay;
};

@@ -223,7 +223,7 @@
dr_mode = host;
};

-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
  };




--
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH RFC] ARM: dts: am335x: update USB DT references

2014-04-16 Thread Leigh Brown 
In ARM: dts: am33xx: correcting dt node unit address for usb, the
usb_ctrl_mod and cppi41dma nodes were updated with the correct register
addresses.  However, the dts files that reference these nodes were not
updated, and those devices are no longer being enabled.

This patch corrects the references for the affected dts files.

Signed-off-by: Leigh Brown le...@solinno.co.uk
---
 arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
 arch/arm/boot/dts/am335x-evm.dts  | 4 ++--
 arch/arm/boot/dts/am335x-evmsk.dts| 4 ++--
 arch/arm/boot/dts/am335x-igep0033.dtsi| 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi 
b/arch/arm/boot/dts/am335x-bone-common.dtsi
index e3f27ec..2e7d932 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -183,7 +183,7 @@
 usb {
status = okay;
 
-   control@44e1 {
+   control@44e10620 {
status = okay;
};
 
@@ -204,7 +204,7 @@
dr_mode = host;
};
 
-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
 };
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 28ae040..77df10d 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -331,7 +331,7 @@
 usb {
status = okay;
 
-   control@44e1 {
+   control@44e10620 {
status = okay;
};
 
@@ -352,7 +352,7 @@
dr_mode = host;
};
 
-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
 };
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts 
b/arch/arm/boot/dts/am335x-evmsk.dts
index ec08f6f..ab23885 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -364,7 +364,7 @@
 usb {
status = okay;
 
-   control@44e1 {
+   control@44e10620 {
status = okay;
};
 
@@ -385,7 +385,7 @@
dr_mode = host;
};
 
-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
 };
diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi 
b/arch/arm/boot/dts/am335x-igep0033.dtsi
index 7063311..5942e7d 100644
--- a/arch/arm/boot/dts/am335x-igep0033.dtsi
+++ b/arch/arm/boot/dts/am335x-igep0033.dtsi
@@ -202,7 +202,7 @@
 usb {
status = okay;
 
-   control@44e1 {
+   control@44e10620 {
status = okay;
};
 
@@ -223,7 +223,7 @@
dr_mode = host;
};
 
-   dma-controller@07402000  {
+   dma-controller@47402000  {
status = okay;
};
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html