RE: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers
On Sat, Sep 29, 2012 at 03:17:51, Hunter, Jon wrote: On 09/28/2012 01:51 PM, Vaibhav Hiremath wrote: On 9/26/2012 10:23 PM, Jon Hunter wrote: On 09/20/2012 06:53 PM, Tony Lindgren wrote: * Benoit Cousson b-cous...@ti.com [120919 19:24]: Hi Tony, I was about to take the DTS patch, but was wondering if you will pull the driver changes for 3.7. I suggest that you do a separate branch on top of Paul's hwmod series when he posts those if that works for you? Benoit, I see that you have pulled in the DTS patch. Do you guys want me to rebase the remaining patches with Rob's change on Tony's master branch and re-submit? Jon, Sorry for delayed response, But I tried using your omap_test application to validate this patch series, but it is failing for me. How did you test it? Are you running same test application at your end? Sorry, I now see you are using the latest test code! I was too hasty when I saw the first error ;-) Jon, have patience ;-) I understand, sometimes it happens un-intentionally. I am debugging this issue, i just thought I should tell you this before its too late. Thanks. Below is the log - [root@arago /]# echo 3 /tmp/omap-test/timer/one [ 79.612223] omap_dm_timer_request_specific: Please use omap_dm_timer_request_by_cap() [ 79.620636] Timer 3 not available! This is expected because omap_dm_timer_request_specific() is no longer supported. I should remove in the omap-test/timer/one going forward. [root@arago /]# [root@arago /]# echo 3 /tmp/omap-test/timer/all [ 135.111949] Testing 48042000.timer with 2400 Hz clock ... [root@arago /]# [ 137.457389] Timer read test PASSED! No errors, 100 loops [ 137.463267] Timer interrupt test PASSED! [ 137.467650] Testing 48042000.timer with 32768 Hz clock ... [ 139.816892] Timer read test PASSED! No errors, 100 loops [ 139.830776] Timer interrupt test PASSED! [ 139.835245] Testing 48044000.timer with 2400 Hz clock ... [ 142.183912] Timer read test PASSED! No errors, 100 loops [ 142.189734] Timer interrupt test PASSED! [ 142.194076] Testing 48044000.timer with 32768 Hz clock ... [ 144.543451] Timer read test PASSED! No errors, 100 loops [ 144.557334] Timer interrupt test PASSED! [ 144.561806] Testing 48046000.timer with 2400 Hz clock ... [ 146.910469] Timer read test PASSED! No errors, 100 loops [ 147.910493] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 147.917598] Testing 48046000.timer with 32768 Hz clock ... [ 150.262203] Timer read test PASSED! No errors, 100 loops [ 151.262049] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 151.269298] Testing 48048000.timer with 2400 Hz clock ... [ 153.613596] Timer read test PASSED! No errors, 100 loops [ 154.613618] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 154.620725] Testing 48048000.timer with 32768 Hz clock ... [ 156.965324] Timer read test PASSED! No errors, 100 loops [ 157.965176] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 157.972419] Testing 4804a000.timer with 2400 Hz clock ... [root@arago /]# [ 160.316753] Timer read test PASSED! No errors, 100 loops [root@arago /]# [ 161.316728] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 161.323912] Testing 4804a000.timer with 32768 Hz clock ... [root@arago /]# [ 163.668490] Timer read test PASSED! No errors, 100 loops [ 164.668328] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 164.675545] Tested 5 timers, skipped 6 timers and detected 6 errors [ 164.682202] Test iteration 0 complete in 29 secs [ 164.687104] Test summary: Iterations 1, Errors 6 What is interesting is that it is the interrupt test that is failing for timers 5-7. Any chance there is a problem with the interrupt mapping? I checked the documentation for AM335x and I don't see anything obvious that is wrong with the binding unless the documentation itself is wrong. Given that the interrupts work on timers 3 and 4 it appears to be a interrupt configuration problem somewhere. We could adapt the test to see if an interrupt is pending in the timer peripheral when it fails. This would tell us that the timer is working but the interrupt is not being enabled correctly in the interrupt controller. I am also surprised to see this, and as you mentioned, nothing I looks obviously wrong to me in timer5-7. I have to debug this further and will keep you updated. Thanks, Vaibhav Cheers Jon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers
On 9/26/2012 10:23 PM, Jon Hunter wrote: On 09/20/2012 06:53 PM, Tony Lindgren wrote: * Benoit Cousson b-cous...@ti.com [120919 19:24]: Hi Tony, I was about to take the DTS patch, but was wondering if you will pull the driver changes for 3.7. I suggest that you do a separate branch on top of Paul's hwmod series when he posts those if that works for you? Benoit, I see that you have pulled in the DTS patch. Do you guys want me to rebase the remaining patches with Rob's change on Tony's master branch and re-submit? Jon, Sorry for delayed response, But I tried using your omap_test application to validate this patch series, but it is failing for me. How did you test it? Are you running same test application at your end? I am debugging this issue, i just thought I should tell you this before its too late. Below is the log - [root@arago /]# echo 3 /tmp/omap-test/timer/one [ 79.612223] omap_dm_timer_request_specific: Please use omap_dm_timer_request_by_cap() [ 79.620636] Timer 3 not available! [root@arago /]# [root@arago /]# echo 3 /tmp/omap-test/timer/all [ 135.111949] Testing 48042000.timer with 2400 Hz clock ... [root@arago /]# [ 137.457389] Timer read test PASSED! No errors, 100 loops [ 137.463267] Timer interrupt test PASSED! [ 137.467650] Testing 48042000.timer with 32768 Hz clock ... [ 139.816892] Timer read test PASSED! No errors, 100 loops [ 139.830776] Timer interrupt test PASSED! [ 139.835245] Testing 48044000.timer with 2400 Hz clock ... [ 142.183912] Timer read test PASSED! No errors, 100 loops [ 142.189734] Timer interrupt test PASSED! [ 142.194076] Testing 48044000.timer with 32768 Hz clock ... [ 144.543451] Timer read test PASSED! No errors, 100 loops [ 144.557334] Timer interrupt test PASSED! [ 144.561806] Testing 48046000.timer with 2400 Hz clock ... [ 146.910469] Timer read test PASSED! No errors, 100 loops [ 147.910493] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 147.917598] Testing 48046000.timer with 32768 Hz clock ... [ 150.262203] Timer read test PASSED! No errors, 100 loops [ 151.262049] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 151.269298] Testing 48048000.timer with 2400 Hz clock ... [ 153.613596] Timer read test PASSED! No errors, 100 loops [ 154.613618] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 154.620725] Testing 48048000.timer with 32768 Hz clock ... [ 156.965324] Timer read test PASSED! No errors, 100 loops [ 157.965176] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 157.972419] Testing 4804a000.timer with 2400 Hz clock ... [root@arago /]# [ 160.316753] Timer read test PASSED! No errors, 100 loops [root@arago /]# [ 161.316728] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 161.323912] Testing 4804a000.timer with 32768 Hz clock ... [root@arago /]# [ 163.668490] Timer read test PASSED! No errors, 100 loops [ 164.668328] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 164.675545] Tested 5 timers, skipped 6 timers and detected 6 errors [ 164.682202] Test iteration 0 complete in 29 secs [ 164.687104] Test summary: Iterations 1, Errors 6 Cheers Jon ___ devicetree-discuss mailing list devicetree-disc...@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers
On 09/28/2012 01:51 PM, Vaibhav Hiremath wrote: On 9/26/2012 10:23 PM, Jon Hunter wrote: On 09/20/2012 06:53 PM, Tony Lindgren wrote: * Benoit Cousson b-cous...@ti.com [120919 19:24]: Hi Tony, I was about to take the DTS patch, but was wondering if you will pull the driver changes for 3.7. I suggest that you do a separate branch on top of Paul's hwmod series when he posts those if that works for you? Benoit, I see that you have pulled in the DTS patch. Do you guys want me to rebase the remaining patches with Rob's change on Tony's master branch and re-submit? Jon, Sorry for delayed response, But I tried using your omap_test application to validate this patch series, but it is failing for me. How did you test it? Are you running same test application at your end? Check your email on Sept 14th. I sent you the latest version of the test code. I will resend in case it got lost in deep space. I am debugging this issue, i just thought I should tell you this before its too late. Below is the log - [root@arago /]# echo 3 /tmp/omap-test/timer/one [ 79.612223] omap_dm_timer_request_specific: Please use omap_dm_timer_request_by_cap() [ 79.620636] Timer 3 not available! Yes that's expected as omap_dm_timer_request_specific is not supported with DT. Don't spend anytime debugging you just need the latest test. Cheers Jon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers
On 09/28/2012 01:51 PM, Vaibhav Hiremath wrote: On 9/26/2012 10:23 PM, Jon Hunter wrote: On 09/20/2012 06:53 PM, Tony Lindgren wrote: * Benoit Cousson b-cous...@ti.com [120919 19:24]: Hi Tony, I was about to take the DTS patch, but was wondering if you will pull the driver changes for 3.7. I suggest that you do a separate branch on top of Paul's hwmod series when he posts those if that works for you? Benoit, I see that you have pulled in the DTS patch. Do you guys want me to rebase the remaining patches with Rob's change on Tony's master branch and re-submit? Jon, Sorry for delayed response, But I tried using your omap_test application to validate this patch series, but it is failing for me. How did you test it? Are you running same test application at your end? Sorry, I now see you are using the latest test code! I was too hasty when I saw the first error ;-) I am debugging this issue, i just thought I should tell you this before its too late. Thanks. Below is the log - [root@arago /]# echo 3 /tmp/omap-test/timer/one [ 79.612223] omap_dm_timer_request_specific: Please use omap_dm_timer_request_by_cap() [ 79.620636] Timer 3 not available! This is expected because omap_dm_timer_request_specific() is no longer supported. I should remove in the omap-test/timer/one going forward. [root@arago /]# [root@arago /]# echo 3 /tmp/omap-test/timer/all [ 135.111949] Testing 48042000.timer with 2400 Hz clock ... [root@arago /]# [ 137.457389] Timer read test PASSED! No errors, 100 loops [ 137.463267] Timer interrupt test PASSED! [ 137.467650] Testing 48042000.timer with 32768 Hz clock ... [ 139.816892] Timer read test PASSED! No errors, 100 loops [ 139.830776] Timer interrupt test PASSED! [ 139.835245] Testing 48044000.timer with 2400 Hz clock ... [ 142.183912] Timer read test PASSED! No errors, 100 loops [ 142.189734] Timer interrupt test PASSED! [ 142.194076] Testing 48044000.timer with 32768 Hz clock ... [ 144.543451] Timer read test PASSED! No errors, 100 loops [ 144.557334] Timer interrupt test PASSED! [ 144.561806] Testing 48046000.timer with 2400 Hz clock ... [ 146.910469] Timer read test PASSED! No errors, 100 loops [ 147.910493] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 147.917598] Testing 48046000.timer with 32768 Hz clock ... [ 150.262203] Timer read test PASSED! No errors, 100 loops [ 151.262049] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 151.269298] Testing 48048000.timer with 2400 Hz clock ... [ 153.613596] Timer read test PASSED! No errors, 100 loops [ 154.613618] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 154.620725] Testing 48048000.timer with 32768 Hz clock ... [ 156.965324] Timer read test PASSED! No errors, 100 loops [ 157.965176] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 157.972419] Testing 4804a000.timer with 2400 Hz clock ... [root@arago /]# [ 160.316753] Timer read test PASSED! No errors, 100 loops [root@arago /]# [ 161.316728] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 161.323912] Testing 4804a000.timer with 32768 Hz clock ... [root@arago /]# [ 163.668490] Timer read test PASSED! No errors, 100 loops [ 164.668328] Timer interrupt test FAILED! No interrupt occurred in 1 sec [ 164.675545] Tested 5 timers, skipped 6 timers and detected 6 errors [ 164.682202] Test iteration 0 complete in 29 secs [ 164.687104] Test summary: Iterations 1, Errors 6 What is interesting is that it is the interrupt test that is failing for timers 5-7. Any chance there is a problem with the interrupt mapping? I checked the documentation for AM335x and I don't see anything obvious that is wrong with the binding unless the documentation itself is wrong. Given that the interrupts work on timers 3 and 4 it appears to be a interrupt configuration problem somewhere. We could adapt the test to see if an interrupt is pending in the timer peripheral when it fails. This would tell us that the timer is working but the interrupt is not being enabled correctly in the interrupt controller. Cheers Jon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers
On 09/28/2012 01:51 PM, Vaibhav Hiremath wrote: [snip] Jon, Sorry for delayed response, But I tried using your omap_test application to validate this patch series, but it is failing for me. How did you test it? Are you running same test application at your end? I am debugging this issue, i just thought I should tell you this before its too late. By the way, I have not seen any such issues on OMAP2/3/4 and so this appears to be specific to AM335x. So I would not be too concerned, we just need to understand why interrupts on some timers are not working on the AM335x. Probably a configuration issue some where and that can always be fixed separately. Cheers Jon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers
Hi All, I appear to be having problems receiving emails being sent to me by the mailing lists. I did not receive any of the responses to this patch set, but I know see online that there have been a few responses. So sorry for not responding. I have been complaining to our IT department but all they tell me is that they see no issues on their side and it is a problem with the mailing list. I find it hard to believe that I am subscribe to all 3 mailing lists in CC and I don't get a single copy of any response. I will complain again. If anyone has any way I can prove it is a problem on the TI side please let me know. Thanks Jon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers
On 09/20/2012 06:53 PM, Tony Lindgren wrote: * Benoit Cousson b-cous...@ti.com [120919 19:24]: Hi Tony, I was about to take the DTS patch, but was wondering if you will pull the driver changes for 3.7. I suggest that you do a separate branch on top of Paul's hwmod series when he posts those if that works for you? Benoit, I see that you have pulled in the DTS patch. Do you guys want me to rebase the remaining patches with Rob's change on Tony's master branch and re-submit? Cheers Jon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers
* Benoit Cousson b-cous...@ti.com [120919 19:24]: Hi Tony, I was about to take the DTS patch, but was wondering if you will pull the driver changes for 3.7. I suggest that you do a separate branch on top of Paul's hwmod series when he posts those if that works for you? Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers
Hi Tony, I was about to take the DTS patch, but was wondering if you will pull the driver changes for 3.7. Thanks, Benoit On 09/14/2012 01:31 AM, Jon Hunter wrote: This series adds device-tree support for the timers on OMAP2+ devices including AM33xx. Testing: 1. I have booted linux with this series on OMAP2420 H4, OMAP3430 Beagle and OMAP4430 Panda with/without device-tree present. 2. Vaibhav has booted linux on AM335x Beagle bone (thanks!) 3. I have tested the all the timers (not used by the kernel as sys-timers) on OMAP2420 H4, OMAP3430 Beagle and OMAP4430 Panda with/without device-tree with this series. The testing includes ... a. Configuring, starting a timer and checking the counter value is incrementing. b. Testing timer overflow interrupt when timer expires. c. Using different clock sources to operate the timer with. 4. Verified on OMAP4430 and AM33xx (Vaibhav) that the kernel boots when using a GP timer as clock-source (default for OMAP is 32k-sync timer). Thanks to Vaibhav for catching and tracking down a bug when using a GP-timer as the clock-source! V2 changes: - Remove use of device-tree alias property - Migrate OMAP timers to request timers by property instead of device ID - Include OMAP2 support Jon Hunter (7): ARM: dts: OMAP: Add timer nodes ARM: OMAP3: Dynamically disable secure timer nodes for secure devices ARM: OMAP4: Add timer clock aliases for device-tree ARM: OMAP: Add a timer attribute for timers that can interrupt the DSP ARM: OMAP: Add function to request a timer by capability ARM: OMAP3: Add generic machine descriptor for boards with OMAP3 GP devices ARM: OMAP: Add DT support for timer driver .../devicetree/bindings/arm/omap/timer.txt | 30 + arch/arm/boot/dts/am33xx.dtsi | 61 + arch/arm/boot/dts/omap2.dtsi | 86 + arch/arm/boot/dts/omap2420.dtsi|8 ++ arch/arm/boot/dts/omap2430.dtsi|8 ++ arch/arm/boot/dts/omap3.dtsi | 96 ++ arch/arm/boot/dts/omap4.dtsi | 86 + arch/arm/mach-omap1/timer.c|2 +- arch/arm/mach-omap2/board-generic.c| 18 +++ arch/arm/mach-omap2/clock44xx_data.c | 12 ++ arch/arm/mach-omap2/common.h |1 + arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c |9 ++ arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 15 ++- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 15 ++- arch/arm/mach-omap2/timer.c| 131 +--- arch/arm/plat-omap/dmtimer.c | 94 +- arch/arm/plat-omap/include/plat/dmtimer.h |2 + 17 files changed, 646 insertions(+), 28 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/omap/timer.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers
This series adds device-tree support for the timers on OMAP2+ devices including AM33xx. Testing: 1. I have booted linux with this series on OMAP2420 H4, OMAP3430 Beagle and OMAP4430 Panda with/without device-tree present. 2. Vaibhav has booted linux on AM335x Beagle bone (thanks!) 3. I have tested the all the timers (not used by the kernel as sys-timers) on OMAP2420 H4, OMAP3430 Beagle and OMAP4430 Panda with/without device-tree with this series. The testing includes ... a. Configuring, starting a timer and checking the counter value is incrementing. b. Testing timer overflow interrupt when timer expires. c. Using different clock sources to operate the timer with. 4. Verified on OMAP4430 and AM33xx (Vaibhav) that the kernel boots when using a GP timer as clock-source (default for OMAP is 32k-sync timer). Thanks to Vaibhav for catching and tracking down a bug when using a GP-timer as the clock-source! V2 changes: - Remove use of device-tree alias property - Migrate OMAP timers to request timers by property instead of device ID - Include OMAP2 support Jon Hunter (7): ARM: dts: OMAP: Add timer nodes ARM: OMAP3: Dynamically disable secure timer nodes for secure devices ARM: OMAP4: Add timer clock aliases for device-tree ARM: OMAP: Add a timer attribute for timers that can interrupt the DSP ARM: OMAP: Add function to request a timer by capability ARM: OMAP3: Add generic machine descriptor for boards with OMAP3 GP devices ARM: OMAP: Add DT support for timer driver .../devicetree/bindings/arm/omap/timer.txt | 30 + arch/arm/boot/dts/am33xx.dtsi | 61 + arch/arm/boot/dts/omap2.dtsi | 86 + arch/arm/boot/dts/omap2420.dtsi|8 ++ arch/arm/boot/dts/omap2430.dtsi|8 ++ arch/arm/boot/dts/omap3.dtsi | 96 ++ arch/arm/boot/dts/omap4.dtsi | 86 + arch/arm/mach-omap1/timer.c|2 +- arch/arm/mach-omap2/board-generic.c| 18 +++ arch/arm/mach-omap2/clock44xx_data.c | 12 ++ arch/arm/mach-omap2/common.h |1 + arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c |9 ++ arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 15 ++- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 15 ++- arch/arm/mach-omap2/timer.c| 131 +--- arch/arm/plat-omap/dmtimer.c | 94 +- arch/arm/plat-omap/include/plat/dmtimer.h |2 + 17 files changed, 646 insertions(+), 28 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/omap/timer.txt -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers
On 09/13/2012 06:31 PM, Jon Hunter wrote: This series adds device-tree support for the timers on OMAP2+ devices including AM33xx. One more comment. This has been tested on v3.6-rc5 and rebased on top of Tony's devel-dt branch. Cheers Jon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
