Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control
On Wed, 17 Sep 2014, Sebastian Reichel wrote: > On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote: > > On Wed, 17 Sep 2014, Nishanth Menon wrote: > > > ti,system-power-controller is more or less the standard way of > > > indicating that the PMIC is the system wide power controller and hence > > > may be used to switch off the system. Almost ALL TI PMIC drivers and > > > many Maxim PMIC drivers follow the same style. > > > > > > So support 'ti,system-power-controller' in addition to the usual > > > 'ti,use_poweroff' to indicate that the PMIC instance has control for > > > switching off the system. > > > > > > Signed-off-by: Nishanth Menon > > > --- > > > > > > V2: picked up documentation suggestion from Sebastien > > > > It would be good to get Sebastian's Ack. > > Acked-By: Sebastian Reichel > > [...] > > > > +- ti,system-power-controller: This indicates that TWL4030 is the > > > + power supply master of the system. With this flag, the chip will > > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > > > + system poweroffs. > > One minor thing: While the documentation is updated you may want to > fix the typo "will initiates" to "will initiate" (or just drop the > "will"). Applied with Sebastian's Ack and I fixed this up too. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control
On 18:55-20140917, Sebastian Reichel wrote:
> On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote:
> > On Wed, 17 Sep 2014, Nishanth Menon wrote:
> > > ti,system-power-controller is more or less the standard way of
> > > indicating that the PMIC is the system wide power controller and hence
> > > may be used to switch off the system. Almost ALL TI PMIC drivers and
> > > many Maxim PMIC drivers follow the same style.
> > >
> > > So support 'ti,system-power-controller' in addition to the usual
> > > 'ti,use_poweroff' to indicate that the PMIC instance has control for
> > > switching off the system.
> > >
> > > Signed-off-by: Nishanth Menon
> > > ---
> > >
> > > V2: picked up documentation suggestion from Sebastien
> >
> > It would be good to get Sebastian's Ack.
>
> Acked-By: Sebastian Reichel
Thanks.
>
> [...]
>
> > > +- ti,system-power-controller: This indicates that TWL4030 is the
> > > + power supply master of the system. With this flag, the chip will
> > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
> > > + system poweroffs.
>
> One minor thing: While the documentation is updated you may want to
> fix the typo "will initiates" to "will initiate" (or just drop the
> "will").
Updated v3 patch with your ack and correction to drop "will" below. I
will assume I wont need to repost the following update. Do let me know
if you'd like me to.
---8<---
>From ae3bcfc74080b14f9fd0178f6526bf8f34a8c865 Mon Sep 17 00:00:00 2001
From: Nishanth Menon
Date: Wed, 3 Sep 2014 13:55:02 -0500
Subject: [PATCH V3 1/2 ] Documentation: devicetree: mfd: twl4030-power: Use the
standard 'ti,system-power-controller' to mark power control
ti,system-power-controller is more or less the standard way of
indicating that the PMIC is the system wide power controller and hence
may be used to switch off the system. Almost ALL TI PMIC drivers and
many Maxim PMIC drivers follow the same style.
So support 'ti,system-power-controller' in addition to the usual
'ti,use_poweroff' to indicate that the PMIC instance has control for
switching off the system.
Signed-off-by: Nishanth Menon
Acked-By: Sebastian Reichel
---
.../devicetree/bindings/mfd/twl4030-power.txt |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt
b/Documentation/devicetree/bindings/mfd/twl4030-power.txt
index b9ee7b9..15a63e6 100644
--- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt
+++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt
@@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all
boards
depending on how the external oscillator is wired.
Optional properties:
-- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or
- SLEEP-to-OFF transition when the system poweroffs.
+
+- ti,system-power-controller: This indicates that TWL4030 is the
+ power supply master of the system. With this flag, the chip
+ initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
+ system poweroffs.
+
+- ti,use_poweroff: Deprecated name for ti,system-power-controller
Example:
&i2c1 {
--
1.7.9.5
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control
On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote: > On Wed, 17 Sep 2014, Nishanth Menon wrote: > > ti,system-power-controller is more or less the standard way of > > indicating that the PMIC is the system wide power controller and hence > > may be used to switch off the system. Almost ALL TI PMIC drivers and > > many Maxim PMIC drivers follow the same style. > > > > So support 'ti,system-power-controller' in addition to the usual > > 'ti,use_poweroff' to indicate that the PMIC instance has control for > > switching off the system. > > > > Signed-off-by: Nishanth Menon > > --- > > > > V2: picked up documentation suggestion from Sebastien > > It would be good to get Sebastian's Ack. Acked-By: Sebastian Reichel [...] > > +- ti,system-power-controller: This indicates that TWL4030 is the > > + power supply master of the system. With this flag, the chip will > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > > + system poweroffs. One minor thing: While the documentation is updated you may want to fix the typo "will initiates" to "will initiate" (or just drop the "will"). -- Sebastian signature.asc Description: Digital signature
Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control
On Wed, 17 Sep 2014, Nishanth Menon wrote:
> ti,system-power-controller is more or less the standard way of
> indicating that the PMIC is the system wide power controller and hence
> may be used to switch off the system. Almost ALL TI PMIC drivers and
> many Maxim PMIC drivers follow the same style.
>
> So support 'ti,system-power-controller' in addition to the usual
> 'ti,use_poweroff' to indicate that the PMIC instance has control for
> switching off the system.
>
> Signed-off-by: Nishanth Menon
> ---
>
> V2: picked up documentation suggestion from Sebastien
It would be good to get Sebastian's Ack.
> V1: https://patchwork.kernel.org/patch/4836381/
>
> .../devicetree/bindings/mfd/twl4030-power.txt |9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt
> b/Documentation/devicetree/bindings/mfd/twl4030-power.txt
> index b9ee7b9..a7390c7 100644
> --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt
> +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt
> @@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all
> boards
> depending on how the external oscillator is wired.
>
> Optional properties:
> -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF
> or
> -SLEEP-to-OFF transition when the system poweroffs.
> +
> +- ti,system-power-controller: This indicates that TWL4030 is the
> + power supply master of the system. With this flag, the chip will
> + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
> + system poweroffs.
> +
> +- ti,use_poweroff: Deprecated name for ti,system-power-controller
>
> Example:
> &i2c1 {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control
ti,system-power-controller is more or less the standard way of
indicating that the PMIC is the system wide power controller and hence
may be used to switch off the system. Almost ALL TI PMIC drivers and
many Maxim PMIC drivers follow the same style.
So support 'ti,system-power-controller' in addition to the usual
'ti,use_poweroff' to indicate that the PMIC instance has control for
switching off the system.
Signed-off-by: Nishanth Menon
---
V2: picked up documentation suggestion from Sebastien
V1: https://patchwork.kernel.org/patch/4836381/
.../devicetree/bindings/mfd/twl4030-power.txt |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt
b/Documentation/devicetree/bindings/mfd/twl4030-power.txt
index b9ee7b9..a7390c7 100644
--- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt
+++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt
@@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all
boards
depending on how the external oscillator is wired.
Optional properties:
-- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or
- SLEEP-to-OFF transition when the system poweroffs.
+
+- ti,system-power-controller: This indicates that TWL4030 is the
+ power supply master of the system. With this flag, the chip will
+ initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
+ system poweroffs.
+
+- ti,use_poweroff: Deprecated name for ti,system-power-controller
Example:
&i2c1 {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
