Re: [PATCH V3 11/19] OMAP3+: SR: fix cosmetic indentation
Nishanth Menon n...@ti.com writes: Error label case seems to have a 2 tab indentation when just 1 is necessary. Signed-off-by: Nishanth Menon n...@ti.com Thanks, queuing for 2.6.40. Kevin --- arch/arm/mach-omap2/smartreflex.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index 2b6fdc7..1e52d61 100644 --- a/arch/arm/mach-omap2/smartreflex.c +++ b/arch/arm/mach-omap2/smartreflex.c @@ -276,16 +276,16 @@ static int sr_late_init(struct omap_sr *sr_info) return ret; error: - iounmap(sr_info-base); - mem = platform_get_resource(sr_info-pdev, IORESOURCE_MEM, 0); - release_mem_region(mem-start, resource_size(mem)); - list_del(sr_info-node); - dev_err(sr_info-pdev-dev, %s: ERROR in registering - interrupt handler. Smartreflex will - not function as desired\n, __func__); - kfree(name); - kfree(sr_info); - return ret; + iounmap(sr_info-base); + mem = platform_get_resource(sr_info-pdev, IORESOURCE_MEM, 0); + release_mem_region(mem-start, resource_size(mem)); + list_del(sr_info-node); + dev_err(sr_info-pdev-dev, %s: ERROR in registering + interrupt handler. Smartreflex will + not function as desired\n, __func__); + kfree(name); + kfree(sr_info); + return ret; } static void sr_v1_disable(struct omap_sr *sr) -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V3 11/19] OMAP3+: SR: fix cosmetic indentation
Aaro Koskinen aaro.koski...@nokia.com writes: Hi, On Thu, 17 Mar 2011, Kevin Hilman wrote: Thanks, queuing for 2.6.40. [...] - iounmap(sr_info-base); - mem = platform_get_resource(sr_info-pdev, IORESOURCE_MEM, 0); - release_mem_region(mem-start, resource_size(mem)); - list_del(sr_info-node); - dev_err(sr_info-pdev-dev, %s: ERROR in registering - interrupt handler. Smartreflex will - not function as desired\n, __func__); - kfree(name); - kfree(sr_info); - return ret; + iounmap(sr_info-base); + mem = platform_get_resource(sr_info-pdev, IORESOURCE_MEM, 0); + release_mem_region(mem-start, resource_size(mem)); + list_del(sr_info-node); + dev_err(sr_info-pdev-dev, %s: ERROR in registering + interrupt handler. Smartreflex will + not function as desired\n, __func__); + kfree(name); + kfree(sr_info); + return ret; Just FYI, this code is partly broken and probably need to be fixed in .39. OK Some of those resources are also freed by omap_sr_probe() when sr_late_init() fails and that cannot be correct. Got a patch around to fix that? Sounds like something we should get into the .39-rc cycle. Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH V3 11/19] OMAP3+: SR: fix cosmetic indentation
Error label case seems to have a 2 tab indentation when just 1 is necessary. Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index 2b6fdc7..1e52d61 100644 --- a/arch/arm/mach-omap2/smartreflex.c +++ b/arch/arm/mach-omap2/smartreflex.c @@ -276,16 +276,16 @@ static int sr_late_init(struct omap_sr *sr_info) return ret; error: - iounmap(sr_info-base); - mem = platform_get_resource(sr_info-pdev, IORESOURCE_MEM, 0); - release_mem_region(mem-start, resource_size(mem)); - list_del(sr_info-node); - dev_err(sr_info-pdev-dev, %s: ERROR in registering - interrupt handler. Smartreflex will - not function as desired\n, __func__); - kfree(name); - kfree(sr_info); - return ret; + iounmap(sr_info-base); + mem = platform_get_resource(sr_info-pdev, IORESOURCE_MEM, 0); + release_mem_region(mem-start, resource_size(mem)); + list_del(sr_info-node); + dev_err(sr_info-pdev-dev, %s: ERROR in registering + interrupt handler. Smartreflex will + not function as desired\n, __func__); + kfree(name); + kfree(sr_info); + return ret; } static void sr_v1_disable(struct omap_sr *sr) -- 1.7.1 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
