RE: [PATCH resend] omap: 3630: disable TLL SAR on 3630 ES1

[Paul Walmsley]

On Wed, 14 Jul 2010, Gadiyar, Anand wrote:

> Paul Walmsley wrote:
> 
> > Tony, once Anand does that, it's
> > 
> > Acked-by: Paul Walmsley 
> > 
> > if you want it for .36; otherwise, for .37, I'd be happy to queue it.
> 
> I assume you mean .35 and .36 here - isn't .37 another 3+ months away?

I mean .35 and .36 -- we're operating under the idea that Linus only wants 
regressions for the -rc series; and due to summer vacations, Kevin and I 
have already sent our patch queues for .36 to Tony.  So it's likely to be 
in .37, but it might get in for .36 depending on how schedules pan out.  
This patch seems quite straightforward to me.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH resend] omap: 3630: disable TLL SAR on 3630 ES1

[Gadiyar, Anand]

Paul Walmsley wrote:
> 
> On Sat, 10 Jul 2010, Anand Gadiyar wrote:
> 
> > USBTLL Save-and-Restore is broken in 3630 ES1.0. Having it
> > enabled could result in incorrect register restores as
> > the OMAP exits off-mode. This could potentially result in
> > unexpected wakeup events.
> > 
> > This is fixed in ES1.1. So disable it for ES1.0s.
> > 
> > Signed-off-by: Anand Gadiyar 
> > Cc: Paul Walmsley 
> > ---
> > This is a fix for buggy hardware, and it would be nice
> > to see this in the next merge window too.
> > 
> > Depends on the patch I just posted which adds the CHIP_GE_OMAP3630ES1_1 
> > macro
> > 
> 
> Verified against the OMAP3630 errata PDF from June 16.  Anand, could you 
> please add an erratum ID to the commit message or to a comment in the 
> code?
> 

Will do. I just noticed the errata doc has finally been updated with a
proper ID that I can use here.

I'll resend in a short while.


> Tony, once Anand does that, it's
> 
> Acked-by: Paul Walmsley 
> 
> if you want it for .36; otherwise, for .37, I'd be happy to queue it.

I assume you mean .35 and .36 here - isn't .37 another 3+ months away?

- Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH resend] omap: 3630: disable TLL SAR on 3630 ES1

[Paul Walmsley]

On Sat, 10 Jul 2010, Anand Gadiyar wrote:

> USBTLL Save-and-Restore is broken in 3630 ES1.0. Having it
> enabled could result in incorrect register restores as
> the OMAP exits off-mode. This could potentially result in
> unexpected wakeup events.
> 
> This is fixed in ES1.1. So disable it for ES1.0s.
> 
> Signed-off-by: Anand Gadiyar 
> Cc: Paul Walmsley 
> ---
> This is a fix for buggy hardware, and it would be nice
> to see this in the next merge window too.
> 
> Depends on the patch I just posted which adds the
> CHIP_GE_OMAP3630ES1_1 macro
> 

Verified against the OMAP3630 errata PDF from June 16.  Anand, could you 
please add an erratum ID to the commit message or to a comment in the 
code?

Tony, once Anand does that, it's

Acked-by: Paul Walmsley 

if you want it for .36; otherwise, for .37, I'd be happy to queue it.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH resend] omap: 3630: disable TLL SAR on 3630 ES1

[Anand Gadiyar]

USBTLL Save-and-Restore is broken in 3630 ES1.0. Having it
enabled could result in incorrect register restores as
the OMAP exits off-mode. This could potentially result in
unexpected wakeup events.

This is fixed in ES1.1. So disable it for ES1.0s.

Signed-off-by: Anand Gadiyar 
Cc: Paul Walmsley 
---
This is a fix for buggy hardware, and it would be nice
to see this in the next merge window too.

Depends on the patch I just posted which adds the
CHIP_GE_OMAP3630ES1_1 macro


 arch/arm/mach-omap2/powerdomains34xx.h |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

Index: linux-omap-2.6/arch/arm/mach-omap2/powerdomains34xx.h
===
--- linux-omap-2.6.orig/arch/arm/mach-omap2/powerdomains34xx.h
+++ linux-omap-2.6/arch/arm/mach-omap2/powerdomains34xx.h
@@ -80,7 +80,8 @@ static struct powerdomain core_3xxx_pre_
.prcm_offs= CORE_MOD,
.omap_chip= OMAP_CHIP_INIT(CHIP_IS_OMAP3430ES1 |
   CHIP_IS_OMAP3430ES2 |
-  CHIP_IS_OMAP3430ES3_0),
+  CHIP_IS_OMAP3430ES3_0 |
+  CHIP_IS_OMAP3630ES1),
.pwrsts   = PWRSTS_OFF_RET_ON,
.pwrsts_logic_ret = PWRSTS_OFF_RET,
.banks= 2,
@@ -97,7 +98,8 @@ static struct powerdomain core_3xxx_pre_
 static struct powerdomain core_3xxx_es3_1_pwrdm = {
.name = "core_pwrdm",
.prcm_offs= CORE_MOD,
-   .omap_chip= OMAP_CHIP_INIT(CHIP_GE_OMAP3430ES3_1),
+   .omap_chip= OMAP_CHIP_INIT(CHIP_IS_OMAP3430ES3_1 |
+ CHIP_GE_OMAP3630ES1_1),
.pwrsts   = PWRSTS_OFF_RET_ON,
.pwrsts_logic_ret = PWRSTS_OFF_RET,
.flags= PWRDM_HAS_HDWR_SAR, /* for USBTLL only */
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html