Re: [PATCH v2] drivers/gpio: using common order: let 'static const' instead of 'const static'

[Grant Likely]

On Wed, 6 Feb 2013 16:17:24 +0530, Santosh Shilimkar  
wrote:
> On Wednesday 06 February 2013 04:14 PM, Chen Gang wrote:
> >
> >'const static ' is not a common order, better to use 'static const' 
> > instead.
> >
> > building:
> >make EXTRA_CFLAGS=-W ARCH=arm
> >
> >drivers/gpio/gpio-omap.c:1479:
> >  warning: 'static' is not at beginning of declaration
> >drivers/gpio/gpio-omap.c:1485:
> >  warning: 'static' is not at beginning of declaration
> >drivers/gpio/gpio-omap.c:1491:
> >  warning: 'static' is not at beginning of declaration
> >
> >
> > Signed-off-by: Chen Gang 
> > Cc: Santosh Shilimkar 
> > ---
> Thanks for update.
> Acked-by: Santosh Shilimkar 

Applied, thanks.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] drivers/gpio: using common order: let 'static const' instead of 'const static'

[Santosh Shilimkar]

On Wednesday 06 February 2013 04:14 PM, Chen Gang wrote:


   'const static ' is not a common order, better to use 'static const' instead.

building:
   make EXTRA_CFLAGS=-W ARCH=arm

   drivers/gpio/gpio-omap.c:1479:
 warning: 'static' is not at beginning of declaration
   drivers/gpio/gpio-omap.c:1485:
 warning: 'static' is not at beginning of declaration
   drivers/gpio/gpio-omap.c:1491:
 warning: 'static' is not at beginning of declaration


Signed-off-by: Chen Gang 
Cc: Santosh Shilimkar 
---

Thanks for update.
Acked-by: Santosh Shilimkar 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] drivers/gpio: using common order: let 'static const' instead of 'const static'

[Chen Gang]

  'const static ' is not a common order, better to use 'static const' instead.

building:
  make EXTRA_CFLAGS=-W ARCH=arm

  drivers/gpio/gpio-omap.c:1479:
warning: 'static' is not at beginning of declaration
  drivers/gpio/gpio-omap.c:1485:
warning: 'static' is not at beginning of declaration
  drivers/gpio/gpio-omap.c:1491:
warning: 'static' is not at beginning of declaration


Signed-off-by: Chen Gang 
Cc: Santosh Shilimkar 
---
 drivers/gpio/gpio-omap.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index f1fbedb2..159f5c5 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1476,19 +1476,19 @@ static struct omap_gpio_reg_offs omap4_gpio_regs = {
.fallingdetect =OMAP4_GPIO_FALLINGDETECT,
 };
 
-const static struct omap_gpio_platform_data omap2_pdata = {
+static const struct omap_gpio_platform_data omap2_pdata = {
.regs = &omap2_gpio_regs,
.bank_width = 32,
.dbck_flag = false,
 };
 
-const static struct omap_gpio_platform_data omap3_pdata = {
+static const struct omap_gpio_platform_data omap3_pdata = {
.regs = &omap2_gpio_regs,
.bank_width = 32,
.dbck_flag = true,
 };
 
-const static struct omap_gpio_platform_data omap4_pdata = {
+static const struct omap_gpio_platform_data omap4_pdata = {
.regs = &omap4_gpio_regs,
.bank_width = 32,
.dbck_flag = true,
-- 
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html