Re: [PATCH v2 1/5] ARM: OMAP2+: hwmod: cleanup HWMOD_INIT_NO_RESET usage

[Paul Walmsley]

On Wed, 9 Oct 2013, Rajendra Nayak wrote:

> For modules/IPs/hwmods which do not have
> -1- sys->class->reset()
> and
> -2- hardreset lines
> and
> -3- No way to do an ocp reset (no sysc control)
> the flag 'HWMOD_INIT_NO_RESET' is not much useful.
> 
> Cleanup all such instances across various hwmod data files.
> 
> Signed-off-by: Rajendra Nayak 

Thanks, queued.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/5] ARM: OMAP2+: hwmod: cleanup HWMOD_INIT_NO_RESET usage

[Rajendra Nayak]

For modules/IPs/hwmods which do not have
-1- sys->class->reset()
and
-2- hardreset lines
and
-3- No way to do an ocp reset (no sysc control)
the flag 'HWMOD_INIT_NO_RESET' is not much useful.

Cleanup all such instances across various hwmod data files.

Signed-off-by: Rajendra Nayak 
---
 arch/arm/mach-omap2/omap_hwmod_33xx_data.c |   18 +-
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |6 +++---
 arch/arm/mach-omap2/omap_hwmod_54xx_data.c |6 +++---
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c 
b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
index 215894f..2815a91 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
@@ -52,7 +52,7 @@ static struct omap_hwmod am33xx_emif_hwmod = {
.name   = "emif",
.class  = &am33xx_emif_hwmod_class,
.clkdm_name = "l3_clkdm",
-   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),
+   .flags  = HWMOD_INIT_NO_IDLE,
.main_clk   = "dpll_ddr_m2_div2_ck",
.prcm   = {
.omap4  = {
@@ -74,7 +74,7 @@ static struct omap_hwmod am33xx_l3_main_hwmod = {
.name   = "l3_main",
.class  = &am33xx_l3_hwmod_class,
.clkdm_name = "l3_clkdm",
-   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),
+   .flags  = HWMOD_INIT_NO_IDLE,
.main_clk   = "l3_gclk",
.prcm   = {
.omap4  = {
@@ -96,7 +96,7 @@ static struct omap_hwmod am33xx_l3_instr_hwmod = {
.name   = "l3_instr",
.class  = &am33xx_l3_hwmod_class,
.clkdm_name = "l3_clkdm",
-   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),
+   .flags  = HWMOD_INIT_NO_IDLE,
.main_clk   = "l3_gclk",
.prcm   = {
.omap4  = {
@@ -119,7 +119,7 @@ static struct omap_hwmod am33xx_l4_ls_hwmod = {
.name   = "l4_ls",
.class  = &am33xx_l4_hwmod_class,
.clkdm_name = "l4ls_clkdm",
-   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),
+   .flags  = HWMOD_INIT_NO_IDLE,
.main_clk   = "l4ls_gclk",
.prcm   = {
.omap4  = {
@@ -134,7 +134,7 @@ static struct omap_hwmod am33xx_l4_hs_hwmod = {
.name   = "l4_hs",
.class  = &am33xx_l4_hwmod_class,
.clkdm_name = "l4hs_clkdm",
-   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),
+   .flags  = HWMOD_INIT_NO_IDLE,
.main_clk   = "l4hs_gclk",
.prcm   = {
.omap4  = {
@@ -150,7 +150,7 @@ static struct omap_hwmod am33xx_l4_wkup_hwmod = {
.name   = "l4_wkup",
.class  = &am33xx_l4_hwmod_class,
.clkdm_name = "l4_wkup_clkdm",
-   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),
+   .flags  = HWMOD_INIT_NO_IDLE,
.prcm   = {
.omap4  = {
.clkctrl_offs   = AM33XX_CM_WKUP_L4WKUP_CLKCTRL_OFFSET,
@@ -170,7 +170,7 @@ static struct omap_hwmod am33xx_mpu_hwmod = {
.name   = "mpu",
.class  = &am33xx_mpu_hwmod_class,
.clkdm_name = "mpu_clkdm",
-   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),
+   .flags  = HWMOD_INIT_NO_IDLE,
.main_clk   = "dpll_mpu_m2_ck",
.prcm   = {
.omap4  = {
@@ -450,7 +450,7 @@ static struct omap_hwmod am33xx_ocmcram_hwmod = {
.name   = "ocmcram",
.class  = &am33xx_ocmcram_hwmod_class,
.clkdm_name = "l3_clkdm",
-   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),
+   .flags  = HWMOD_INIT_NO_IDLE,
.main_clk   = "l3_gclk",
.prcm   = {
.omap4  = {
@@ -532,7 +532,7 @@ static struct omap_hwmod am33xx_control_hwmod = {
.name   = "control",
.class  = &am33xx_control_hwmod_class,
.clkdm_name = "l4_wkup_clkdm",
-   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),
+   .flags  = HWMOD_INIT_NO_IDLE,
.main_clk   = "dpll_core_m4_div2_ck",
.prcm   = {
.omap4  = {
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c 
b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 9c3b504..1e5b12c 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -914,7 +914,7 @@ static struct omap_hwmod omap44xx_emif1_hwmod = {
.name   = "emif1",
.class  = &omap44xx_emif_hwmod_class,
.clkdm_name = "l3_emif_clkdm",
-   .flags  = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
+   .flags