Re: [PATCH v2 3/9] OMAP2420: hwmod data: add system DMA

2010-12-18 Thread Paul Walmsley 
On Fri, 17 Dec 2010, G, Manjunath Kondaiah wrote:

 Add OMAP2420 DMA hwmod data and also add required
 DMA device attributes.
 
 Signed-off-by: G, Manjunath Kondaiah manj...@ti.com
 ---
  arch/arm/mach-omap2/omap_hwmod_2420_data.c |   87 
 
  arch/arm/plat-omap/include/plat/dma.h  |   11 
  2 files changed, 98 insertions(+), 0 deletions(-)
 
 diff --git a/arch/arm/mach-omap2/omap_hwmod_2420_data.c 
 b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 index d953425..eb02fec 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 @@ -42,6 +42,7 @@ static struct omap_hwmod omap2420_gpio1_hwmod;
  static struct omap_hwmod omap2420_gpio2_hwmod;
  static struct omap_hwmod omap2420_gpio3_hwmod;
  static struct omap_hwmod omap2420_gpio4_hwmod;
 +static struct omap_hwmod omap2420_dma_system_hwmod;
  
  /* L3 - L4_CORE interface */
  static struct omap_hwmod_ocp_if omap2420_l3_main__l4_core = {
 @@ -779,6 +780,89 @@ static struct omap_hwmod omap2420_gpio4_hwmod = {
   .omap_chip  = OMAP_CHIP_INIT(CHIP_IS_OMAP2420),
  };
  
 +/* system dma */
 +static struct omap_hwmod_class_sysconfig omap2420_dma_sysc = {
 + .rev_offs   = 0x,
 + .sysc_offs  = 0x002c,
 + .syss_offs  = 0x0028,
 + .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET |

According to the OMAP242x TRM 2.3 Rev. X [SWPU064X] Table 10-34, the SDMA 
has no SIDLEMODE register bitfield.  So this SYSC_HAS_SIDLEMODE appears to 
be incorrect.  Manju, please confirm.

 +SYSC_HAS_MIDLEMODE | SYSC_HAS_CLOCKACTIVITY |
 +SYSC_HAS_EMUFREE | SYSC_HAS_AUTOIDLE),
 + .idlemodes  = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |

And if there is no SIDLEMODE register bitfield, then none of these SIDLE_* 
modes should apply, so they should all be removed also.

 +MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART),
 + .sysc_fields= omap_hwmod_sysc_type1,
 +};
 +
 +static struct omap_hwmod_class omap2420_dma_hwmod_class = {
 + .name = dma,
 + .sysc = omap2420_dma_sysc,
 +};
 +
 +/* dma attributes */
 +static struct omap_dma_dev_attr dma_dev_attr = {
 + .dev_caps  = RESERVE_CHANNEL | DMA_LINKED_LCH | GLOBAL_PRIORITY |
 + IS_CSSA_32 | IS_CDSA_32,
 + .lch_count = 32,
 +};
 +
 +static struct omap_hwmod_irq_info omap2420_dma_system_irqs[] = {
 + { .name = 0, .irq = 12 }, /* INT_24XX_SDMA_IRQ0 */
 + { .name = 1, .irq = 13 }, /* INT_24XX_SDMA_IRQ1 */
 + { .name = 2, .irq = 14 }, /* INT_24XX_SDMA_IRQ2 */
 + { .name = 3, .irq = 15 }, /* INT_24XX_SDMA_IRQ3 */
 +};
 +
 +static struct omap_hwmod_addr_space omap2420_dma_system_addrs[] = {
 + {
 + .pa_start   = 0x48056000,
 + .pa_end = 0x4a0560ff,
 + .flags  = ADDR_TYPE_RT
 + },
 +};
 +
 +/* dma_system - L3 */
 +static struct omap_hwmod_ocp_if omap2420_dma_system__l3 = {
 + .master = omap2420_dma_system_hwmod,
 + .slave  = omap2420_l3_main_hwmod,
 + .clk= core_l3_ck,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +/* dma_system master ports */
 +static struct omap_hwmod_ocp_if *omap2420_dma_system_masters[] = {
 + omap2420_dma_system__l3,
 +};
 +
 +/* l4_cfg - dma_system */

l4_cfg should be l4_core.

 +static struct omap_hwmod_ocp_if omap2420_l4_core__dma_system = {
 + .master = omap2420_l4_core_hwmod,
 + .slave  = omap2420_dma_system_hwmod,
 + .clk= sdma_ick,
 + .addr   = omap2420_dma_system_addrs,
 + .addr_cnt   = ARRAY_SIZE(omap2420_dma_system_addrs),
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +/* dma_system slave ports */
 +static struct omap_hwmod_ocp_if *omap2420_dma_system_slaves[] = {
 + omap2420_l4_core__dma_system,
 +};
 +
 +static struct omap_hwmod omap2420_dma_system_hwmod = {
 + .name   = dma,
 + .class  = omap2420_dma_hwmod_class,
 + .mpu_irqs   = omap2420_dma_system_irqs,
 + .mpu_irqs_cnt   = ARRAY_SIZE(omap2420_dma_system_irqs),
 + .main_clk   = core_l3_ck,
 + .slaves = omap2420_dma_system_slaves,
 + .slaves_cnt = ARRAY_SIZE(omap2420_dma_system_slaves),
 + .masters= omap2420_dma_system_masters,
 + .masters_cnt= ARRAY_SIZE(omap2420_dma_system_masters),
 + .dev_attr   = dma_dev_attr,
 + .omap_chip  = OMAP_CHIP_INIT(CHIP_IS_OMAP2420),
 + .flags  = HWMOD_NO_IDLEST,
 +};
 +
  static __initdata struct omap_hwmod *omap2420_hwmods[] = {
   omap2420_l3_main_hwmod,
   omap2420_l4_core_hwmod,
 @@ -797,6 +881,9 @@ static __initdata struct omap_hwmod *omap2420_hwmods[] = {
   omap2420_gpio2_hwmod,
   omap2420_gpio3_hwmod,
   omap2420_gpio4_hwmod,
 +
 + /* dma_system class*/
 + omap2420_dma_system_hwmod,
   NULL,

Re: [PATCH v2 3/9] OMAP2420: hwmod data: add system DMA

2010-12-18 Thread Paul Walmsley 
Hello Manju

On Sat, 18 Dec 2010, G, Manjunath Kondaiah wrote:

 The clock entries are modified as per your review comments and tested
 the chagnes on N800 and 2430SDP(for patch 4/9).
 
 Can you pls ack these patches so that tony can merge this series?

I've reviewed the patches and posted some comments, but cannot ack them 
yet until the SIDLEMODE parts are resolved.


- Paul
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/9] OMAP2420: hwmod data: add system DMA

2010-12-18 Thread G, Manjunath Kondaiah 
On Sat, Dec 18, 2010 at 02:03:27AM -0700, Paul Walmsley wrote:
 On Fri, 17 Dec 2010, G, Manjunath Kondaiah wrote:
 
  Add OMAP2420 DMA hwmod data and also add required
  DMA device attributes.
  
  Signed-off-by: G, Manjunath Kondaiah manj...@ti.com
  ---
   arch/arm/mach-omap2/omap_hwmod_2420_data.c |   87 
  
   arch/arm/plat-omap/include/plat/dma.h  |   11 
   2 files changed, 98 insertions(+), 0 deletions(-)
  
  diff --git a/arch/arm/mach-omap2/omap_hwmod_2420_data.c 
  b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
  index d953425..eb02fec 100644
  --- a/arch/arm/mach-omap2/omap_hwmod_2420_data.c
  +++ b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
  @@ -42,6 +42,7 @@ static struct omap_hwmod omap2420_gpio1_hwmod;
   static struct omap_hwmod omap2420_gpio2_hwmod;
   static struct omap_hwmod omap2420_gpio3_hwmod;
   static struct omap_hwmod omap2420_gpio4_hwmod;
  +static struct omap_hwmod omap2420_dma_system_hwmod;
   
   /* L3 - L4_CORE interface */
   static struct omap_hwmod_ocp_if omap2420_l3_main__l4_core = {
  @@ -779,6 +780,89 @@ static struct omap_hwmod omap2420_gpio4_hwmod = {
  .omap_chip  = OMAP_CHIP_INIT(CHIP_IS_OMAP2420),
   };
   
  +/* system dma */
  +static struct omap_hwmod_class_sysconfig omap2420_dma_sysc = {
  +   .rev_offs   = 0x,
  +   .sysc_offs  = 0x002c,
  +   .syss_offs  = 0x0028,
  +   .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET |
 
 According to the OMAP242x TRM 2.3 Rev. X [SWPU064X] Table 10-34, the SDMA 
 has no SIDLEMODE register bitfield.  So this SYSC_HAS_SIDLEMODE appears to 
 be incorrect.  Manju, please confirm.

I verified again in 2420 TRM, this entry should not there.

 
  +  SYSC_HAS_MIDLEMODE | SYSC_HAS_CLOCKACTIVITY |
  +  SYSC_HAS_EMUFREE | SYSC_HAS_AUTOIDLE),
  +   .idlemodes  = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
 
 And if there is no SIDLEMODE register bitfield, then none of these SIDLE_* 
 modes should apply, so they should all be removed also.

correct.

 
  +  MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART),
  +   .sysc_fields= omap_hwmod_sysc_type1,
  +};
  +
  +static struct omap_hwmod_class omap2420_dma_hwmod_class = {
  +   .name = dma,
  +   .sysc = omap2420_dma_sysc,
  +};
  +
  +/* dma attributes */
  +static struct omap_dma_dev_attr dma_dev_attr = {
  +   .dev_caps  = RESERVE_CHANNEL | DMA_LINKED_LCH | GLOBAL_PRIORITY |
  +   IS_CSSA_32 | IS_CDSA_32,
  +   .lch_count = 32,
  +};
  +
  +static struct omap_hwmod_irq_info omap2420_dma_system_irqs[] = {
  +   { .name = 0, .irq = 12 }, /* INT_24XX_SDMA_IRQ0 */
  +   { .name = 1, .irq = 13 }, /* INT_24XX_SDMA_IRQ1 */
  +   { .name = 2, .irq = 14 }, /* INT_24XX_SDMA_IRQ2 */
  +   { .name = 3, .irq = 15 }, /* INT_24XX_SDMA_IRQ3 */
  +};
  +
  +static struct omap_hwmod_addr_space omap2420_dma_system_addrs[] = {
  +   {
  +   .pa_start   = 0x48056000,
  +   .pa_end = 0x4a0560ff,
  +   .flags  = ADDR_TYPE_RT
  +   },
  +};
  +
  +/* dma_system - L3 */
  +static struct omap_hwmod_ocp_if omap2420_dma_system__l3 = {
  +   .master = omap2420_dma_system_hwmod,
  +   .slave  = omap2420_l3_main_hwmod,
  +   .clk= core_l3_ck,
  +   .user   = OCP_USER_MPU | OCP_USER_SDMA,
  +};
  +
  +/* dma_system master ports */
  +static struct omap_hwmod_ocp_if *omap2420_dma_system_masters[] = {
  +   omap2420_dma_system__l3,
  +};
  +
  +/* l4_cfg - dma_system */
 
 l4_cfg should be l4_core.
ok.
 
  +static struct omap_hwmod_ocp_if omap2420_l4_core__dma_system = {
  +   .master = omap2420_l4_core_hwmod,
  +   .slave  = omap2420_dma_system_hwmod,
  +   .clk= sdma_ick,
  +   .addr   = omap2420_dma_system_addrs,
  +   .addr_cnt   = ARRAY_SIZE(omap2420_dma_system_addrs),
  +   .user   = OCP_USER_MPU | OCP_USER_SDMA,
  +};
  +
  +/* dma_system slave ports */
  +static struct omap_hwmod_ocp_if *omap2420_dma_system_slaves[] = {
  +   omap2420_l4_core__dma_system,
  +};
  +
  +static struct omap_hwmod omap2420_dma_system_hwmod = {
  +   .name   = dma,
  +   .class  = omap2420_dma_hwmod_class,
  +   .mpu_irqs   = omap2420_dma_system_irqs,
  +   .mpu_irqs_cnt   = ARRAY_SIZE(omap2420_dma_system_irqs),
  +   .main_clk   = core_l3_ck,
  +   .slaves = omap2420_dma_system_slaves,
  +   .slaves_cnt = ARRAY_SIZE(omap2420_dma_system_slaves),
  +   .masters= omap2420_dma_system_masters,
  +   .masters_cnt= ARRAY_SIZE(omap2420_dma_system_masters),
  +   .dev_attr   = dma_dev_attr,
  +   .omap_chip  = OMAP_CHIP_INIT(CHIP_IS_OMAP2420),
  +   .flags  = HWMOD_NO_IDLEST,
  +};
  +
   static __initdata struct omap_hwmod *omap2420_hwmods[] = {
  omap2420_l3_main_hwmod,
  omap2420_l4_core_hwmod,
  @@ -797,6 +881,9 @@ static __initdata struct omap_hwmod *omap2420_hwmods[] 
  =

[PATCH v2 3/9] OMAP2420: hwmod data: add system DMA

2010-12-17 Thread G, Manjunath Kondaiah 
Add OMAP2420 DMA hwmod data and also add required
DMA device attributes.

Signed-off-by: G, Manjunath Kondaiah manj...@ti.com
---
 arch/arm/mach-omap2/omap_hwmod_2420_data.c |   87 
 arch/arm/plat-omap/include/plat/dma.h  |   11 
 2 files changed, 98 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_2420_data.c 
b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
index d953425..eb02fec 100644
--- a/arch/arm/mach-omap2/omap_hwmod_2420_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
@@ -42,6 +42,7 @@ static struct omap_hwmod omap2420_gpio1_hwmod;
 static struct omap_hwmod omap2420_gpio2_hwmod;
 static struct omap_hwmod omap2420_gpio3_hwmod;
 static struct omap_hwmod omap2420_gpio4_hwmod;
+static struct omap_hwmod omap2420_dma_system_hwmod;
 
 /* L3 - L4_CORE interface */
 static struct omap_hwmod_ocp_if omap2420_l3_main__l4_core = {
@@ -779,6 +780,89 @@ static struct omap_hwmod omap2420_gpio4_hwmod = {
.omap_chip  = OMAP_CHIP_INIT(CHIP_IS_OMAP2420),
 };
 
+/* system dma */
+static struct omap_hwmod_class_sysconfig omap2420_dma_sysc = {
+   .rev_offs   = 0x,
+   .sysc_offs  = 0x002c,
+   .syss_offs  = 0x0028,
+   .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET |
+  SYSC_HAS_MIDLEMODE | SYSC_HAS_CLOCKACTIVITY |
+  SYSC_HAS_EMUFREE | SYSC_HAS_AUTOIDLE),
+   .idlemodes  = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
+  MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART),
+   .sysc_fields= omap_hwmod_sysc_type1,
+};
+
+static struct omap_hwmod_class omap2420_dma_hwmod_class = {
+   .name = dma,
+   .sysc = omap2420_dma_sysc,
+};
+
+/* dma attributes */
+static struct omap_dma_dev_attr dma_dev_attr = {
+   .dev_caps  = RESERVE_CHANNEL | DMA_LINKED_LCH | GLOBAL_PRIORITY |
+   IS_CSSA_32 | IS_CDSA_32,
+   .lch_count = 32,
+};
+
+static struct omap_hwmod_irq_info omap2420_dma_system_irqs[] = {
+   { .name = 0, .irq = 12 }, /* INT_24XX_SDMA_IRQ0 */
+   { .name = 1, .irq = 13 }, /* INT_24XX_SDMA_IRQ1 */
+   { .name = 2, .irq = 14 }, /* INT_24XX_SDMA_IRQ2 */
+   { .name = 3, .irq = 15 }, /* INT_24XX_SDMA_IRQ3 */
+};
+
+static struct omap_hwmod_addr_space omap2420_dma_system_addrs[] = {
+   {
+   .pa_start   = 0x48056000,
+   .pa_end = 0x4a0560ff,
+   .flags  = ADDR_TYPE_RT
+   },
+};
+
+/* dma_system - L3 */
+static struct omap_hwmod_ocp_if omap2420_dma_system__l3 = {
+   .master = omap2420_dma_system_hwmod,
+   .slave  = omap2420_l3_main_hwmod,
+   .clk= core_l3_ck,
+   .user   = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
+/* dma_system master ports */
+static struct omap_hwmod_ocp_if *omap2420_dma_system_masters[] = {
+   omap2420_dma_system__l3,
+};
+
+/* l4_cfg - dma_system */
+static struct omap_hwmod_ocp_if omap2420_l4_core__dma_system = {
+   .master = omap2420_l4_core_hwmod,
+   .slave  = omap2420_dma_system_hwmod,
+   .clk= sdma_ick,
+   .addr   = omap2420_dma_system_addrs,
+   .addr_cnt   = ARRAY_SIZE(omap2420_dma_system_addrs),
+   .user   = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
+/* dma_system slave ports */
+static struct omap_hwmod_ocp_if *omap2420_dma_system_slaves[] = {
+   omap2420_l4_core__dma_system,
+};
+
+static struct omap_hwmod omap2420_dma_system_hwmod = {
+   .name   = dma,
+   .class  = omap2420_dma_hwmod_class,
+   .mpu_irqs   = omap2420_dma_system_irqs,
+   .mpu_irqs_cnt   = ARRAY_SIZE(omap2420_dma_system_irqs),
+   .main_clk   = core_l3_ck,
+   .slaves = omap2420_dma_system_slaves,
+   .slaves_cnt = ARRAY_SIZE(omap2420_dma_system_slaves),
+   .masters= omap2420_dma_system_masters,
+   .masters_cnt= ARRAY_SIZE(omap2420_dma_system_masters),
+   .dev_attr   = dma_dev_attr,
+   .omap_chip  = OMAP_CHIP_INIT(CHIP_IS_OMAP2420),
+   .flags  = HWMOD_NO_IDLEST,
+};
+
 static __initdata struct omap_hwmod *omap2420_hwmods[] = {
omap2420_l3_main_hwmod,
omap2420_l4_core_hwmod,
@@ -797,6 +881,9 @@ static __initdata struct omap_hwmod *omap2420_hwmods[] = {
omap2420_gpio2_hwmod,
omap2420_gpio3_hwmod,
omap2420_gpio4_hwmod,
+
+   /* dma_system class*/
+   omap2420_dma_system_hwmod,
NULL,
 };
 
diff --git a/arch/arm/plat-omap/include/plat/dma.h 
b/arch/arm/plat-omap/include/plat/dma.h
index 2378399..c466566 100644
--- a/arch/arm/plat-omap/include/plat/dma.h
+++ b/arch/arm/plat-omap/include/plat/dma.h
@@ -295,6 +295,13 @@
 #define DMA_ERRATA_3_3 BIT(0x5)
 #define DMA_ROMCODE_BUGBIT(0x6)
 
+/* Attributes for OMAP DMA Contrller */
+#define DMA_LINKED_LCH

Re: [PATCH v2 3/9] OMAP2420: hwmod data: add system DMA

2010-12-17 Thread G, Manjunath Kondaiah 
Hi Paul,

On Fri, Dec 17, 2010 at 09:09:42PM +0530, G, Manjunath Kondaiah wrote:
 Add OMAP2420 DMA hwmod data and also add required
 DMA device attributes.
 
 Signed-off-by: G, Manjunath Kondaiah manj...@ti.com
 ---
  arch/arm/mach-omap2/omap_hwmod_2420_data.c |   87 
 
  arch/arm/plat-omap/include/plat/dma.h  |   11 
  2 files changed, 98 insertions(+), 0 deletions(-)
 
 diff --git a/arch/arm/mach-omap2/omap_hwmod_2420_data.c 
 b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 index d953425..eb02fec 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 @@ -42,6 +42,7 @@ static struct omap_hwmod omap2420_gpio1_hwmod;
  static struct omap_hwmod omap2420_gpio2_hwmod;
  static struct omap_hwmod omap2420_gpio3_hwmod;
  static struct omap_hwmod omap2420_gpio4_hwmod;
 +static struct omap_hwmod omap2420_dma_system_hwmod;
  
  /* L3 - L4_CORE interface */
  static struct omap_hwmod_ocp_if omap2420_l3_main__l4_core = {
 @@ -779,6 +780,89 @@ static struct omap_hwmod omap2420_gpio4_hwmod = {
   .omap_chip  = OMAP_CHIP_INIT(CHIP_IS_OMAP2420),
  };
  
 +/* system dma */
 +static struct omap_hwmod_class_sysconfig omap2420_dma_sysc = {
 + .rev_offs   = 0x,
 + .sysc_offs  = 0x002c,
 + .syss_offs  = 0x0028,
 + .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET |
 +SYSC_HAS_MIDLEMODE | SYSC_HAS_CLOCKACTIVITY |
 +SYSC_HAS_EMUFREE | SYSC_HAS_AUTOIDLE),
 + .idlemodes  = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
 +MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART),
 + .sysc_fields= omap_hwmod_sysc_type1,
 +};
 +
 +static struct omap_hwmod_class omap2420_dma_hwmod_class = {
 + .name = dma,
 + .sysc = omap2420_dma_sysc,
 +};
 +
 +/* dma attributes */
 +static struct omap_dma_dev_attr dma_dev_attr = {
 + .dev_caps  = RESERVE_CHANNEL | DMA_LINKED_LCH | GLOBAL_PRIORITY |
 + IS_CSSA_32 | IS_CDSA_32,
 + .lch_count = 32,
 +};
 +
 +static struct omap_hwmod_irq_info omap2420_dma_system_irqs[] = {
 + { .name = 0, .irq = 12 }, /* INT_24XX_SDMA_IRQ0 */
 + { .name = 1, .irq = 13 }, /* INT_24XX_SDMA_IRQ1 */
 + { .name = 2, .irq = 14 }, /* INT_24XX_SDMA_IRQ2 */
 + { .name = 3, .irq = 15 }, /* INT_24XX_SDMA_IRQ3 */
 +};
 +
 +static struct omap_hwmod_addr_space omap2420_dma_system_addrs[] = {
 + {
 + .pa_start   = 0x48056000,
 + .pa_end = 0x4a0560ff,
 + .flags  = ADDR_TYPE_RT
 + },
 +};
 +
 +/* dma_system - L3 */
 +static struct omap_hwmod_ocp_if omap2420_dma_system__l3 = {
 + .master = omap2420_dma_system_hwmod,
 + .slave  = omap2420_l3_main_hwmod,
 + .clk= core_l3_ck,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +/* dma_system master ports */
 +static struct omap_hwmod_ocp_if *omap2420_dma_system_masters[] = {
 + omap2420_dma_system__l3,
 +};
 +
 +/* l4_cfg - dma_system */
 +static struct omap_hwmod_ocp_if omap2420_l4_core__dma_system = {
 + .master = omap2420_l4_core_hwmod,
 + .slave  = omap2420_dma_system_hwmod,
 + .clk= sdma_ick,
 + .addr   = omap2420_dma_system_addrs,
 + .addr_cnt   = ARRAY_SIZE(omap2420_dma_system_addrs),
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +/* dma_system slave ports */
 +static struct omap_hwmod_ocp_if *omap2420_dma_system_slaves[] = {
 + omap2420_l4_core__dma_system,
 +};
 +
 +static struct omap_hwmod omap2420_dma_system_hwmod = {
 + .name   = dma,
 + .class  = omap2420_dma_hwmod_class,
 + .mpu_irqs   = omap2420_dma_system_irqs,
 + .mpu_irqs_cnt   = ARRAY_SIZE(omap2420_dma_system_irqs),
 + .main_clk   = core_l3_ck,

The clock entries are modified as per your review comments and tested
the chagnes on N800 and 2430SDP(for patch 4/9).

Can you pls ack these patches so that tony can merge this series?

-Manjunath
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html