Re: [PATCH v3] OMAP3+: OPP: Replace voltage values with Macros

2011-03-07 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes:

 From: Vishwanath BS vishwanath...@ti.com

 Since all voltage data is now centralized in oppxxx_data.c, we can replace
 the values in the opp table with the macros used for voltage values.

 This will avoid opp table and voltage layer having conflicting values.

 Signed-off-by: Vishwanath BS vishwanath...@ti.com

As you are now on the delivery path too, this should have your sign-off.

Assuming this is a simple oversight, I added your signoff and queued for
2.6.39 (branch: for_2.6.39/pm-misc)

Thanks,

Kevin
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3] OMAP3+: OPP: Replace voltage values with Macros

2011-03-07 Thread Nishanth Menon

Kevin Hilman wrote, on 03/08/2011 03:45 AM:

Nishanth Menonn...@ti.com  writes:


From: Vishwanath BSvishwanath...@ti.com

Since all voltage data is now centralized in oppxxx_data.c, we can replace
the values in the opp table with the macros used for voltage values.

This will avoid opp table and voltage layer having conflicting values.

Signed-off-by: Vishwanath BSvishwanath...@ti.com


As you are now on the delivery path too, this should have your sign-off.

Assuming this is a simple oversight, I added your signoff and queued for
2.6.39 (branch: for_2.6.39/pm-misc)


thanks.

--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v3] OMAP3+: OPP: Replace voltage values with Macros

2011-03-05 Thread Nishanth Menon
From: Vishwanath BS vishwanath...@ti.com

Since all voltage data is now centralized in oppxxx_data.c, we can replace
the values in the opp table with the macros used for voltage values.

This will avoid opp table and voltage layer having conflicting values.

Signed-off-by: Vishwanath BS vishwanath...@ti.com

---
This patch has 3 line over 80 char warning. This is retained for readability
purposes.

Patch based on 2.6.38-rc7 + Tony and Kevin's tree @:

http://git.kernel.org/?p=linux/kernel/git/khilman/linux-omap-pm.git;a=summary
branch: pm-core
for easy incorporation since voltage layer has been cleaned up for .39
there.

v3: no functional content change. $subject fixed (the patch impacts omap3+)
commit message grammar fix.

v2: https://patchwork.kernel.org/patch/607541/
Rebased to pm-core (since pm-core now has voltage layer cleanups)

v1: http://marc.info/?l=linux-omapm=129683786100355w=2

 arch/arm/mach-omap2/opp3xxx_data.c |   46 ++--
 arch/arm/mach-omap2/opp4xxx_data.c |   12 
 2 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/arch/arm/mach-omap2/opp3xxx_data.c 
b/arch/arm/mach-omap2/opp3xxx_data.c
index d2bd1bd..d95f3f9 100644
--- a/arch/arm/mach-omap2/opp3xxx_data.c
+++ b/arch/arm/mach-omap2/opp3xxx_data.c
@@ -89,15 +89,15 @@ struct omap_volt_data omap36xx_vddcore_volt_data[] = {
 
 static struct omap_opp_def __initdata omap34xx_opp_def_list[] = {
/* MPU OPP1 */
-   OPP_INITIALIZER(mpu, true, 12500, 975000),
+   OPP_INITIALIZER(mpu, true, 12500, OMAP3430_VDD_MPU_OPP1_UV),
/* MPU OPP2 */
-   OPP_INITIALIZER(mpu, true, 25000, 1075000),
+   OPP_INITIALIZER(mpu, true, 25000, OMAP3430_VDD_MPU_OPP2_UV),
/* MPU OPP3 */
-   OPP_INITIALIZER(mpu, true, 5, 120),
+   OPP_INITIALIZER(mpu, true, 5, OMAP3430_VDD_MPU_OPP3_UV),
/* MPU OPP4 */
-   OPP_INITIALIZER(mpu, true, 55000, 127),
+   OPP_INITIALIZER(mpu, true, 55000, OMAP3430_VDD_MPU_OPP4_UV),
/* MPU OPP5 */
-   OPP_INITIALIZER(mpu, true, 6, 135),
+   OPP_INITIALIZER(mpu, true, 6, OMAP3430_VDD_MPU_OPP5_UV),
 
/*
 * L3 OPP1 - 41.5 MHz is disabled because: The voltage for that OPP is
@@ -107,47 +107,47 @@ static struct omap_opp_def __initdata 
omap34xx_opp_def_list[] = {
 * impact that frequency will do to the MPU and the whole system in
 * general.
 */
-   OPP_INITIALIZER(l3_main, false, 4150, 975000),
+   OPP_INITIALIZER(l3_main, false, 4150, OMAP3430_VDD_CORE_OPP1_UV),
/* L3 OPP2 */
-   OPP_INITIALIZER(l3_main, true, 8300, 105),
+   OPP_INITIALIZER(l3_main, true, 8300, OMAP3430_VDD_CORE_OPP2_UV),
/* L3 OPP3 */
-   OPP_INITIALIZER(l3_main, true, 16600, 115),
+   OPP_INITIALIZER(l3_main, true, 16600, OMAP3430_VDD_CORE_OPP3_UV),
 
/* DSP OPP1 */
-   OPP_INITIALIZER(iva, true, 9000, 975000),
+   OPP_INITIALIZER(iva, true, 9000, OMAP3430_VDD_MPU_OPP1_UV),
/* DSP OPP2 */
-   OPP_INITIALIZER(iva, true, 18000, 1075000),
+   OPP_INITIALIZER(iva, true, 18000, OMAP3430_VDD_MPU_OPP2_UV),
/* DSP OPP3 */
-   OPP_INITIALIZER(iva, true, 36000, 120),
+   OPP_INITIALIZER(iva, true, 36000, OMAP3430_VDD_MPU_OPP3_UV),
/* DSP OPP4 */
-   OPP_INITIALIZER(iva, true, 4, 127),
+   OPP_INITIALIZER(iva, true, 4, OMAP3430_VDD_MPU_OPP4_UV),
/* DSP OPP5 */
-   OPP_INITIALIZER(iva, true, 43000, 135),
+   OPP_INITIALIZER(iva, true, 43000, OMAP3430_VDD_MPU_OPP5_UV),
 };
 
 static struct omap_opp_def __initdata omap36xx_opp_def_list[] = {
/* MPU OPP1 - OPP50 */
-   OPP_INITIALIZER(mpu, true,  3, 1012500),
+   OPP_INITIALIZER(mpu, true,  3, OMAP3630_VDD_MPU_OPP50_UV),
/* MPU OPP2 - OPP100 */
-   OPP_INITIALIZER(mpu, true,  6, 120),
+   OPP_INITIALIZER(mpu, true,  6, OMAP3630_VDD_MPU_OPP100_UV),
/* MPU OPP3 - OPP-Turbo */
-   OPP_INITIALIZER(mpu, false, 8, 1325000),
+   OPP_INITIALIZER(mpu, false, 8, OMAP3630_VDD_MPU_OPP120_UV),
/* MPU OPP4 - OPP-SB */
-   OPP_INITIALIZER(mpu, false, 10, 1375000),
+   OPP_INITIALIZER(mpu, false, 10, OMAP3630_VDD_MPU_OPP1G_UV),
 
/* L3 OPP1 - OPP50 */
-   OPP_INITIALIZER(l3_main, true, 1, 100),
+   OPP_INITIALIZER(l3_main, true, 1, OMAP3630_VDD_CORE_OPP50_UV),
/* L3 OPP2 - OPP100, OPP-Turbo, OPP-SB */
-   OPP_INITIALIZER(l3_main, true, 2, 120),
+   OPP_INITIALIZER(l3_main, true, 2, 
OMAP3630_VDD_CORE_OPP100_UV),
 
/* DSP OPP1 - OPP50 */
-   OPP_INITIALIZER(iva, true,  26000, 1012500),
+   OPP_INITIALIZER(iva, true,  26000, OMAP3630_VDD_MPU_OPP50_UV),