Re: [PATCH v3 0/2] Device tree support for TWL regulators
On Tue, Feb 28, 2012 at 11:11:48AM +0530, Rajendra Nayak wrote: changes have no dependencies with any other DT series. I will repost all of Tero/Peter and my changes (to add DT support to the driver) as one single series and drop the dts file updates, which I guess can go via Tony/OMAP tree. Yes, that sounds like a good plan - the DTS changes are largely orthogonal to the code changes and don't need to go via the same path (this is true in general, the DTSs are pretty horrible for merge issues). signature.asc Description: Digital signature
[PATCH v3 0/2] Device tree support for TWL regulators
Re-sending on top of Tero's changes which are already
in -next and the one which adds support for twl6030
vdd1/2/3 SMPS [1].
v3 has mainly 2 differences from v2
-1- TWL driver now uses just one table for both dt and
non-dt based lookup for driver data.
-2- All common regulator nodes for twl4030 and twl6030 are
now defined in the twl4030.dtsi and twl6030.dtsi instead of
repeating the nodes in all board files, which also means
the patch ('arm/dts: twl: Pass regulator data from dt')
has a dependency with the series from Benoit which adds the
twl4030.dtsi and twl6030.dtsi files[2].
I have tested the patches on omap4panda and omap3beagle boards.
[1] http://marc.info/?l=linux-omapm=133009693905864w=2
[2] git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git
for_3.4/dt_i2c_twl
Rajendra Nayak (2):
regulator: twl: adapt twl-regulator driver to dt
arm/dts: twl: Pass regulator data from dt
.../bindings/regulator/twl-regulator.txt | 66 +
arch/arm/boot/dts/omap3-beagle.dts |6 +
arch/arm/boot/dts/twl4030.dtsi | 18 ++
arch/arm/boot/dts/twl6030.dtsi | 60 +
drivers/regulator/twl-regulator.c | 259 +---
5 files changed, 322 insertions(+), 87 deletions(-)
create mode 100644
Documentation/devicetree/bindings/regulator/twl-regulator.txt
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/2] Device tree support for TWL regulators
Hi Rajendra,
On 02/27/2012 12:35 PM, Rajendra Nayak wrote:
Re-sending on top of Tero's changes which are already
in -next and the one which adds support for twl6030
vdd1/2/3 SMPS [1].
Would you be able to add support for V1V8, V2V1 SMPS supplies in
twl6030? These regulators are need on SDP4430, and PandaBoards for the
twl6040 audio codec.
I have sent a series to add this support:
http://marc.info/?l=linux-omapm=132886849202915w=2
Thanks,
Péter
v3 has mainly 2 differences from v2
-1- TWL driver now uses just one table for both dt and
non-dt based lookup for driver data.
-2- All common regulator nodes for twl4030 and twl6030 are
now defined in the twl4030.dtsi and twl6030.dtsi instead of
repeating the nodes in all board files, which also means
the patch ('arm/dts: twl: Pass regulator data from dt')
has a dependency with the series from Benoit which adds the
twl4030.dtsi and twl6030.dtsi files[2].
I have tested the patches on omap4panda and omap3beagle boards.
[1] http://marc.info/?l=linux-omapm=133009693905864w=2
[2] git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git
for_3.4/dt_i2c_twl
Rajendra Nayak (2):
regulator: twl: adapt twl-regulator driver to dt
arm/dts: twl: Pass regulator data from dt
.../bindings/regulator/twl-regulator.txt | 66 +
arch/arm/boot/dts/omap3-beagle.dts |6 +
arch/arm/boot/dts/twl4030.dtsi | 18 ++
arch/arm/boot/dts/twl6030.dtsi | 60 +
drivers/regulator/twl-regulator.c | 259
+---
5 files changed, 322 insertions(+), 87 deletions(-)
create mode 100644
Documentation/devicetree/bindings/regulator/twl-regulator.txt
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/2] Device tree support for TWL regulators
Hi Mark, On 2/27/2012 2:41 PM, Mark Brown wrote: On Mon, Feb 27, 2012 at 06:01:20PM +0530, Rajendra Nayak wrote: Depending on what order Mark happens to pull them in, I am fine re-sending adding support for the 2 twl6030 fixed regulators. Please can you guys come up with a single unified series for this stuff - I'll hold off on applying anything to allow you to do this. The issue is that the initial TWL regulator series from Rajendra will depend on the twl core DT support I have that depends on the irq_domain series from Grant... So I guess, it will be easy for us to split the regulator patches from the DTS ones to have at least the driver changes merged by you. Then Tony might be able to pull all the DTS in one series and thus avoid the various merge conflict that will happen since most OMAP drivers are hacking the same DTS files. Does that make sense? Or do you think it will be even worst separating the patches? Thanks, Benoit -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/2] Device tree support for TWL regulators
On Mon, Feb 27, 2012 at 02:52:05PM +0100, Cousson, Benoit wrote: On 2/27/2012 2:41 PM, Mark Brown wrote: On Mon, Feb 27, 2012 at 06:01:20PM +0530, Rajendra Nayak wrote: Please can you guys come up with a single unified series for this stuff - I'll hold off on applying anything to allow you to do this. The issue is that the initial TWL regulator series from Rajendra will depend on the twl core DT support I have that depends on the irq_domain series from Grant... Really? That's the first I've heard of any such dependency here. Is it a build time dependency or is it just something that's required to make the code actually spring into life? It looks like it's the latter but you're saying there's an actual dependency. There's also more than that, there's also at least Tero submitting some other stuff separately (and his stuff won't play with DT...) and I think Peter also. It really fees like there's a bunch of people working on different things without talking to each other here. So I guess, it will be easy for us to split the regulator patches from the DTS ones to have at least the driver changes merged by you. Then Tony might be able to pull all the DTS in one series and thus avoid the various merge conflict that will happen since most OMAP drivers are hacking the same DTS files. Does that make sense? Or do you think it will be even worst separating the patches? Unless there's a compile time dependency I don't think we need to refactor anything here, what I'm seeing at the minute looks OK from a merge point of view except that there appears to be a lack of coordination between the various serieses. signature.asc Description: Digital signature
Re: [PATCH v3 0/2] Device tree support for TWL regulators
On Mon, Feb 27, 2012 at 03:21:26PM +0100, Cousson, Benoit wrote: Mmm, it is written in Rajendra's changelog: -2- All common regulator nodes for twl4030 and twl6030 are now defined in the twl4030.dtsi and twl6030.dtsi instead of Oh, it's buried at the end of a rather verbose inter-patch changelog, that's not exactly visible :( The good point is that a missing or broken DTS will indeed not break the build, it will just not boot the platform properly. But that still an important dependency to me. If adding device tree support breaks existing platforms something is going wrong, while you're pulling things together device tree might not work until all the support makes it in but the old non-DT code should continue to function. There's also more than that, there's also at least Tero submitting some other stuff separately (and his stuff won't play with DT...) and I think Peter also. It really fees like there's a bunch of people working on different things without talking to each other here. That's the problem with MFD devices that are doing everything from audio to power including the coffee... Well, in this case everyone's only working on the regulator stuff, or at least only overlapping on that. The twl drivers aren't helping here - the structure is *very* non-standard and seems to make updates more fiddly than they should be as you're not just adding stuff to tables. Every update seems to need explicit code and per-change data adding which is making life harder. If things looked more standard from a code point of view it'd probably reduce the pain a lot. signature.asc Description: Digital signature
Re: [PATCH v3 0/2] Device tree support for TWL regulators
On Mon, Feb 27, 2012 at 6:52 AM, Cousson, Benoit b-cous...@ti.com wrote: Hi Mark, On 2/27/2012 2:41 PM, Mark Brown wrote: On Mon, Feb 27, 2012 at 06:01:20PM +0530, Rajendra Nayak wrote: Depending on what order Mark happens to pull them in, I am fine re-sending adding support for the 2 twl6030 fixed regulators. Please can you guys come up with a single unified series for this stuff - I'll hold off on applying anything to allow you to do this. The issue is that the initial TWL regulator series from Rajendra will depend on the twl core DT support I have that depends on the irq_domain series from Grant... If it depends on the irqdomain tree, then just merge that tree into yours. That tree is stable now for exactly that reason. You can rely on it. git://git.secretlab.ca/git/linux-2.6 irqdomain/next g. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/2] Device tree support for TWL regulators
On 2/27/2012 11:17 PM, Grant Likely wrote: On Mon, Feb 27, 2012 at 6:52 AM, Cousson, Benoitb-cous...@ti.com wrote: Hi Mark, On 2/27/2012 2:41 PM, Mark Brown wrote: On Mon, Feb 27, 2012 at 06:01:20PM +0530, Rajendra Nayak wrote: Depending on what order Mark happens to pull them in, I am fine re-sending adding support for the 2 twl6030 fixed regulators. Please can you guys come up with a single unified series for this stuff - I'll hold off on applying anything to allow you to do this. The issue is that the initial TWL regulator series from Rajendra will depend on the twl core DT support I have that depends on the irq_domain series from Grant... If it depends on the irqdomain tree, then just merge that tree into yours. That tree is stable now for exactly that reason. You can rely on it. I've just posted a pull request [1] to Tony that will merge your series into an OMAP DT branch to be a base for further OMAP DT series. Regards, Benoit [1] http://www.spinics.net/lists/linux-omap/msg65346.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/2] Device tree support for TWL regulators
On Monday 27 February 2012 08:23 PM, Mark Brown wrote: If adding device tree support breaks existing platforms something is going wrong, while you're pulling things together device tree might not work until all the support makes it in but the old non-DT code should continue to function. Adding device tree support will not break existing platforms. The non-DT code will function as expected. The dependencies I mentioned were only with the dtsi/dts files that patch 2 was updating. The driver changes have no dependencies with any other DT series. I will repost all of Tero/Peter and my changes (to add DT support to the driver) as one single series and drop the dts file updates, which I guess can go via Tony/OMAP tree. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 0/2] Device tree support for TWL regulators
Re-sending as these patches did not make it to the lists due to
issues with my 'git send-email'
v3 has mainly 2 differences from v2
-1- TWL driver now uses just one table for both dt and
non-dt based lookup for driver data.
-2- All common regulator nodes for twl4030 and twl6030 are
now defined in the twl4030.dtsi and twl6030.dtsi instead of
repeating the nodes in all board files, which also means
the patch ('arm/dts: twl: Pass regulator data from dt')
has a dependency with the series from Benoit which adds the
twl4030.dtsi and twl6030.dtsi files[1].
I have tested the patches on omap4panda and omap3beagle boards.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git
for_3.4/dt_i2c_twl
Rajendra Nayak (2):
regulator: twl: adapt twl-regulator driver to dt
arm/dts: twl: Pass regulator data from dt
.../bindings/regulator/twl-regulator.txt | 63 ++
arch/arm/boot/dts/omap3-beagle.dts |6 +
arch/arm/boot/dts/twl4030.dtsi | 18 ++
arch/arm/boot/dts/twl6030.dtsi | 60 +
drivers/regulator/twl-regulator.c | 227 +---
5 files changed, 301 insertions(+), 73 deletions(-)
create mode 100644
Documentation/devicetree/bindings/regulator/twl-regulator.txt
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
