Re: [PATCH v4 00/11] HDMI: Split hdmi.c in DSS to seperate OMAP dependent
Hi, On Wed, Sep 7, 2011 at 5:25 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Tue, 2011-09-06 at 17:28 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although the Display subsytem is different.Also the IP block in future OMAP may differ from the one existing in OMAP4. Thus to reuse the code between these two processors , and maintain the multi omap build functionality in DSS. HDMI IP dependant code is seperated out from hdmi.c and moved to new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the function pointer to functionality/features offered by HDMI is called. This patch series does the split and also renames hdmi_omap4_panel.c to hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for other OMAP family of processors as well. This patch series is based on Tomi's LO-DSS2 master branch. changes since v3:Handle the sparse error for set_pll_pwr function Move audio functions out of hdmi.c to ip file. rename hdmi_data to ip_data V2: Rename certain files/function to have standard format and handle scenario when hdmi is disabled. V1: Function pointer approach to call the HDMI IP functions from DSS HDMI I think there's still lots of cleanups/restructuring needed for HDMI, but I'm willing to merge this patch set as it'll gives as a good baseline to continue the work, and trying to do too much in one go would just be difficult. However, there are a couple of changes I wish you can do first: - Remove refsel. You still have an enum and a field for it, even if it's not used. Instead fixed the bug in the same patch to use refsel to be set in the PLL_CFG2. - Instead of creating include/video/ti_hdmi.h, create the file into drivers/video/omap2/dss/. Let's keep this totally inside DSS2 for the time being. Sure done. - You still haven't changed copy_hdmi_to_dss_timings() to take a pointer instead of a value. It's been commented at least three times already. As similar things seem to happen quite often for you, if you have trouble remembering all the required changes, please write the received comments down to, say, a piece of paper, and cross them over when you've actually made the change. It's a waste of reviewers time to review and comment the same problems again and again. Point taken. Thanks for your review. Fixed this. - Go though the commit subjects and descriptions. I see the same typoes that I've also already commented about, and I see new ones also. Description on patch 10 is almost gibberish. Added more details to most of patches in series. Posting the patch. Mythri. Tomi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 00/11] HDMI: Split hdmi.c in DSS to seperate OMAP dependent
From: Mythri P K mythr...@ti.com
HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although
the Display subsytem is different.Also the IP block in future OMAP may differ
from the one existing in OMAP4. Thus to reuse the code between these two
processors , and maintain the multi omap build functionality in DSS.
HDMI IP dependant code is seperated out from hdmi.c and moved to
new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the
function pointer to functionality/features offered by HDMI is called.
This patch series does the split and also renames hdmi_omap4_panel.c to
hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for
other OMAP family of processors as well.
This patch series is based on Tomi's LO-DSS2 master branch.
changes since
v3:Handle the sparse error for set_pll_pwr function
Move audio functions out of hdmi.c to ip file.
rename hdmi_data to ip_data
V2: Rename certain files/function to have standard format and handle scenario
when hdmi is disabled.
V1: Function pointer approach to call the HDMI IP functions from DSS HDMI
Mythri P K (11):
OMAP4: DSS: HDMI: HDMI clean up to pass base_address dynamically to
IP dependant functions of HDMI
OMAP4: DSS: HDMI: Move pll and video configuration info to ip_data
structure
OMAP4: DSS: HDMI: Use specific HDMI timings structure instead of OMAP
DSS timings
OMAP4: DSS: HDMI: Move IP independent common header file definition
to generic header file
OMAP4 : DSS : HDMI : Move the EDID portion from HDMI IP header
OMAP4: DSS2: HDMI: Split the HDMI driver to DSS and IP
specific portion.
OMAP4: DSS2: HDMI: Move the HDMI IP dependent audio functions to IP
library
OMAP4: DSS: HDMI: Rename the functions in HDMI IP library to IP
specific name
OMAP4: DSS: HDMI: Move the common HDMI header file definition to
Include/video
OMAP4: DSS2: HDMI: Function pointer approach to call HDMI IP driver
function from DSS
OMAP4: DSS: Rename hdmi_omap4_panel.c to hdmi_panel.c
drivers/video/omap2/dss/Makefile |2 +-
drivers/video/omap2/dss/dss.h | 10 -
drivers/video/omap2/dss/dss_features.c | 20 +
drivers/video/omap2/dss/dss_features.h |3 +
drivers/video/omap2/dss/hdmi.c | 1027 ++--
drivers/video/omap2/dss/hdmi.h | 631
.../omap2/dss/{hdmi_omap4_panel.c = hdmi_panel.c} |2 +-
drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c | 1032
drivers/video/omap2/dss/ti_hdmi_4xxx_ip.h | 597 +++
include/video/omapdss.h| 23 +
include/video/ti_hdmi.h| 103 ++
11 files changed, 1851 insertions(+), 1599 deletions(-)
delete mode 100644 drivers/video/omap2/dss/hdmi.h
rename drivers/video/omap2/dss/{hdmi_omap4_panel.c = hdmi_panel.c} (99%)
create mode 100644 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
create mode 100644 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.h
create mode 100644 include/video/ti_hdmi.h
--
1.7.5.4
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
