Re: [Patch 5/8] DSPBRIDGE: typedef cleanup -DSP_HPROCESSOR

2010-02-05 Thread Omar Ramirez Luna 

Hi,

On 2/2/2010 6:44 PM, Hebbar, Shivananda wrote:

 From 82f402b577d1afb535b319eed4a18087010ef679 Mon Sep 17 00:00:00 2001
From: Shivananda Hebbarx0heb...@ti.com
Date: Thu, 28 Jan 2010 20:06:40 -0600
Subject: [PATCH] DSPBRIDGE: Remove typdef used for Processor type replace it 
with standard C type

Signed-off-by: Shivananda Hebbarx0heb...@ti.com
---
  arch/arm/plat-omap/include/dspbridge/cmm.h  |2 +-
  arch/arm/plat-omap/include/dspbridge/dbdefs.h   |2 -
  arch/arm/plat-omap/include/dspbridge/dmm.h  |2 +-
  arch/arm/plat-omap/include/dspbridge/drv.h  |2 +-
  arch/arm/plat-omap/include/dspbridge/node.h |2 +-
  arch/arm/plat-omap/include/dspbridge/proc.h |   41 +++---
  arch/arm/plat-omap/include/dspbridge/wcdioctl.h |   40 +++---
  drivers/dsp/bridge/pmgr/cmm.c   |2 +-
  drivers/dsp/bridge/pmgr/dev.c   |6 ++--
  drivers/dsp/bridge/pmgr/dmm.c   |2 +-
  drivers/dsp/bridge/pmgr/wcd.c   |2 +-
  drivers/dsp/bridge/rmgr/node.c  |2 +-
  drivers/dsp/bridge/rmgr/proc.c  |   42 +++---
  13 files changed, 72 insertions(+), 75 deletions(-)



missing this hunk for proc.c

@@ -246,7 +246,7 @@ PROC_Attach(u32 uProcessor, OPTIONAL CONST struct 
DSP_PROCESSORATTRIN *pAttrIn,

 Proc Object into DEV, 0x%x!\n, status);
}
if (DSP_SUCCEEDED(status)) {
-   *phProcessor = (DSP_HPROCESSOR)pProcObject;
+   *phProcessor = (void *)pProcObject;
pr_ctxt-hProcessor = *phProcessor;
(void)PROC_NotifyClients(pProcObject,
 DSP_PROCESSORATTACH);


[...]

- omar
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Patch 5/8] DSPBRIDGE: typedef cleanup -DSP_HPROCESSOR

2010-02-05 Thread Hebbar, Shivananda 
From fce3de8671931f5af3df467e0f923e86e9d1f9b3 Mon Sep 17 00:00:00 2001
From: Shivananda Hebbar x0heb...@ti.com
Date: Thu, 28 Jan 2010 20:06:40 -0600
Subject: [PATCH] DSPBRIDGE : typedef cleanup -DSP_HPROCESSOR

This patch removes the typedef used for processor handle
and replaces it with the normal C type.

Signed-off-by: Shivananda Hebbar x0heb...@ti.com
---
 arch/arm/plat-omap/include/dspbridge/cmm.h  |2 +-
 arch/arm/plat-omap/include/dspbridge/dbdefs.h   |1 -
 arch/arm/plat-omap/include/dspbridge/dmm.h  |2 +-
 arch/arm/plat-omap/include/dspbridge/drv.h  |2 +-
 arch/arm/plat-omap/include/dspbridge/node.h |2 +-
 arch/arm/plat-omap/include/dspbridge/proc.h |   41 ++---
 arch/arm/plat-omap/include/dspbridge/wcdioctl.h |   40 ++--
 drivers/dsp/bridge/pmgr/cmm.c   |2 +-
 drivers/dsp/bridge/pmgr/dev.c   |6 ++--
 drivers/dsp/bridge/pmgr/dmm.c   |2 +-
 drivers/dsp/bridge/pmgr/wcd.c   |2 +-
 drivers/dsp/bridge/rmgr/node.c  |2 +-
 drivers/dsp/bridge/rmgr/proc.c  |   44 +++---
 13 files changed, 73 insertions(+), 75 deletions(-)

diff --git a/arch/arm/plat-omap/include/dspbridge/cmm.h 
b/arch/arm/plat-omap/include/dspbridge/cmm.h
index fc2f51e..bad3ab0 100644
--- a/arch/arm/plat-omap/include/dspbridge/cmm.h
+++ b/arch/arm/plat-omap/include/dspbridge/cmm.h
@@ -160,7 +160,7 @@
  *  hDevObject != NULL
  *  Ensures:
  */
-   extern DSP_STATUS CMM_GetHandle(DSP_HPROCESSOR hProcessor,
+   extern DSP_STATUS CMM_GetHandle(void *hProcessor,
OUT struct CMM_OBJECT **phCmmMgr);

 /*
diff --git a/arch/arm/plat-omap/include/dspbridge/dbdefs.h 
b/arch/arm/plat-omap/include/dspbridge/dbdefs.h
index 222a93e..f2ff74c 100644
--- a/arch/arm/plat-omap/include/dspbridge/dbdefs.h
+++ b/arch/arm/plat-omap/include/dspbridge/dbdefs.h
@@ -110,7 +110,6 @@
typedef u32 DSP_STATUS; /* API return code type */

typedef HANDLE DSP_HNODE;   /* Handle to a DSP Node object  */
-   typedef HANDLE DSP_HPROCESSOR;  /* Handle to a Processor object */

 /* Handy Macros */
 #define IsValidProcEvent(x) (((x) == 0) || (((x)  (DSP_PROCESSORSTATECHANGE | 
\
diff --git a/arch/arm/plat-omap/include/dspbridge/dmm.h 
b/arch/arm/plat-omap/include/dspbridge/dmm.h
index 13a5088..688473a 100644
--- a/arch/arm/plat-omap/include/dspbridge/dmm.h
+++ b/arch/arm/plat-omap/include/dspbridge/dmm.h
@@ -38,7 +38,7 @@
  *  This is typically called from the client process.
  */

-   extern DSP_STATUS DMM_GetHandle(DSP_HPROCESSOR hProcessor,
+   extern DSP_STATUS DMM_GetHandle(void *hProcessor,
OUT struct DMM_OBJECT **phDmmMgr);

extern DSP_STATUS DMM_ReserveMemory(struct DMM_OBJECT *hDmmMgr,
diff --git a/arch/arm/plat-omap/include/dspbridge/drv.h 
b/arch/arm/plat-omap/include/dspbridge/drv.h
index 3eb1abd..c6d4626 100644
--- a/arch/arm/plat-omap/include/dspbridge/drv.h
+++ b/arch/arm/plat-omap/include/dspbridge/drv.h
@@ -134,7 +134,7 @@ struct PROCESS_CONTEXT{
enum GPP_PROC_RES_STATE resState;

/* Handle to Processor */
-   DSP_HPROCESSOR hProcessor;
+   void *hProcessor;

/* DSP Node resources */
struct NODE_RES_OBJECT *pNodeList;
diff --git a/arch/arm/plat-omap/include/dspbridge/node.h 
b/arch/arm/plat-omap/include/dspbridge/node.h
index df15884..9f0110a 100644
--- a/arch/arm/plat-omap/include/dspbridge/node.h
+++ b/arch/arm/plat-omap/include/dspbridge/node.h
@@ -570,7 +570,7 @@
  *  Parameters:
  *
  */
-   extern DSP_STATUS NODE_GetUUIDProps(DSP_HPROCESSOR hProcessor,
+   extern DSP_STATUS NODE_GetUUIDProps(void *hProcessor,
IN CONST struct DSP_UUID *pNodeId,
OUT struct DSP_NDBPROPS
*pNodeProps);
diff --git a/arch/arm/plat-omap/include/dspbridge/proc.h 
b/arch/arm/plat-omap/include/dspbridge/proc.h
index 8dbdaac..bbb089e 100644
--- a/arch/arm/plat-omap/include/dspbridge/proc.h
+++ b/arch/arm/plat-omap/include/dspbridge/proc.h
@@ -51,8 +51,7 @@
  */
extern DSP_STATUS PROC_Attach(u32 uProcessor,
  OPTIONAL CONST struct DSP_PROCESSORATTRIN
- *pAttrIn,
- OUT DSP_HPROCESSOR *phProcessor,
+ *pAttrIn, void **phProcessor,
  struct PROCESS_CONTEXT *pr_ctxt);

 /*
@@ -101,7 +100,7 @@
  *  Details:
  *  This function Calls WMD_BRD_Ioctl.
  */
-   extern DSP_STATUS PROC_Ctrl(DSP_HPROCESSOR hProcessor,
+   extern DSP_STATUS PROC_Ctrl(void *hProcessor,
u32 dwCmd, IN struct DSP_CBDATA *pArgs);

 /*
@@ -153,7 +152,7 @@
  *  Ensures:
  *

[Patch 5/8] DSPBRIDGE: typedef cleanup -DSP_HPROCESSOR

2010-02-02 Thread Hebbar, Shivananda 
From 82f402b577d1afb535b319eed4a18087010ef679 Mon Sep 17 00:00:00 2001
From: Shivananda Hebbar x0heb...@ti.com
Date: Thu, 28 Jan 2010 20:06:40 -0600
Subject: [PATCH] DSPBRIDGE: Remove typdef used for Processor type replace it 
with standard C type

Signed-off-by: Shivananda Hebbar x0heb...@ti.com
---
 arch/arm/plat-omap/include/dspbridge/cmm.h  |2 +-
 arch/arm/plat-omap/include/dspbridge/dbdefs.h   |2 -
 arch/arm/plat-omap/include/dspbridge/dmm.h  |2 +-
 arch/arm/plat-omap/include/dspbridge/drv.h  |2 +-
 arch/arm/plat-omap/include/dspbridge/node.h |2 +-
 arch/arm/plat-omap/include/dspbridge/proc.h |   41 +++---
 arch/arm/plat-omap/include/dspbridge/wcdioctl.h |   40 +++---
 drivers/dsp/bridge/pmgr/cmm.c   |2 +-
 drivers/dsp/bridge/pmgr/dev.c   |6 ++--
 drivers/dsp/bridge/pmgr/dmm.c   |2 +-
 drivers/dsp/bridge/pmgr/wcd.c   |2 +-
 drivers/dsp/bridge/rmgr/node.c  |2 +-
 drivers/dsp/bridge/rmgr/proc.c  |   42 +++---
 13 files changed, 72 insertions(+), 75 deletions(-)

diff --git a/arch/arm/plat-omap/include/dspbridge/cmm.h 
b/arch/arm/plat-omap/include/dspbridge/cmm.h
index fc2f51e..bad3ab0 100644
--- a/arch/arm/plat-omap/include/dspbridge/cmm.h
+++ b/arch/arm/plat-omap/include/dspbridge/cmm.h
@@ -160,7 +160,7 @@
  *  hDevObject != NULL
  *  Ensures:
  */
- extern DSP_STATUS CMM_GetHandle(DSP_HPROCESSOR hProcessor,
+ extern DSP_STATUS CMM_GetHandle(void *hProcessor,
  OUT struct CMM_OBJECT **phCmmMgr);

 /*
diff --git a/arch/arm/plat-omap/include/dspbridge/dbdefs.h 
b/arch/arm/plat-omap/include/dspbridge/dbdefs.h
index 10d5514..e3be0fc 100644
--- a/arch/arm/plat-omap/include/dspbridge/dbdefs.h
+++ b/arch/arm/plat-omap/include/dspbridge/dbdefs.h
@@ -111,8 +111,6 @@

  typedef HANDLE DSP_HNODE; /* Handle to a DSP Node object  */

- typedef HANDLE DSP_HPROCESSOR; /* Handle to a Processor object */
-
 /* Handy Macros */
 #define IsValidProcEvent(x) (((x) == 0) || (((x)  (DSP_PROCESSORSTATECHANGE | 
\
 DSP_PROCESSORATTACH | \
diff --git a/arch/arm/plat-omap/include/dspbridge/dmm.h 
b/arch/arm/plat-omap/include/dspbridge/dmm.h
index 13a5088..688473a 100644
--- a/arch/arm/plat-omap/include/dspbridge/dmm.h
+++ b/arch/arm/plat-omap/include/dspbridge/dmm.h
@@ -38,7 +38,7 @@
  *  This is typically called from the client process.
  */

- extern DSP_STATUS DMM_GetHandle(DSP_HPROCESSOR hProcessor,
+ extern DSP_STATUS DMM_GetHandle(void *hProcessor,
  OUT struct DMM_OBJECT **phDmmMgr);

  extern DSP_STATUS DMM_ReserveMemory(struct DMM_OBJECT *hDmmMgr, diff --git 
a/arch/arm/plat-omap/include/dspbridge/drv.h 
b/arch/arm/plat-omap/include/dspbridge/drv.h
index 3eb1abd..c6d4626 100644
--- a/arch/arm/plat-omap/include/dspbridge/drv.h
+++ b/arch/arm/plat-omap/include/dspbridge/drv.h
@@ -134,7 +134,7 @@ struct PROCESS_CONTEXT{
  enum GPP_PROC_RES_STATE resState;

  /* Handle to Processor */
- DSP_HPROCESSOR hProcessor;
+ void *hProcessor;

  /* DSP Node resources */
  struct NODE_RES_OBJECT *pNodeList;
diff --git a/arch/arm/plat-omap/include/dspbridge/node.h 
b/arch/arm/plat-omap/include/dspbridge/node.h
index df15884..9f0110a 100644
--- a/arch/arm/plat-omap/include/dspbridge/node.h
+++ b/arch/arm/plat-omap/include/dspbridge/node.h
@@ -570,7 +570,7 @@
  *  Parameters:
  *
  */
- extern DSP_STATUS NODE_GetUUIDProps(DSP_HPROCESSOR hProcessor,
+ extern DSP_STATUS NODE_GetUUIDProps(void *hProcessor,
  IN CONST struct DSP_UUID *pNodeId,
  OUT struct DSP_NDBPROPS
  *pNodeProps);
diff --git a/arch/arm/plat-omap/include/dspbridge/proc.h 
b/arch/arm/plat-omap/include/dspbridge/proc.h
index 8dbdaac..bbb089e 100644
--- a/arch/arm/plat-omap/include/dspbridge/proc.h
+++ b/arch/arm/plat-omap/include/dspbridge/proc.h
@@ -51,8 +51,7 @@
  */
  extern DSP_STATUS PROC_Attach(u32 uProcessor,
   OPTIONAL CONST struct DSP_PROCESSORATTRIN
-  *pAttrIn,
-  OUT DSP_HPROCESSOR *phProcessor,
+  *pAttrIn, void **phProcessor,
   struct PROCESS_CONTEXT *pr_ctxt);

 /*
@@ -101,7 +100,7 @@
  *  Details:
  *  This function Calls WMD_BRD_Ioctl.
  */
- extern DSP_STATUS PROC_Ctrl(DSP_HPROCESSOR hProcessor,
+ extern DSP_STATUS PROC_Ctrl(void *hProcessor,
 u32 dwCmd, IN struct DSP_CBDATA *pArgs);

 /*
@@ -153,7 +152,7 @@
  *  Ensures:
  *  Details:
  */
- extern DSP_STATUS PROC_EnumNodes(DSP_HPROCESSOR hProcessor,
+ extern DSP_STATUS PROC_EnumNodes(void *hProcessor,
   IN DSP_HNODE *aNodeTab,
   IN u32 uNodeTabSize,
   OUT u32 *puNumNodes,
@@ -187,7 +186,7 @@
  *  This function currently returns
  *  DSP_ENOTIMPL, and does not write any data to the pResourceInfo struct.
  */
- extern DSP_STATUS PROC_GetResourceInfo(DSP_HPROCESSOR hProcessor,
+ extern DSP_STATUS PROC_GetResourceInfo(void *hProcessor,
 u32 uResourceType,
 OUT

RE: [Patch 5/8] DSPBRIDGE: typedef cleanup -DSP_HPROCESSOR

2010-02-02 Thread Guzman Lugo, Fernando 

Looks good to me.

Regards,
Fernando

-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Hebbar, Shivananda
Sent: Tuesday, February 02, 2010 6:44 PM
To: linux-omap
Subject: [Patch 5/8] DSPBRIDGE: typedef cleanup -DSP_HPROCESSOR

From 82f402b577d1afb535b319eed4a18087010ef679 Mon Sep 17 00:00:00 2001
From: Shivananda Hebbar x0heb...@ti.com
Date: Thu, 28 Jan 2010 20:06:40 -0600
Subject: [PATCH] DSPBRIDGE: Remove typdef used for Processor type replace
it with standard C type

Signed-off-by: Shivananda Hebbar x0heb...@ti.com
---
 arch/arm/plat-omap/include/dspbridge/cmm.h  |2 +-
 arch/arm/plat-omap/include/dspbridge/dbdefs.h   |2 -
 arch/arm/plat-omap/include/dspbridge/dmm.h  |2 +-
 arch/arm/plat-omap/include/dspbridge/drv.h  |2 +-
 arch/arm/plat-omap/include/dspbridge/node.h |2 +-
 arch/arm/plat-omap/include/dspbridge/proc.h |   41 +++
---
 arch/arm/plat-omap/include/dspbridge/wcdioctl.h |   40 +++
---
 drivers/dsp/bridge/pmgr/cmm.c   |2 +-
 drivers/dsp/bridge/pmgr/dev.c   |6 ++--
 drivers/dsp/bridge/pmgr/dmm.c   |2 +-
 drivers/dsp/bridge/pmgr/wcd.c   |2 +-
 drivers/dsp/bridge/rmgr/node.c  |2 +-
 drivers/dsp/bridge/rmgr/proc.c  |   42 +++
---
 13 files changed, 72 insertions(+), 75 deletions(-)

diff --git a/arch/arm/plat-omap/include/dspbridge/cmm.h b/arch/arm/plat-
omap/include/dspbridge/cmm.h
index fc2f51e..bad3ab0 100644
--- a/arch/arm/plat-omap/include/dspbridge/cmm.h
+++ b/arch/arm/plat-omap/include/dspbridge/cmm.h
@@ -160,7 +160,7 @@
  *  hDevObject != NULL
  *  Ensures:
  */
- extern DSP_STATUS CMM_GetHandle(DSP_HPROCESSOR hProcessor,
+ extern DSP_STATUS CMM_GetHandle(void *hProcessor,
  OUT struct CMM_OBJECT **phCmmMgr);

 /*
diff --git a/arch/arm/plat-omap/include/dspbridge/dbdefs.h b/arch/arm/plat-
omap/include/dspbridge/dbdefs.h
index 10d5514..e3be0fc 100644
--- a/arch/arm/plat-omap/include/dspbridge/dbdefs.h
+++ b/arch/arm/plat-omap/include/dspbridge/dbdefs.h
@@ -111,8 +111,6 @@

  typedef HANDLE DSP_HNODE; /* Handle to a DSP Node object  */

- typedef HANDLE DSP_HPROCESSOR; /* Handle to a Processor object */
-
 /* Handy Macros */
 #define IsValidProcEvent(x) (((x) == 0) || (((x) 
(DSP_PROCESSORSTATECHANGE | \
 DSP_PROCESSORATTACH | \
diff --git a/arch/arm/plat-omap/include/dspbridge/dmm.h b/arch/arm/plat-
omap/include/dspbridge/dmm.h
index 13a5088..688473a 100644
--- a/arch/arm/plat-omap/include/dspbridge/dmm.h
+++ b/arch/arm/plat-omap/include/dspbridge/dmm.h
@@ -38,7 +38,7 @@
  *  This is typically called from the client process.
  */

- extern DSP_STATUS DMM_GetHandle(DSP_HPROCESSOR hProcessor,
+ extern DSP_STATUS DMM_GetHandle(void *hProcessor,
  OUT struct DMM_OBJECT **phDmmMgr);

  extern DSP_STATUS DMM_ReserveMemory(struct DMM_OBJECT *hDmmMgr, diff --
git a/arch/arm/plat-omap/include/dspbridge/drv.h b/arch/arm/plat-
omap/include/dspbridge/drv.h
index 3eb1abd..c6d4626 100644
--- a/arch/arm/plat-omap/include/dspbridge/drv.h
+++ b/arch/arm/plat-omap/include/dspbridge/drv.h
@@ -134,7 +134,7 @@ struct PROCESS_CONTEXT{
  enum GPP_PROC_RES_STATE resState;

  /* Handle to Processor */
- DSP_HPROCESSOR hProcessor;
+ void *hProcessor;

  /* DSP Node resources */
  struct NODE_RES_OBJECT *pNodeList;
diff --git a/arch/arm/plat-omap/include/dspbridge/node.h b/arch/arm/plat-
omap/include/dspbridge/node.h
index df15884..9f0110a 100644
--- a/arch/arm/plat-omap/include/dspbridge/node.h
+++ b/arch/arm/plat-omap/include/dspbridge/node.h
@@ -570,7 +570,7 @@
  *  Parameters:
  *
  */
- extern DSP_STATUS NODE_GetUUIDProps(DSP_HPROCESSOR hProcessor,
+ extern DSP_STATUS NODE_GetUUIDProps(void *hProcessor,
  IN CONST struct DSP_UUID *pNodeId,
  OUT struct DSP_NDBPROPS
  *pNodeProps);
diff --git a/arch/arm/plat-omap/include/dspbridge/proc.h b/arch/arm/plat-
omap/include/dspbridge/proc.h
index 8dbdaac..bbb089e 100644
--- a/arch/arm/plat-omap/include/dspbridge/proc.h
+++ b/arch/arm/plat-omap/include/dspbridge/proc.h
@@ -51,8 +51,7 @@
  */
  extern DSP_STATUS PROC_Attach(u32 uProcessor,
   OPTIONAL CONST struct DSP_PROCESSORATTRIN
-  *pAttrIn,
-  OUT DSP_HPROCESSOR *phProcessor,
+  *pAttrIn, void **phProcessor,
   struct PROCESS_CONTEXT *pr_ctxt);

 /*
@@ -101,7 +100,7 @@
  *  Details:
  *  This function Calls WMD_BRD_Ioctl.
  */
- extern DSP_STATUS PROC_Ctrl(DSP_HPROCESSOR hProcessor,
+ extern DSP_STATUS PROC_Ctrl(void *hProcessor,
 u32 dwCmd, IN struct DSP_CBDATA *pArgs);

 /*
@@ -153,7 +152,7 @@
  *  Ensures:
  *  Details:
  */
- extern DSP_STATUS PROC_EnumNodes(DSP_HPROCESSOR hProcessor,
+ extern DSP_STATUS PROC_EnumNodes(void *hProcessor,
   IN DSP_HNODE *aNodeTab,
   IN u32 uNodeTabSize,
   OUT u32 *puNumNodes,
@@ -187,7 +186,7