HELLO DEAR
-- I am very sorry If I interfere into your privacy,i will like to get acquainted with you. I will appreciate if granted this Privilege to know you more. Get back to me for formal introduction ,waiting earnestly to read from you. ( ezzahzuw...@hotmail.com ) Ezzah -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello!!!
Hello, Mrs. Liliane picked you. For details email her directly: lilbetencou...@hotmail.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
hello
Моето Скъпи Едно, Приятно ми е да се запознаем аз видях в пощата си днес, когато аз бях търсят и се интересуват от знаейки, че повече аз наистина биха искали да имат добри отношения с вас, и аз имам специални причини, поради които реших да се свържем с вас Реших да ви пиша, поради неотложността на положението ми тук аз съм Мис Laura, на 25 години момиче от Кот д'Ивоар, единствената дъщеря на края Wintour Sirleaf заместник-министър на националната сигурност, под ръководството на президента Laurent Gbagbo, който в момента е в изгнание след много невинни души бяха убити, баща ми беше убит от Laurent Gbagbo's правителство, обвинявайки то на баща ми се опита за преврат Трябва да се свържем с вас, защото на малтретиране, което получих от моя стъпка майка, мащехата ми, планове е да се вземат всички хазната и имуществото на покойния ми баща от мен, след неочакваната смърт на любимия си баща Бих искал да избяга от страна на Африка, но тя се скрия паспорта ми и други ценни документи за пътуване, За щастие, тя не се намерят, когато си тръгнах файл на баща ми, който съдържа важни документи Затова реших да тичам до бежански лагер, където съм в момента търси убежище под егидата на върховния комисар на ООН за бежанците тук в Ломе, Република Того. Искам да ви пиша лично за дългогодишен бизнес отношения и инвестиции във вашата страна Баща ми депозира сума от US $ 6 500, 000,00 милиона долара в банката, с моето име като най-близък роднина. Независимо от това, искам да се кандидатират за мен като попечител, а също и да ми помогне да преведе парите по сметката си и вие също ще ми помогне да инвестират парите във вашата страна, ако приемете да ми помогне аз ще предаде на вас необходимите документи и аз ще продължа с обучението си, когато аз дойда във вашата страна, аз бях в моя милион години в университета, когато кризата започна Моето намерение е да ви компенсира 20% от общата сума на пари за услугите си и балансът ще бъде мой инвестиционен капитал. Това е причината, поради която реших да се свържем с вас В очакване на вашия спешни и положителен отговор. Моля те, не го оставяйте само за себе си, моля, аз не питам за да го разкрие на всяко друго лице, докато се прави прехвърлянето Моля, нека моето положение докосне сърцето си, аз ви моля да дойдете за моето оздравяване аз страдам толкова много тук , аз никога не съм бил в този вид на ситуацията преди, моля да ми помогне Best рег. Laura
Hello dear,
Hello dear, please do not be offended to receive this massage,My Name is miss Glory Rubel, I saw your today, and become very interest to be your friend And i have an important issue to discuse with you if you accept Please contact me back on my private email address:( gloryru...@hotmail.com ) for more details about me, thanks, -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello From KM
Good Day, Please letâs talk and see if we can partner together to achieve our various future goals. Lets talk about real business deal. Regards, KM -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello My Dear.
Hello My Dear, How are you today? I hope fine, I came across your contact today while browsing looking for reliable friend and i became interested, My name is miss Famatta Sando. I wish to have you as a friend, if you care. I have important reasons to request your interest for a serious friendship, i will be happy if you write me back, so that i can easily explain to you more about me and give you my picture for you to know whom i am, I have something very Important to tell you. Thanks for your understanding. Your New Friend. Miss Famatta. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello My Dear.
Hello My Dear, How are you today? I hope fine,I came across your contact today while browsing looking for reliable friend and i became interested, my name is miss Famatta. I wish to have you as a friend, if you care. I have important reasons to request your interest for a serious relationship, i will be happy if you write me back, so that i can easily explain to you more about me and give you my picture for you to know whom i am, I have something very Important to tell you. Thanks for your understanding. Your New Friend. Miss Famatta. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
hello :)
Hi all ! I looked at your own image on facebook. I'm keen on you a lot. Let's talk ! I can send you my image as well if you want... Kisses, -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: YUV rotation support for DSS2 - 2.6.29 [WAS Re: Hello Tomi Valkeinen, I have some questions about dss2 driver.]
Hi Tomi, Can you please merge the YUV rotation patches with your latest? Thanks and Regards, Haardik -Original Message- From: plasma...@gmail.com [mailto:plasma...@gmail.com] On Behalf Of Tim Yamin Sent: Tuesday, April 14, 2009 2:30 AM To: Shah, Hardik Cc: grego...@gentil.com; tomi.valkei...@nokia.com; linux-omap@vger.kernel.org; beaglebo...@googlegroups.com Subject: Re: YUV rotation support for DSS2 - 2.6.29 [WAS Re: Hello Tomi Valkeinen, I have some questions about dss2 driver.] Hi Hardik, Thanks for fixing up the patch. I can confirm that YUV rotation is fine and patches are ready to be merged -- although the attached fix is needed as well for the userspace layer to know the correct row strides when writing YUV to the framebuffer. I'm still having VID1_FIFO_UNDERFLOW errors when I try to play rotated video on plane 1 and plane 0 is rotated as well. Do you have any ideas how to debug this further? Thanks, Tim Hi Tomi, If YUV rotation with frame buffer passes can you please review the patch and merge it to your latest. Regards, Hardik -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: YUV rotation support for DSS2 - 2.6.29 [WAS Re: Hello Tomi Valkeinen, I have some questions about dss2 driver.]
Hi, -Original Message- From: plasma...@gmail.com [mailto:plasma...@gmail.com] On Behalf Of Tim Yamin Sent: Wednesday, April 08, 2009 12:31 AM To: Shah, Hardik Cc: grego...@gentil.com; tomi.valkei...@nokia.com; linux-omap@vger.kernel.org; beaglebo...@googlegroups.com Subject: Re: YUV rotation support for DSS2 - 2.6.29 [WAS Re: Hello Tomi Valkeinen, I have some questions about dss2 driver.] Hi Hardik / Tomi, [Shah, Hardik] I have also patched the DSS to support the DSS YUV rotation. Here the rotation type is passed to know the type of rotation required by driver. I have also modified the FBDEV driver to use this patch. Please find the both patches. I have tested it on the old master of tomi. Commit id is 4261fafc4fdc0730b3d4dd83c036d8be09ec8575. I am planning to rebase it on the latest master soon. I have tested the FBDEV driver with different rotation and resolution settings. Hi Tim, I have done few changes to your patch. - else if (bytespp == 2) + width = 1; Will not work for 32 bit formats like ARGB or RGB24u. Secondly I have fixed lot many check patch warnings/errors in your patch. So please do that before providing patches. Third I have implemented VRFB mirroring also. I have tested YUV, UYVY, RGB24u, RGB16, and ARGB on V4L2 driver with rotation and mirroring with different resolutions on LCD and its working fine. Tim, Will you please test the YUV rotation with frame buffer driver with the attached patch and let us know the result. I have tested RGB rotation and its working fine. Hi Tomi, If YUV rotation with frame buffer passes can you please review the patch and merge it to your latest. Regards, Hardik I've merged my changes with your patches and rebased against master, please find the new patch attached. [Shah, Hardik] Hi Tim, I have modified your DSS2 rotation patch to make it more generic to support YUV as well as ARGB32 and RGB24u formats. [Shah, Hardik] In past I saw setting the FIFO size eliminates this problem. I have some FIFO setting can you please try this out and let me know the result. FIFO_HIGH_THRES = 0x3FC and GFX_FIFO_LOW_THRES = 0x3BC. This I tried in on OMAP3. Tried this (see attached patch) but does not help -- still getting these errors as soon as I try to play a video: omapdss DISPC error: VID1_FIFO_UNDERFLOW, disabling VID1 omapdss DISPC error: SYNC_LOST, disabling LCD The FIFOs are configured as follows: omapdss DISPC: fifo(0) size 1024, low/high old 3008/3071, new 956/1020 omapdss DISPC: fifo(1) size 1024, low/high old 956/1020, new 956/1020 Cheers, Tim 0002-DSS2-OMAPFB-Added-support-for-the-YUV-VRFB-rotatio.patch Description: 0002-DSS2-OMAPFB-Added-support-for-the-YUV-VRFB-rotatio.patch 0001-DSS2-VRFB-rotation-and-mirroring-implemented.patch Description: 0001-DSS2-VRFB-rotation-and-mirroring-implemented.patch
Re: YUV rotation support for DSS2 - 2.6.29 [WAS Re: Hello Tomi Valkeinen, I have some questions about dss2 driver.]
Hi Hardik,
Thanks for fixing up the patch. I can confirm that YUV rotation is
fine and patches are ready to be merged -- although the attached fix
is needed as well for the userspace layer to know the correct row
strides when writing YUV to the framebuffer.
I'm still having VID1_FIFO_UNDERFLOW errors when I try to play rotated
video on plane 1 and plane 0 is rotated as well. Do you have any ideas
how to debug this further?
Thanks,
Tim
Hi Tomi,
If YUV rotation with frame buffer passes can you please review the patch and
merge it to your latest.
Regards,
Hardik
From 4ba3f8b1d2feef00ac6c8de827262d255cebb185 Mon Sep 17 00:00:00 2001
From: Tim Yamin pl...@roo.me.uk
Date: Mon, 13 Apr 2009 13:57:42 -0700
Subject: [PATCH] DSS2: OMAPFB: Set line_length correctly for YUV with VRFB.
Signed-off-by: Tim Yamin pl...@roo.me.uk
---
drivers/video/omap2/omapfb/omapfb-main.c | 30 +-
1 files changed, 25 insertions(+), 5 deletions(-)
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index 9043265..675a7c9 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -377,10 +377,19 @@ void set_fb_fix(struct fb_info *fbi)
fbi-screen_base = (char __iomem *)omapfb_get_region_vaddr(ofbi);
/* used by mmap in fbmem.c */
- if (ofbi-rotation_type == OMAP_DSS_ROT_VRFB)
- fix-line_length =
- (OMAP_VRFB_LINE_LEN * var-bits_per_pixel) 3;
- else
+ if (ofbi-rotation_type == OMAP_DSS_ROT_VRFB) {
+ switch (var-nonstd) {
+ case OMAPFB_COLOR_YUV422:
+ case OMAPFB_COLOR_YUY422:
+ fix-line_length =
+(OMAP_VRFB_LINE_LEN * var-bits_per_pixel) 2;
+ break;
+ default:
+ fix-line_length =
+(OMAP_VRFB_LINE_LEN * var-bits_per_pixel) 3;
+ break;
+ }
+ } else
fix-line_length =
(var-xres_virtual * var-bits_per_pixel) 3;
fix-smem_start = omapfb_get_region_paddr(ofbi);
@@ -689,7 +698,18 @@ static int omapfb_setup_overlay(struct fb_info *fbi, struct omap_overlay *ovl,
goto err;
}
- screen_width = fix-line_length / (var-bits_per_pixel 3);
+ switch (var-nonstd) {
+ case OMAPFB_COLOR_YUV422:
+ case OMAPFB_COLOR_YUY422:
+ if (ofbi-rotation_type == OMAP_DSS_ROT_VRFB) {
+ screen_width = fix-line_length
+/ (var-bits_per_pixel 2);
+ break;
+ }
+ default:
+ screen_width = fix-line_length / (var-bits_per_pixel 3);
+ break;
+ }
ovl-get_overlay_info(ovl, info);
--
1.5.6.3
Re: YUV rotation support for DSS2 - 2.6.29 [WAS Re: Hello Tomi Valkeinen, I have some questions about dss2 driver.]
Hi Hardik / Tomi,
[Shah, Hardik] I have also patched the DSS to support the DSS YUV rotation.
Here the rotation type is passed to know the type of rotation required by
driver. I have also modified the FBDEV driver to use this patch. Please
find the both patches. I have tested it on the old master of tomi. Commit id
is 4261fafc4fdc0730b3d4dd83c036d8be09ec8575. I am planning to rebase it on
the latest master soon. I have tested the FBDEV driver with different
rotation and resolution settings.
I've merged my changes with your patches and rebased against master,
please find the new patch attached.
[Shah, Hardik] In past I saw setting the FIFO size eliminates this problem.
I have some FIFO setting can you please try this out and let me know the
result.
FIFO_HIGH_THRES = 0x3FC and GFX_FIFO_LOW_THRES = 0x3BC. This I tried in on
OMAP3.
Tried this (see attached patch) but does not help -- still getting
these errors as soon as I try to play a video:
omapdss DISPC error: VID1_FIFO_UNDERFLOW, disabling VID1
omapdss DISPC error: SYNC_LOST, disabling LCD
The FIFOs are configured as follows:
omapdss DISPC: fifo(0) size 1024, low/high old 3008/3071, new 956/1020
omapdss DISPC: fifo(1) size 1024, low/high old 956/1020, new 956/1020
Cheers,
Tim
From 5c575fd5226164c75e0bc98a5ead80ee6900fdc1 Mon Sep 17 00:00:00 2001
From: Tim Yamin pl...@roo.me.uk
Date: Tue, 7 Apr 2009 11:27:54 -0700
Subject: [PATCH] Change FIFO settings as suggested by Hardik.
---
drivers/video/omap2/dss/dispc.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c
index 550a2a0..61785e3 100644
--- a/drivers/video/omap2/dss/dispc.c
+++ b/drivers/video/omap2/dss/dispc.c
@@ -960,6 +960,12 @@ void dispc_setup_plane_fifo(enum omap_plane plane, u32 low, u32 high)
BUG_ON(low size || high size);
+ if(size == 1024)
+ {
+ high = 0x3FC;
+ low = 0x3BC;
+ }
+
DSSDBG(fifo(%d) size %d, low/high old %u/%u, new %u/%u\n,
plane, size,
REG_GET(ftrs_reg[plane], 11, 0),
@@ -1463,6 +1469,8 @@ static int _dispc_setup_plane(enum omap_plane plane,
out_width, out_height);
_dispc_set_plane_pos(plane, pos_x, pos_y);
+ if (plane != OMAP_DSS_GFX)
+ _dispc_set_plane_pos(plane, 5, 5);
_dispc_set_pic_size(plane, width, height);
--
1.5.6.3
From 826edf9b2b9af7b9bc32f4363724af174911175c Mon Sep 17 00:00:00 2001
From: Tim Yamin pl...@roo.me.uk
Date: Tue, 7 Apr 2009 11:52:35 -0700
Subject: [PATCH] DSS2: Add YUV VRFB rotation support
This is a rebased version of Hardik Shah's patch with a few additional
tweaks from me.
Signed-off-by: Tim Yamin pl...@roo.me.uk
---
arch/arm/plat-omap/include/mach/display.h |6 ++
arch/arm/plat-omap/vrfb.c |4 +-
drivers/video/omap2/dss/dispc.c | 87 ++--
drivers/video/omap2/dss/dss.h |1 +
drivers/video/omap2/dss/manager.c |1 +
drivers/video/omap2/omapfb/omapfb-main.c | 66 +++---
drivers/video/omap2/omapfb/omapfb.h |7 +--
7 files changed, 126 insertions(+), 46 deletions(-)
diff --git a/arch/arm/plat-omap/include/mach/display.h b/arch/arm/plat-omap/include/mach/display.h
index 6b702c7..b0a6272 100644
--- a/arch/arm/plat-omap/include/mach/display.h
+++ b/arch/arm/plat-omap/include/mach/display.h
@@ -341,6 +341,11 @@ enum omap_dss_overlay_managers {
struct omap_overlay_manager;
+enum omap_dss_rotation_type {
+ OMAP_DSS_ROT_DMA = 0,
+ OMAP_DSS_ROT_VRFB = 1,
+};
+
struct omap_overlay_info {
bool enabled;
@@ -351,6 +356,7 @@ struct omap_overlay_info {
u16 height;
enum omap_color_mode color_mode;
u8 rotation;
+ enum omap_dss_rotation_type rotation_type;
bool mirror;
u16 pos_x;
diff --git a/arch/arm/plat-omap/vrfb.c b/arch/arm/plat-omap/vrfb.c
index 7e0f8fc..77aa9a7 100644
--- a/arch/arm/plat-omap/vrfb.c
+++ b/arch/arm/plat-omap/vrfb.c
@@ -61,8 +61,10 @@ void omap_vrfb_setup(struct vrfb *vrfb, unsigned long paddr,
width, height, bytespp);
if (bytespp == 4)
+ {
pixel_size_exp = 2;
- else if (bytespp == 2)
+ width = 1;
+ } else if (bytespp == 2)
pixel_size_exp = 1;
else
BUG();
diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c
index ae7be3d..b1dbb79 100644
--- a/drivers/video/omap2/dss/dispc.c
+++ b/drivers/video/omap2/dss/dispc.c
@@ -1106,7 +1106,7 @@ static void _dispc_set_rotation_attrs(enum omap_plane plane, u8 rotation,
case 0: vidrot = 0; break;
case 1: vidrot = 1; break;
case 2: vidrot = 2; break;
- case 3: vidrot = 1; break;
+ case 3: vidrot = 3; break;
}
}
@@ -1134,7 +1134,70 @@ static s32 pixinc(int pixels, u8 ps)
BUG();
}
-static void calc_rotation_offset(u8 rotation, bool mirror,
+static void calc_vrfb_rotation_offset(u8 rotation, bool mirror,
+ u16 screen_width,
+ u16 width, u16 height,
+ enum omap_color_mode color_mode, bool fieldmode,
+ unsigned *offset0, unsigned
YUV rotation support for DSS2 - 2.6.29 [WAS Re: Hello Tomi Valkeinen, I have some questions about dss2 driver.]
Tomi,
Tim has patched your latest DSS2 2.6.29 git (master branch) to add
support for YUV rotation. It has been successfully tested on the coming
Touch Book, as well as the Beagleboard Rev B6 with the exception of the
bug mentioned below. You may want to review this patch and perhaps
integrate once we have fixed the problem below.
A couple of questions and comments:
1. dss.c has no way of knowing whether VRFB is being used or not --
this is a problem because you need to decide whether to call
calc_rotation_offset_vrfb(...) or calc_rotation_offset(...). Any
suggestions on how the rotation mode should be passed between dss.c and
omapfb-main.c?
2. If I try to rotate both plane 0 and plane 1 to either 90 degrees or
270 (doesn't matter which is which), as soon as you try to play a video
you get VID1_FIFO_UNDERFLOW error messages, so it seems that the
hardware seems to be struggling a little when you have two sets of
90/270 degree rotations. If one of the planes is 0/180 and the other
is 90/270, then everything is fine. Would changing the FIFO settings
somehow improve this or do you have any ideas about what else might make
it work better?
Thanks in advance,
Grégoire Gentil
diff --git a/arch/arm/plat-omap/vrfb.c b/arch/arm/plat-omap/vrfb.c
index 7e0f8fc..77aa9a7 100644
--- a/arch/arm/plat-omap/vrfb.c
+++ b/arch/arm/plat-omap/vrfb.c
@@ -61,8 +61,10 @@ void omap_vrfb_setup(struct vrfb *vrfb, unsigned long paddr,
width, height, bytespp);
if (bytespp == 4)
+ {
pixel_size_exp = 2;
- else if (bytespp == 2)
+ width = 1;
+ } else if (bytespp == 2)
pixel_size_exp = 1;
else
BUG();
diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c
index 2480a03..1f022ce 100644
--- a/drivers/video/omap2/dss/dispc.c
+++ b/drivers/video/omap2/dss/dispc.c
@@ -1089,7 +1089,8 @@ static void _dispc_set_scaling(enum omap_plane plane,
}
static void _dispc_set_rotation_attrs(enum omap_plane plane, u8 rotation,
- bool mirroring, enum omap_color_mode color_mode)
+ bool mirroring, enum omap_color_mode color_mode, u16 width,
+ u16 height)
{
if (color_mode == OMAP_DSS_COLOR_YUV2 ||
color_mode == OMAP_DSS_COLOR_UYVY) {
@@ -1107,7 +1108,7 @@ static void _dispc_set_rotation_attrs(enum omap_plane plane, u8 rotation,
case 0: vidrot = 0; break;
case 1: vidrot = 1; break;
case 2: vidrot = 2; break;
- case 3: vidrot = 1; break;
+ case 3: vidrot = 3; break;
}
}
@@ -1121,6 +1122,13 @@ static void _dispc_set_rotation_attrs(enum omap_plane plane, u8 rotation,
REG_FLD_MOD(dispc_reg_att[plane], 0, 13, 12);
REG_FLD_MOD(dispc_reg_att[plane], 0, 18, 18);
}
+
+ /* Turn on DMA optimization. For this to work, both height
+ and width need to be even... */
+ if(width % 2 == 0 height % 2 == 0 (rotation == 1 || rotation == 3))
+ REG_FLD_MOD(dispc_reg_att[plane], 1, 20, 20);
+ else
+ REG_FLD_MOD(dispc_reg_att[plane], 0, 20, 20);
}
static s32 pixinc(int pixels, u8 ps)
@@ -1283,6 +1291,76 @@ static void calc_rotation_offset(u8 rotation, bool mirror,
}
}
+static void calc_rotation_offset_vrfb(u8 rotation, bool mirror,
+ u16 screen_width,
+ u16 width, u16 height,
+ enum omap_color_mode color_mode, bool fieldmode,
+ unsigned *offset0, unsigned *offset1,
+ s32 *row_inc, s32 *pix_inc)
+{
+ u8 ps;
+ u16 fbw, fbh;
+
+ DSSDBG(calc_rot(%d): scrw %d, %dx%d, cm %d\n, rotation, screen_width,
+ width, height, color_mode);
+
+ /* width height are overlay sizes, convert to fb sizes */
+ if (rotation == 0 || rotation == 2) {
+ fbw = width;
+ fbh = height;
+ } else {
+ fbw = height;
+ fbh = width;
+ }
+
+ switch (color_mode) {
+ case OMAP_DSS_COLOR_RGB16:
+ case OMAP_DSS_COLOR_ARGB16:
+ ps = 2;
+ break;
+
+ case OMAP_DSS_COLOR_RGB24P:
+ ps = 3;
+ break;
+
+ case OMAP_DSS_COLOR_RGB24U:
+ case OMAP_DSS_COLOR_ARGB32:
+ case OMAP_DSS_COLOR_RGBA32:
+ case OMAP_DSS_COLOR_RGBX32:
+ ps = 4;
+ break;
+
+ case OMAP_DSS_COLOR_YUV2:
+ case OMAP_DSS_COLOR_UYVY:
+ ps = 4;
+ fbw = 1;
+ break;
+ default:
+ BUG();
+ return;
+ }
+
+ *pix_inc = 1;
+ switch(rotation + mirror * 4) {
+ case 0:
+ case 1:
+ case 2:
+ case 3:
+ *offset0 = *offset1 = 0;
+ break;
+ default:
+ BUG();
+ }
+
+if(!mirror) {
+ if(rotation == 0 || rotation == 2)
+ *row_inc = 1 + (screen_width - fbw) * ps;
+ else
+ *row_inc = 1 + (screen_width - fbh) * ps;
+ } else
+ BUG();
+}
+
static int _dispc_setup_plane(enum omap_plane plane,
enum omap_channel channel_out,
u32 paddr, u16 screen_width,
@@ -1361,7 +1439,7 @@ static int _dispc_setup_plane(enum omap_plane plane,
if (ilace height = out_height)
fieldmode = 1;
- calc_rotation_offset(rotation, mirror,
+ calc_rotation_offset_vrfb(rotation, mirror,
screen_width, width, height, color_mode,
fieldmode,
offset0, offset1, row_inc, pix_inc);
@@ -1393,18 +1471,25 @@ static int _dispc_setup_plane(enum omap_plane plane,
out_width, out_height);
_dispc_set_plane_pos(plane, pos_x, pos_y);
-
RE: YUV rotation support for DSS2 - 2.6.29 [WAS Re: Hello Tomi Valkeinen, I have some questions about dss2 driver.]
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Gregoire Gentil Sent: Tuesday, April 07, 2009 10:00 AM To: tomi.valkei...@nokia.com Cc: linux-omap@vger.kernel.org; beaglebo...@googlegroups.com; pl...@roo.me.uk Subject: YUV rotation support for DSS2 - 2.6.29 [WAS Re: Hello Tomi Valkeinen, I have some questions about dss2 driver.] Tomi, Tim has patched your latest DSS2 2.6.29 git (master branch) to add support for YUV rotation. It has been successfully tested on the coming Touch Book, as well as the Beagleboard Rev B6 with the exception of the bug mentioned below. You may want to review this patch and perhaps integrate once we have fixed the problem below. A couple of questions and comments: 1. dss.c has no way of knowing whether VRFB is being used or not -- this is a problem because you need to decide whether to call calc_rotation_offset_vrfb(...) or calc_rotation_offset(...). Any suggestions on how the rotation mode should be passed between dss.c and omapfb-main.c? [Shah, Hardik] I have also patched the DSS to support the DSS YUV rotation. Here the rotation type is passed to know the type of rotation required by driver. I have also modified the FBDEV driver to use this patch. Please find the both patches. I have tested it on the old master of tomi. Commit id is 4261fafc4fdc0730b3d4dd83c036d8be09ec8575. I am planning to rebase it on the latest master soon. I have tested the FBDEV driver with different rotation and resolution settings. 2. If I try to rotate both plane 0 and plane 1 to either 90 degrees or 270 (doesn't matter which is which), as soon as you try to play a video you get VID1_FIFO_UNDERFLOW error messages, so it seems that the hardware seems to be struggling a little when you have two sets of 90/270 degree rotations. If one of the planes is 0/180 and the other is 90/270, then everything is fine. Would changing the FIFO settings somehow improve this or do you have any ideas about what else might make it work better? [Shah, Hardik] In past I saw setting the FIFO size eliminates this problem. I have some FIFO setting can you please try this out and let me know the result. FIFO_HIGH_THRES = 0x3FC and GFX_FIFO_LOW_THRES = 0x3BC. This I tried in on OMAP3. Regards, Hardik Shah Thanks in advance, Grégoire Gentil [Shah, Hardik] Hi, 0002-DSS2-OMAPFB-Changed-to-support-YUV-VRFB-rotation.patch Description: 0002-DSS2-OMAPFB-Changed-to-support-YUV-VRFB-rotation.patch 0001-DSS2-Added-support-for-the-YUV-VRFB-rotation.patch Description: 0001-DSS2-Added-support-for-the-YUV-VRFB-rotation.patch
Re: Hello Tomi Valkeinen, I have some questions about dss2 driver.
Hi, On Wed, 2009-03-11 at 05:57 +0100, ext InKi Dae wrote: I am using your dss2 driver downloaded from your git server and tried to rotate an image(RGB24U and YUV2 format) using OMAPFB_ROT_DMA command. but I can't see rotated image on screen. I added variables for rotating like below. as the result, LCD Panel is stoped. omapfb.rotate=2 omapfb.vrfb=n and then I tried again using OMAPFB_ROT_VRFB command like below. omapfb.rotate=2 omapfb.vrfb=y In this case, I can see rotated image(only RGB24U format) on screen. You asid Rotation and mirroring currently only supports RGB565 and RGB modes. VRFB does not support mirroring through /Documentation/arm/OMAP/DSS file. Doesn't your dss2 driver support DMA rotation? It does. However, you should use DMA rotation only with OMAP2 when the framebuffer is in SRAM. It seems to work somewhat on OMAP3 and SDRAM, but I've noticed it doesn't always work. I don't know if lowering pixel clock, increasing dss fck or fiddling with fifo sizes could affect it. I am trying to add rotation feature for YUV2 image using VRFB to your dss2 driver. for this, I think that it have to change rot and mirror become 0 if rotation_type is OMAPFB_ROT_VRFB to be rot=ofbi-rotation and mirror = ofbi-mirror (in omapfb-main.c file) and add codes for calculating offset0, offset1, pixel increment and row increment value for YUV2 format also pixel size becomes 4 in YUV2 case (in dispc.c fild). omap_vrfb_setup function must be modifed also (in vrfb.c file)? Do you have any idea? No, I haven't really looked at YUV rotations. Tomi I need your help and advice. Thank you. - InKi- -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Tomi Valkeinen, I have some questions about dss2 driver.
I am using your dss2 driver downloaded from your git server and tried to rotate an image(RGB24U and YUV2 format) using OMAPFB_ROT_DMA command. but I can't see rotated image on screen. I added variables for rotating like below. as the result, LCD Panel is stoped. omapfb.rotate=2 omapfb.vrfb=n and then I tried again using OMAPFB_ROT_VRFB command like below. omapfb.rotate=2 omapfb.vrfb=y In this case, I can see rotated image(only RGB24U format) on screen. You asid Rotation and mirroring currently only supports RGB565 and RGB modes. VRFB does not support mirroring through /Documentation/arm/OMAP/DSS file. Doesn't your dss2 driver support DMA rotation? I am trying to add rotation feature for YUV2 image using VRFB to your dss2 driver. for this, I think that it have to change rot and mirror become 0 if rotation_type is OMAPFB_ROT_VRFB to be rot=ofbi-rotation and mirror = ofbi-mirror (in omapfb-main.c file) and add codes for calculating offset0, offset1, pixel increment and row increment value for YUV2 format also pixel size becomes 4 in YUV2 case (in dispc.c fild). omap_vrfb_setup function must be modifed also (in vrfb.c file)? Do you have any idea? I need your help and advice. Thank you. - InKi- -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Hello Tomi Valkeinen, I have some questions about dss2 driver.
Hi Dae, I am attaching one patch which adds the support of rotation on top of Tomi's DSS library. But this patch is created against the patches posted by tomi long back. You can have look at _dispc_calc_and_set_row_inc and _dispc_set_rotation_mirroring function for reference to add the YUV support. I have tested it with YUV, UYVY, RGB16 and RGB24u pixel format. Currently it supports pixel and row increment calculation only for rotation case. Thanks and Regards, Hardik Shah -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of InKi Dae Sent: Wednesday, March 11, 2009 10:28 AM To: Tomi Valkeinen Cc: linux-omap@vger.kernel.org Subject: Hello Tomi Valkeinen, I have some questions about dss2 driver. I am using your dss2 driver downloaded from your git server and tried to rotate an image(RGB24U and YUV2 format) using OMAPFB_ROT_DMA command. but I can't see rotated image on screen. I added variables for rotating like below. as the result, LCD Panel is stoped. omapfb.rotate=2 omapfb.vrfb=n and then I tried again using OMAPFB_ROT_VRFB command like below. omapfb.rotate=2 omapfb.vrfb=y In this case, I can see rotated image(only RGB24U format) on screen. You asid Rotation and mirroring currently only supports RGB565 and RGB modes. VRFB does not support mirroring through /Documentation/arm/OMAP/DSS file. Doesn't your dss2 driver support DMA rotation? I am trying to add rotation feature for YUV2 image using VRFB to your dss2 driver. for this, I think that it have to change rot and mirror become 0 if rotation_type is OMAPFB_ROT_VRFB to be rot=ofbi-rotation and mirror = ofbi-mirror (in omapfb-main.c file) and add codes for calculating offset0, offset1, pixel increment and row increment value for YUV2 format also pixel size becomes 4 in YUV2 case (in dispc.c fild). omap_vrfb_setup function must be modifed also (in vrfb.c file)? Do you have any idea? I need your help and advice. Thank you. - InKi- -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html 0002-Changes-Done-to-DSS-Library.patch Description: 0002-Changes-Done-to-DSS-Library.patch
Re: Hello Tomi Valkeinen. I wonder about future work plan for new Display Subsystem Driver.
On Fri, 2009-02-27 at 07:04 +0100, ext InKi Dae wrote: Your patch works fine on my system. This is good patch. Do you have plans that you will apply your patch to mainline and updating ? Yes, the work is ongoing. But it will take time, there is still lots to do. Tomi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Tomi Valkeinen. I wonder about future work plan for new Display Subsystem Driver.
Your patch works fine on my system. This is good patch. Do you have plans that you will apply your patch to mainline and updating ? Thank you. - Inki Dae- -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
