Is the OMAP patch process badly flawed?
I'm curious - I download, build and test kernels on x86 and x86_64 platforms, -rc, -rc-git and -git all build and run. On the OMAP platform I have so far not been able to do that with omap-git, omap-dss2-git trees and snapshots all missing basic hardware support, e.g:- I get the latest from gitorious.org, make omap3_beagle_defconfg, make xconfig, but there is no EHCI config available. I hunt down the patch and hand apply default y if ARCH_OMAP34XX to drivers/usb/Kconfig, next the build complains that drivers/usb/host/ehci-hcd.c: 1143:2: error: #error missing bus glue for ehci-hcd The bus glue patch ... ehci-omap.c no longer exists. --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -1108,6 +1108,11 @@ MODULE_LICENSE (GPL); #definePLATFORM_DRIVER ehci_hcd_au1xxx_driver #endif +#ifdef CONFIG_ARCH_OMAP34XX +#include ehci-omap.c +#definePLATFORM_DRIVER ehci_hcd_omap_driver +#endif + #ifdef CONFIG_PPC_PS3 #include ehci-ps3.c #definePS3_SYSTEM_BUS_DRIVER ps3_ehci_driver I would expect patches sent upstream would result in all the basics for long established platforms to be fully covered. Appreciating that development is quite fast paced with mods and supporting new platforms. Could someone please enlighten me? Regards Sid. -- Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support Specialist, Cricket Coach Microsoft Windows Free Zone - Linux used for all Computing Tasks -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Is the OMAP patch process badly flawed?
Sid Boyce wrote: I'm curious - I download, build and test kernels on x86 and x86_64 platforms, -rc, -rc-git and -git all build and run. On the OMAP platform I have so far not been able to do that with omap-git, omap-dss2-git trees and snapshots all missing basic hardware support, e.g:- I get the latest from gitorious.org, make omap3_beagle_defconfg, make xconfig, but there is no EHCI config available. I hunt down the patch and hand apply default y if ARCH_OMAP34XX to drivers/usb/Kconfig, next the build complains that drivers/usb/host/ehci-hcd.c: 1143:2: error: #error missing bus glue for ehci-hcd The bus glue patch ... ehci-omap.c no longer exists. --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -1108,6 +1108,11 @@ MODULE_LICENSE (GPL); #definePLATFORM_DRIVER ehci_hcd_au1xxx_driver #endif +#ifdef CONFIG_ARCH_OMAP34XX +#include ehci-omap.c +#definePLATFORM_DRIVER ehci_hcd_omap_driver +#endif + #ifdef CONFIG_PPC_PS3 #include ehci-ps3.c #definePS3_SYSTEM_BUS_DRIVER ps3_ehci_driver I would expect patches sent upstream would result in all the basics for long established platforms to be fully covered. Appreciating that development is quite fast paced with mods and supporting new platforms. Could someone please enlighten me? Sid, Speaking purely for EHCI, this is now queued up in Greg's USB queue for upstream and will get merged in the next cycle. Until then, the linux-omap code does have working EHCI support on beagle, evm and the other boards. If you're cloning from gitorious, you're probably picking the wrong tree. - Anand -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Is the OMAP patch process badly flawed?
On 17/11/09 13:34, Gadiyar, Anand wrote: Sid Boyce wrote: I'm curious - I download, build and test kernels on x86 and x86_64 platforms, -rc, -rc-git and -git all build and run. On the OMAP platform I have so far not been able to do that with omap-git, omap-dss2-git trees and snapshots all missing basic hardware support, e.g:- I get the latest from gitorious.org, make omap3_beagle_defconfg, make xconfig, but there is no EHCI config available. I hunt down the patch and hand apply default y if ARCH_OMAP34XX to drivers/usb/Kconfig, next the build complains that drivers/usb/host/ehci-hcd.c: 1143:2: error: #error missing bus glue for ehci-hcd The bus glue patch ... ehci-omap.c no longer exists. --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -1108,6 +1108,11 @@ MODULE_LICENSE (GPL); #definePLATFORM_DRIVER ehci_hcd_au1xxx_driver #endif +#ifdef CONFIG_ARCH_OMAP34XX +#include ehci-omap.c +#definePLATFORM_DRIVER ehci_hcd_omap_driver +#endif + #ifdef CONFIG_PPC_PS3 #include ehci-ps3.c #definePS3_SYSTEM_BUS_DRIVER ps3_ehci_driver I would expect patches sent upstream would result in all the basics for long established platforms to be fully covered. Appreciating that development is quite fast paced with mods and supporting new platforms. Could someone please enlighten me? Sid, Speaking purely for EHCI, this is now queued up in Greg's USB queue for upstream and will get merged in the next cycle. Until then, the linux-omap code does have working EHCI support on beagle, evm and the other boards. If you're cloning from gitorious, you're probably picking the wrong tree. - Anand Thanks, that explains a lot as I can't remember seeing those patches on the linux-usb list for submission upstream. What tree is best to clone? Regards Sid. -- Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support Specialist, Cricket Coach Microsoft Windows Free Zone - Linux used for all Computing Tasks -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Is the OMAP patch process badly flawed?
Sid Boyce wrote: snip I would expect patches sent upstream would result in all the basics for long established platforms to be fully covered. Appreciating that development is quite fast paced with mods and supporting new platforms. Could someone please enlighten me? Sid, Speaking purely for EHCI, this is now queued up in Greg's USB queue for upstream and will get merged in the next cycle. Until then, the linux-omap code does have working EHCI support on beagle, evm and the other boards. If you're cloning from gitorious, you're probably picking the wrong tree. - Anand Thanks, that explains a lot as I can't remember seeing those patches on the linux-usb list for submission upstream. What tree is best to clone? Not sure which is best - I suppose that depends on what all you need. The canonical linux-omap tree maintained by Tony is at [1]. For EHCI, Felipe sent the driver to Greg who queued it up for .33 [2]. Tony lined up the board files and mach-omap2/usb-ehci.c in the for-next branch. [1] git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git [2] http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-07-usb-2.6.32-rc6.patch -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Is the OMAP patch process badly flawed?
On 17/11/09 14:51, Gadiyar, Anand wrote: Sid Boyce wrote: snip I would expect patches sent upstream would result in all the basics for long established platforms to be fully covered. Appreciating that development is quite fast paced with mods and supporting new platforms. Could someone please enlighten me? Sid, Speaking purely for EHCI, this is now queued up in Greg's USB queue for upstream and will get merged in the next cycle. Until then, the linux-omap code does have working EHCI support on beagle, evm and the other boards. If you're cloning from gitorious, you're probably picking the wrong tree. - Anand Thanks, that explains a lot as I can't remember seeing those patches on the linux-usb list for submission upstream. What tree is best to clone? Not sure which is best - I suppose that depends on what all you need. The canonical linux-omap tree maintained by Tony is at [1]. For EHCI, Felipe sent the driver to Greg who queued it up for .33 [2]. Tony lined up the board files and mach-omap2/usb-ehci.c in the for-next branch. [1] git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git [2] http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-07-usb-2.6.32-rc6.patch Thanks for the update and the patch. I downloaded the launchpad 2.6.31 kernel which I have currently running. Finally found one that outputs to the LCD. Regards Sid. -- Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support Specialist, Cricket Coach Microsoft Windows Free Zone - Linux used for all Computing Tasks -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Is the OMAP patch process badly flawed?
On Tue, Nov 17, 2009 at 3:30 PM, Sid Boyce sbo...@blueyonder.co.uk wrote: I'm curious - I download, build and test kernels on x86 and x86_64 platforms, -rc, -rc-git and -git all build and run. [...] I would expect patches sent upstream would result in all the basics for long established platforms to be fully covered. Appreciating that development is quite fast paced with mods and supporting new platforms. Could someone please enlighten me? Previously all the linux-omap work had to be queued through the linux-arm tree, that made it a bit difficult to push things to the mainline, but now Tony is sending the pull requests directly to Linus, so maybe kernels post 2.6.32 will be much better. However, the only way to make sure that there's good OMAP support in Linux is for the community to actively test the mainline and make sure the patches are properly pushed and queued, and regressions are found quickly, not only on the linux-omap tree, but linux-usb, fbdev, etc. Unfortunately we haven't done such a great job on that, perhaps because many people use old stable aka frozen kernels, but things are improving. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
