Re: Patch to fix swapping of front and back porches when reading from modedb.c

2010-09-09 Thread Tomi Valkeinen 
On Wed, 2010-09-08 at 15:38 +0200, ext Russ Dill wrote:
 On Wed, Sep 8, 2010 at 6:39 AM, Tasslehoff Kjappfot tasskj...@gmail.com 
 wrote:
 
 
  Hi list :-)
 
  I had trouble getting a standard 800x...@60hz VGA signal to display
  correctly on my monitors. Measuring the output showed that the front and
  back porches were swapped both for hsync and vsync. After reading the source
  I think I found the error in drivers/video/omap2/omapfb/omapfb-main.c. Patch
  attached.
 
  http://www.xfree86.org/3.3.6/fbdev6.html shows the way it should be, but
  todays code sets:
 
  hfp = left margin
  hbp = right margin
  vfp = upper margin
  vbp = lower margin
 
  I tested a patched kernel with 800x...@60hz on two different monitors and a
  vga grabber, and it solved my issues.
 
 This looks good. Before this came up, I also thought that front porch
 meant left margin, and back porch meant margin, but margins are named
 in relation to pixel data, and porches are named in relation to sync
 pulses.

Ah, that's new to me too =). After a few minutes of googling, it's quite
clear that the patch is correct.

Thanks! I improved the patch description a bit, and added it to my tree.

 Tomi


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Patch to fix swapping of front and back porches when reading from modedb.c

2010-09-08 Thread Russ Dill 
On Wed, Sep 8, 2010 at 6:39 AM, Tasslehoff Kjappfot tasskj...@gmail.com wrote:


 Hi list :-)

 I had trouble getting a standard 800x...@60hz VGA signal to display
 correctly on my monitors. Measuring the output showed that the front and
 back porches were swapped both for hsync and vsync. After reading the source
 I think I found the error in drivers/video/omap2/omapfb/omapfb-main.c. Patch
 attached.

 http://www.xfree86.org/3.3.6/fbdev6.html shows the way it should be, but
 todays code sets:

 hfp = left margin
 hbp = right margin
 vfp = upper margin
 vbp = lower margin

 I tested a patched kernel with 800x...@60hz on two different monitors and a
 vga grabber, and it solved my issues.

This looks good. Before this came up, I also thought that front porch
meant left margin, and back porch meant margin, but margins are named
in relation to pixel data, and porches are named in relation to sync
pulses.

You might want to add a Signed-off-by line

Reviewed-by: russ.d...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html