Re: [PATCH] ARM: OMAP2+: Fix selection of clockevent timer when using device-tree
* Jon Hunter [130130 09:54]: > > On 01/30/2013 01:18 AM, Bedia, Vaibhav wrote: > > On Wed, Jan 30, 2013 at 01:53:11, Hunter, Jon wrote: > >> Commit 9725f44 (ARM: OMAP: Add DT support for timer driver) added > >> device-tree support for selecting a clockevent timer by property. > >> However, the code is currently ignoring the property passed and > >> selecting the first available timer found. Hence, for the OMAP3 beagle > >> board timer-12 is not being selected as expected. Fix this problem > >> by ensuring the timer property is passed to omap_get_timer_dt(). > > > > I thought that was intentional ;) and had this change in the clkevt-clksrc > > interchange patch for AM33xx. > > No definitely was not. Thanks, I had missed that detail in the patch you > sent! > > > Anyways, this change works for me so... > > > > Tested-by: Vaibhav Bedia > > Thanks! Thanks applying into omap-for-v3.9/fixes-non-critical. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: OMAP2+: Fix selection of clockevent timer when using device-tree
On 01/30/2013 01:18 AM, Bedia, Vaibhav wrote: > On Wed, Jan 30, 2013 at 01:53:11, Hunter, Jon wrote: >> Commit 9725f44 (ARM: OMAP: Add DT support for timer driver) added >> device-tree support for selecting a clockevent timer by property. >> However, the code is currently ignoring the property passed and >> selecting the first available timer found. Hence, for the OMAP3 beagle >> board timer-12 is not being selected as expected. Fix this problem >> by ensuring the timer property is passed to omap_get_timer_dt(). > > I thought that was intentional ;) and had this change in the clkevt-clksrc > interchange patch for AM33xx. No definitely was not. Thanks, I had missed that detail in the patch you sent! > Anyways, this change works for me so... > > Tested-by: Vaibhav Bedia Thanks! Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: OMAP2+: Fix selection of clockevent timer when using device-tree
On Wed, Jan 30, 2013 at 01:53:11, Hunter, Jon wrote: > Commit 9725f44 (ARM: OMAP: Add DT support for timer driver) added > device-tree support for selecting a clockevent timer by property. > However, the code is currently ignoring the property passed and > selecting the first available timer found. Hence, for the OMAP3 beagle > board timer-12 is not being selected as expected. Fix this problem > by ensuring the timer property is passed to omap_get_timer_dt(). I thought that was intentional ;) and had this change in the clkevt-clksrc interchange patch for AM33xx. Anyways, this change works for me so... Tested-by: Vaibhav Bedia -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: OMAP2+: Fix selection of clockevent timer when using device-tree
On Wednesday 30 January 2013 01:53 AM, Jon Hunter wrote: Commit 9725f44 (ARM: OMAP: Add DT support for timer driver) added device-tree support for selecting a clockevent timer by property. However, the code is currently ignoring the property passed and selecting the first available timer found. Hence, for the OMAP3 beagle board timer-12 is not being selected as expected. Fix this problem by ensuring the timer property is passed to omap_get_timer_dt(). Signed-off-by: Jon Hunter --- Acked-by: Santosh Shilimkar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
