Re: [PATCH] ARM: OMAP2: fix mailbox init code
Hi, On Thu, Feb 23, 2012 at 3:18 AM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: On Thu, Feb 23, 2012 at 14:23:35, Ohad Ben-Cohen wrote: [...] Which happens on CONFIG_ARCH_OMAP2 !CONFIG_SOC_OMAP2420, due to missing omap2_mboxes declaration. [...] -struct omap_mbox *omap2_mboxes[] = { mbox_dsp_info, mbox_iva_info, NULL }; +#ifdef CONFIG_ARCH_OMAP2 +struct omap_mbox *omap2_mboxes[] = { + mbox_dsp_info, +#ifdef CONFIG_SOC_OMAP2420 + mbox_iva_info, +#endif + NULL +}; #endif #if defined(CONFIG_ARCH_OMAP4) Instead of adding more #ifs can they be completely removed please? I'll rebase/repost this series: [PATCH 0/7] OMAP: mailbox: removing static declarations http://comments.gmane.org/gmane.linux.ports.arm.omap/59620 In the meantime I would appreciate comments. Regards, Omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: OMAP2: fix mailbox init code
On Thu, Feb 23, 2012 at 11:18 AM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: Instead of adding more #ifs can they be completely removed please? Care to propose something specific (which is viable for the -rc cycle) ? Thanks, Ohad. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: OMAP2: fix mailbox init code
* Ohad Ben-Cohen o...@wizery.com [120223 08:32]: On Thu, Feb 23, 2012 at 11:18 AM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: Instead of adding more #ifs can they be completely removed please? Care to propose something specific (which is viable for the -rc cycle) ? This is pretty much the minimal change for -rc cycle so I'll apply this into fixes. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: OMAP2: fix mailbox init code
On Thu, Feb 23, 2012 at 14:23:35, Ohad Ben-Cohen wrote: [...] Which happens on CONFIG_ARCH_OMAP2 !CONFIG_SOC_OMAP2420, due to missing omap2_mboxes declaration. [...] -struct omap_mbox *omap2_mboxes[] = { mbox_dsp_info, mbox_iva_info, NULL }; +#ifdef CONFIG_ARCH_OMAP2 +struct omap_mbox *omap2_mboxes[] = { + mbox_dsp_info, +#ifdef CONFIG_SOC_OMAP2420 + mbox_iva_info, +#endif + NULL +}; #endif #if defined(CONFIG_ARCH_OMAP4) Instead of adding more #ifs can they be completely removed please? -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html