Re: [PATCH] DSPBRIDGE: replace init_timer with init_timer_on_stack

2010-01-20 Thread Ameya Palande 
On Wed, 2010-01-20 at 01:45 +0100, ext Nishanth Menon wrote:
 With LOCK_DEP enabled and DEBUG_OBJECTS_TIMERS, DSPBridge
 SYNC_WaitOnMultipleEvents will fail with message
 ODEBUG: object is on stack, but not annotated
 since the timeout timer is on the stack, we should rightly use
 init_timer_on_stack.
 
 Cc: Ameya Palande ameya.pala...@nokia.com
 Cc: Deepak Chitriki deepak.chitr...@ti.com
 Cc: Felipe Contreras felipe.contre...@nokia.com
 Cc: Hiroshi Doyu hiroshi.d...@nokia.com
 Cc: Omar Ramirez Luna omar.rami...@ti.com
 
 Signed-off-by: Nishanth Menon n...@ti.com
 ---
  drivers/dsp/bridge/services/sync.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/drivers/dsp/bridge/services/sync.c 
 b/drivers/dsp/bridge/services/sync.c
 index c2d79c7..d246656 100644
 --- a/drivers/dsp/bridge/services/sync.c
 +++ b/drivers/dsp/bridge/services/sync.c
 @@ -330,7 +330,7 @@ DSP_STATUS SYNC_WaitOnMultipleEvents(struct SYNC_OBJECT 
 **hSyncEvents,
   if (Wp-state != wo_signalled  dwTimeout  0) {
   struct timer_list timeout;
   if (dwTimeout != SYNC_INFINITE) {
 - init_timer(timeout);
 + init_timer_on_stack(timeout);
   timeout.function = timeout_callback;
   timeout.data = (unsigned long)Wp;
   timeout.expires = jiffies + dwTimeout * HZ / 1000;

Acked-by: Ameya Palande ameya.pala...@nokia.com

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] DSPBRIDGE: replace init_timer with init_timer_on_stack

2010-01-20 Thread Ramirez Luna, Omar 
From: Ameya Palande on Wednesday, January 20, 2010 3:55 AM

On Wed, 2010-01-20 at 01:45 +0100, ext Nishanth Menon wrote:
 With LOCK_DEP enabled and DEBUG_OBJECTS_TIMERS, DSPBridge
 SYNC_WaitOnMultipleEvents will fail with message
 ODEBUG: object is on stack, but not annotated
 since the timeout timer is on the stack, we should rightly use
 init_timer_on_stack.

 Cc: Ameya Palande ameya.pala...@nokia.com
 Cc: Deepak Chitriki deepak.chitr...@ti.com
 Cc: Felipe Contreras felipe.contre...@nokia.com
 Cc: Hiroshi Doyu hiroshi.d...@nokia.com
 Cc: Omar Ramirez Luna omar.rami...@ti.com

 Signed-off-by: Nishanth Menon n...@ti.com
 ---
  drivers/dsp/bridge/services/sync.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

 diff --git a/drivers/dsp/bridge/services/sync.c 
 b/drivers/dsp/bridge/services/sync.c
 index c2d79c7..d246656 100644
 --- a/drivers/dsp/bridge/services/sync.c
 +++ b/drivers/dsp/bridge/services/sync.c
 @@ -330,7 +330,7 @@ DSP_STATUS SYNC_WaitOnMultipleEvents(struct SYNC_OBJECT 
 **hSyncEvents,
  if (Wp-state != wo_signalled  dwTimeout  0) {
  struct timer_list timeout;
  if (dwTimeout != SYNC_INFINITE) {
 -init_timer(timeout);
 +init_timer_on_stack(timeout);
  timeout.function = timeout_callback;
  timeout.data = (unsigned long)Wp;
  timeout.expires = jiffies + dwTimeout * HZ / 1000;

Acked-by: Ameya Palande ameya.pala...@nokia.com

Pushed to dspbridge

- omar
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html