Hi Vishwa,
Thanks for your review
-Original Message-
From: Sripathy, Vishwanath
Sent: Saturday, October 30, 2010 12:35 AM
To: Datta, Shubhrajyoti; linux-omap@vger.kernel.org
Cc: Pandita, Vikram; ABRAHAM, KISHON VIJAY
Subject: RE: [PATCH] McBSP: Fix the free variable update at remove.
Shubro,
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Datta, Shubhrajyoti
Sent: Friday, October 29, 2010 4:19 AM
To: linux-omap@vger.kernel.org
Cc: Pandita, Vikram; Datta, Shubhrajyoti; ABRAHAM, KISHON VIJAY
Subject: [PATCH] McBSP: Fix the free variable update at remove.
From: Shubhrajyoti D shubhrajy...@ti.com
At remove the free variable is wrongly updated.Attempting to solve the
same.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Reported-by: Vikram Pandita vikram.pand...@ti.com
---
arch/arm/plat-omap/mcbsp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index eac4b97..6802ed1 100644
--- a/arch/arm/plat-omap/mcbsp.c
+++ b/arch/arm/plat-omap/mcbsp.c
@@ -1845,7 +1845,7 @@ static int __devexit
omap_mcbsp_remove(struct platform_device *pdev)
mcbsp-fclk = NULL;
mcbsp-iclk = NULL;
- mcbsp-free = 0;
+ mcbsp-free = 1;
Isn't it better to use TRUE/FALSE instead of 1/0 if it's a Boolean
variable?
Addressed it in the v2. Thanks.
Vishwa
mcbsp-dev = NULL;
}
--
1.7.0.4
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
