RE: [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes

2014-07-01 Thread Gupta, Pekon
From: Ezequiel García [mailto:ezequ...@vanguardiasur.com.ar]
On 26 Jun 12:02 PM, Guido Martínez wrote:
 Currently, child nodes of the gpmc node are iterated and probed
 regardless of their 'status' property. This means adding 'status =
 disabled;' has no effect.

 This patch changes the iteration to only probe nodes marked as
 available.

 Signed-off-by: Guido Martínez gu...@vanguardiasur.com.ar

Just a nit: the commit title doesn't match the recent commits. If you
run git log on this file, you'll find the pattern should be something
like:

ARM: OMAP2+: GPMC should only probe enabled devices

Other than this, the patch looks correct.

Yes, plz keep patch title consistent as in other gpmc.c patches.
And thanks for this fix.

Tested-by: Pekon Gupta pe...@ti.com

with regards, pekon
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes

2014-06-26 Thread Ezequiel García
On 26 Jun 12:02 PM, Guido Martínez wrote:
 Currently, child nodes of the gpmc node are iterated and probed
 regardless of their 'status' property. This means adding 'status =
 disabled;' has no effect.
 
 This patch changes the iteration to only probe nodes marked as
 available.
 
 Signed-off-by: Guido Martínez gu...@vanguardiasur.com.ar

Just a nit: the commit title doesn't match the recent commits. If you
run git log on this file, you'll find the pattern should be something
like:

ARM: OMAP2+: GPMC should only probe enabled devices

Other than this, the patch looks correct.

Thanks,
-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html