Re: [PATCH 0/8] musb: Add structure 'musb_hdrc_board_data'

2009-11-18 Thread Sergei Shtylyov 

Hello.

Ajay Kumar Gupta wrote:


This patch set adds a new structure 'musb_hdrc_board_data' to get all
board specific data from board files.



It is actually done to accomodate ULPI_VBUSCONTROL programming required
for OMAP3EVM Rev =E which uses external Vbus supply to support 500mA.


   It's not clear why it was necessary to create yet another structure. You 
could your new field to 'struct musb_hdrc_platfrom_data'...



Regards,
Ajay


WBR, Sergei
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 0/8] musb: Add structure 'musb_hdrc_board_data'

2009-11-18 Thread Gupta, Ajay Kumar 
Hi,
 -Original Message-
 From: Sergei Shtylyov [mailto:sshtyl...@ru.mvista.com] 
 Sent: Wednesday, November 18, 2009 7:50 PM
 To: Gupta, Ajay Kumar
 Cc: linux-...@vger.kernel.org; 
 davinci-linux-open-sou...@linux.davincidsp.com; 
 coolo...@kernel.org; felipe.ba...@nokia.com; 
 linux-omap@vger.kernel.org; Gadiyar, Anand
 Subject: Re: [PATCH 0/8] musb: Add structure 'musb_hdrc_board_data'
 
 Hello.
 
 Ajay Kumar Gupta wrote:
 
  This patch set adds a new structure 'musb_hdrc_board_data' 
 to get all 
  board specific data from board files.
 
  It is actually done to accomodate ULPI_VBUSCONTROL programming 
  required for OMAP3EVM Rev =E which uses external Vbus 
 supply to support 500mA.
 
 It's not clear why it was necessary to create yet another 
 structure. You could your new field to 'struct 
 musb_hdrc_platfrom_data'...

This a actually a simpler approach and would avoid changing Davinci/BLackFin
Specific files.

Felipe/Anand,
Is it ok to add 'extvbus' in 'musb_hdrc_platform_data' and pass this data
from all OMAP board files. 

Anyways we do have 'musb_config' which has all platform sepecific information.

-Ajay
 
  Regards,
  Ajay
 
 WBR, Sergei
 
 --
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html