RE: [PATCH 3/8] ARM: OMAP: AM33xx hwmod: Add parent-child relationship for PWM subsystem

2012-11-06 Thread Bedia, Vaibhav
On Mon, Nov 05, 2012 at 14:42:24, Philip, Avinash wrote:
[...]

 +
 +static struct omap_hwmod_ocp_if am33xx_epwmss0__ecap0 = {
 + .master = am33xx_epwmss0_hwmod,
 + .slave  = am33xx_ecap0_hwmod,
 + .clk= l4ls_gclk,
 + .addr   = am33xx_ecap0_addr_space,
 + .user   = OCP_USER_MPU,
 +};

Noticed this in another patch which is quite similar so commenting here
again. Is the user field required if you are just creating a parent-child
relationship here?

Regards,
Vaibhav 

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH 3/8] ARM: OMAP: AM33xx hwmod: Add parent-child relationship for PWM subsystem

2012-11-06 Thread Hiremath, Vaibhav
On Tue, Nov 06, 2012 at 15:39:11, Bedia, Vaibhav wrote:
 On Mon, Nov 05, 2012 at 14:42:24, Philip, Avinash wrote:
 [...]
 
  +
  +static struct omap_hwmod_ocp_if am33xx_epwmss0__ecap0 = {
  +   .master = am33xx_epwmss0_hwmod,
  +   .slave  = am33xx_ecap0_hwmod,
  +   .clk= l4ls_gclk,
  +   .addr   = am33xx_ecap0_addr_space,
  +   .user   = OCP_USER_MPU,
  +};
 
 Noticed this in another patch which is quite similar so commenting here
 again. Is the user field required if you are just creating a parent-child
 relationship here?
 

I think user field is not related to parent-child nodes, it defines the 
initiator to interact with hwmod

Copy-pasted from arch/arm/plat-omap/include/plat/omap_hwmod.h

indicate the initiators that use this interface to interact with the 
hwmod

And in this case, its MPU is the initiator to interact with this interface.


Thanks,
Vaibhav
 Regards,
 Vaibhav 
 
 

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html