Re: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to driver
Hello Senthil,
On Wed, 6 Oct 2010 16:44:55 +0530
Guruswamy Senthilvadivu wrote:
> static struct {
> + struct platform_device *pdev;
> void __iomem*base;
>
> u32 fifo_size[3];
> @@ -189,11 +190,22 @@ static inline u32 dispc_read_reg(const struct dispc_reg
> idx)
> /* DISPC HW IP initialisation */
> static int omap_dispchw_probe(struct platform_device *pdev)
> {
> - return 0;
> + int r;
> + dispc.pdev = pdev;
> +
> + r = dispc_init();
> + if (r) {
> + DSSERR("Failed to initialize dispc\n");
> + goto err_dispc;
> + }
> +
> +err_dispc:
> + return r;
> }
>
> static int omap_dispchw_remove(struct platform_device *pdev)
> {
> + dispc_exit();
> return 0;
> }
Same comments than the one for the patch on the RFBI driver.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to driver
On 10/7/2010 10:44 AM, Guruswamy, Senthilvadivu wrote: From: Cousson, Benoit Sent: Thursday, October 07, 2010 12:47 PM Hi Senthil, On 10/7/2010 8:16 AM, Guruswamy, Senthilvadivu wrote: From: Premi, Sanjeev From: linux-omap-ow...@vger.kernel.org From: Senthilvadivu Guruswamy Move init exit methods to its driver probe,remove. pdev member has to be maintained by its own drivers. [sp] How is this change related to hwmod mentioned in the subject line? [Senthil] As part of the hwmod design, dispc is made as platform driver. Hence the dispc_init and dispc_exit has to be moved from core "omapdisplay" Driver to "dss_dispc" platform driver. Pdev is the platform device structure maintained in dss_dispc driver containing silicon specific info like baseaddr, irqs of DISPC HW. It is still not a reason to put hwmod in the subject. That is valid for most patches of this series. You have to put the plaform name then the subsystem if this is related to the OMAP arch directory, which is DSS, not hwmod DSS. In the case of DSS driver changes, then you should start with video: DSS:, or maybe DSS is enough if there is no possible confusion. The goal of that is just to highlight in the subject what part of the kernel you are changing, since the maintainers are not necessarily the same. [Senthil] If "hwmod" is creating confusion, it could be removed. Is it an ack for this patch series considering that "change in the header" is the only comment to be incorporated? Mmm, not really, but since it is the subject, this is the very first things you see. That why it is important to provide good subject :-) I'll have a look at this series before the end of the week. Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to driver
> -Original Message- > From: Cousson, Benoit > Sent: Thursday, October 07, 2010 12:47 PM > > Hi Senthil, > > On 10/7/2010 8:16 AM, Guruswamy, Senthilvadivu wrote: > > > >> From: Premi, Sanjeev > >> > >>> From: linux-omap-ow...@vger.kernel.org > >>> > >>> From: Senthilvadivu Guruswamy > >>> > >>> Move init exit methods to its driver probe,remove. > >>> pdev member has to be maintained by its own drivers. > >> > >> [sp] How is this change related to hwmod mentioned in the > >> subject line? > > [Senthil] As part of the hwmod design, dispc is made as platform driver. > > Hence the dispc_init and dispc_exit has to be moved from core > "omapdisplay" > > Driver to "dss_dispc" platform driver. Pdev is the platform device > structure maintained in dss_dispc driver containing silicon specific info > like baseaddr, irqs of DISPC HW. > > It is still not a reason to put hwmod in the subject. That is valid for > most patches of this series. > You have to put the plaform name then the subsystem if this is related > to the OMAP arch directory, which is DSS, not hwmod DSS. > > In the case of DSS driver changes, then you should start with video: > DSS:, or maybe DSS is enough if there is no possible confusion. > > The goal of that is just to highlight in the subject what part of the > kernel you are changing, since the maintainers are not necessarily the > same. [Senthil] If "hwmod" is creating confusion, it could be removed. Is it an ack for this patch series considering that "change in the header" is the only comment to be incorporated? > Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to driver
Hi Senthil, On 10/7/2010 8:16 AM, Guruswamy, Senthilvadivu wrote: From: Premi, Sanjeev Sent: Wednesday, October 06, 2010 7:49 PM To: Guruswamy, Senthilvadivu; khil...@deeprootsystems.com; tomi.valkei...@nokia.com; p...@pwsan.com; Hiremath, Vaibhav; linux- o...@vger.kernel.org Subject: RE: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to driver From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Guruswamy, Senthilvadivu Sent: Wednesday, October 06, 2010 4:45 PM To: khil...@deeprootsystems.com; tomi.valkei...@nokia.com; p...@pwsan.com; Hiremath, Vaibhav; linux-omap@vger.kernel.org Cc: Guruswamy, Senthilvadivu Subject: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to driver From: Senthilvadivu Guruswamy Move init exit methods to its driver probe,remove. pdev member has to be maintained by its own drivers. [sp] How is this change related to hwmod mentioned in the subject line? [Senthil] As part of the hwmod design, dispc is made as platform driver. Hence the dispc_init and dispc_exit has to be moved from core "omapdisplay" Driver to "dss_dispc" platform driver. Pdev is the platform device structure maintained in dss_dispc driver containing silicon specific info like baseaddr, irqs of DISPC HW. It is still not a reason to put hwmod in the subject. That is valid for most patches of this series. You have to put the plaform name then the subsystem if this is related to the OMAP arch directory, which is DSS, not hwmod DSS. In the case of DSS driver changes, then you should start with video: DSS:, or maybe DSS is enough if there is no possible confusion. The goal of that is just to highlight in the subject what part of the kernel you are changing, since the maintainers are not necessarily the same. Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to driver
> -Original Message- > From: Premi, Sanjeev > Sent: Wednesday, October 06, 2010 7:49 PM > To: Guruswamy, Senthilvadivu; khil...@deeprootsystems.com; > tomi.valkei...@nokia.com; p...@pwsan.com; Hiremath, Vaibhav; linux- > o...@vger.kernel.org > Subject: RE: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to > driver > > > -Original Message- > > From: linux-omap-ow...@vger.kernel.org > > [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of > > Guruswamy, Senthilvadivu > > Sent: Wednesday, October 06, 2010 4:45 PM > > To: khil...@deeprootsystems.com; tomi.valkei...@nokia.com; > > p...@pwsan.com; Hiremath, Vaibhav; linux-omap@vger.kernel.org > > Cc: Guruswamy, Senthilvadivu > > Subject: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move > > init,exit to driver > > > > From: Senthilvadivu Guruswamy > > > > Move init exit methods to its driver probe,remove. > > pdev member has to be maintained by its own drivers. > > [sp] How is this change related to hwmod mentioned in the > subject line? [Senthil] As part of the hwmod design, dispc is made as platform driver. Hence the dispc_init and dispc_exit has to be moved from core "omapdisplay" Driver to "dss_dispc" platform driver. Pdev is the platform device structure maintained in dss_dispc driver containing silicon specific info like baseaddr, irqs of DISPC HW. > ~sanjeev > > [snip]...[snip] -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to driver
> -Original Message- > From: linux-omap-ow...@vger.kernel.org > [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of > Guruswamy, Senthilvadivu > Sent: Wednesday, October 06, 2010 4:45 PM > To: khil...@deeprootsystems.com; tomi.valkei...@nokia.com; > p...@pwsan.com; Hiremath, Vaibhav; linux-omap@vger.kernel.org > Cc: Guruswamy, Senthilvadivu > Subject: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move > init,exit to driver > > From: Senthilvadivu Guruswamy > > Move init exit methods to its driver probe,remove. > pdev member has to be maintained by its own drivers. [sp] How is this change related to hwmod mentioned in the subject line? ~sanjeev [snip]...[snip] -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
