Re: [PATCH v2 8/9] ARM: DTS: AM33XX: Add nodes for OCMC RAM and WKUP-M3

2013-01-29 Thread Peter Korsgaard 
 Vaibhav == Vaibhav Bedia vaibhav.be...@ti.com writes:

 Vaibhav Since AM33XX supports only DT-boot, this is needed
 Vaibhav for the appropriate device nodes to be created.

 Vaibhav Note: OCMC RAM is part of the PER power domain and supports
 Vaibhav retention. The assembly code for low power entry/exit will
 Vaibhav run from OCMC RAM. To ensure that the OMAP PM code does not
 Vaibhav attempt to disable the clock to OCMC RAM as part of the
 Vaibhav suspend process add the no_idle_on_suspend flag.

 Vaibhav Signed-off-by: Vaibhav Bedia vaibhav.be...@ti.com
 Vaibhav Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
 Vaibhav ---
 Vaibhav v2: Add reg property

 Vaibhav  arch/arm/boot/dts/am33xx.dtsi | 14 +
 Vaibhav  1 file changed, 14 insertions(+)

 Vaibhav diff --git a/arch/arm/boot/dts/am33xx.dtsi 
b/arch/arm/boot/dts/am33xx.dtsi
 Vaibhav index c2f14e8..423f898 100644
 Vaibhav --- a/arch/arm/boot/dts/am33xx.dtsi
 Vaibhav +++ b/arch/arm/boot/dts/am33xx.dtsi
 Vaibhav @@ -385,5 +385,19 @@
 Vaibhav   mac-address = [ 00 00 00 00 00 00 ];
 Vaibhav   };
 Vaibhav   };
 Vaibhav +
 Vaibhav + ocmcram: ocmcram@4030 {
 Vaibhav + compatible = ti,ocmcram;
 Vaibhav + reg = 0x4030 0x1;
 Vaibhav + ti,hwmods = ocmcram;
 Vaibhav + ti,no_idle_on_suspend;
 Vaibhav + };
 Vaibhav +
 Vaibhav + wkup_m3: wkup_m3@44d0 {
 Vaibhav + compatible = ti,wkup_m3;


Both of these compatible properties should probably use less generic
names, like:

ti,am3352-ocmcram
ti,am3352-wkup-m3 ('-' instead of '_')

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 8/9] ARM: DTS: AM33XX: Add nodes for OCMC RAM and WKUP-M3

2013-01-29 Thread Bedia, Vaibhav 
On Tue, Jan 29, 2013 at 13:50:44, Peter Korsgaard wrote:
  Vaibhav == Vaibhav Bedia vaibhav.be...@ti.com writes:
 
  Vaibhav Since AM33XX supports only DT-boot, this is needed
  Vaibhav for the appropriate device nodes to be created.
 
  Vaibhav Note: OCMC RAM is part of the PER power domain and supports
  Vaibhav retention. The assembly code for low power entry/exit will
  Vaibhav run from OCMC RAM. To ensure that the OMAP PM code does not
  Vaibhav attempt to disable the clock to OCMC RAM as part of the
  Vaibhav suspend process add the no_idle_on_suspend flag.
 
  Vaibhav Signed-off-by: Vaibhav Bedia vaibhav.be...@ti.com
  Vaibhav Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
  Vaibhav ---
  Vaibhav v2: Add reg property
 
  Vaibhav  arch/arm/boot/dts/am33xx.dtsi | 14 +
  Vaibhav  1 file changed, 14 insertions(+)
 
  Vaibhav diff --git a/arch/arm/boot/dts/am33xx.dtsi 
 b/arch/arm/boot/dts/am33xx.dtsi
  Vaibhav index c2f14e8..423f898 100644
  Vaibhav --- a/arch/arm/boot/dts/am33xx.dtsi
  Vaibhav +++ b/arch/arm/boot/dts/am33xx.dtsi
  Vaibhav @@ -385,5 +385,19 @@
  Vaibhav mac-address = [ 00 00 00 00 00 00 ];
  Vaibhav };
  Vaibhav };
  Vaibhav +
  Vaibhav +   ocmcram: ocmcram@4030 {
  Vaibhav +   compatible = ti,ocmcram;
  Vaibhav +   reg = 0x4030 0x1;
  Vaibhav +   ti,hwmods = ocmcram;
  Vaibhav +   ti,no_idle_on_suspend;
  Vaibhav +   };
  Vaibhav +
  Vaibhav +   wkup_m3: wkup_m3@44d0 {
  Vaibhav +   compatible = ti,wkup_m3;
 
 
 Both of these compatible properties should probably use less generic
 names, like:
 
 ti,am3352-ocmcram
 ti,am3352-wkup-m3 ('-' instead of '_')
 

Ok. Will do.

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html