RE: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation
From: Tony Lindgren [t...@atomide.com]
Sent: Wednesday, October 31, 2012 11:59 PM
To: Munegowda, Keshava
Cc: linux-omap@vger.kernel.org; devicetree-disc...@lists.ozlabs.org;
linux-...@vger.kernel.org; linux-...@vger.kernel.org; Balbi, Felipe;
sa...@linux.intel.com; Cousson, Benoit
Subject: Re: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree
node Adaptation
* Keshava Munegowda keshava_mgo...@ti.com [121031 07:29]:
The USB2 Host device node is extracted and used in the probe
of the driver to initialize the usb ports and controller. The
platform specific initialization is also performed.
Signed-off-by: Keshava Munegowda keshava_mgo...@ti.com
---
arch/arm/mach-omap2/usb-host.c |2 -
drivers/mfd/omap-usb-host.c| 163
+++-
include/linux/platform_data/usb-omap.h | 19 +++-
3 files changed, 133 insertions(+), 51 deletions(-)
diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
index d1dbe12..239c175 100644
--- a/arch/arm/mach-omap2/usb-host.c
+++ b/arch/arm/mach-omap2/usb-host.c
@@ -502,8 +502,6 @@ void __init usbhs_init(const struct usbhs_omap_board_data
*pdata)
}
ehci_data.phy_reset = pdata-phy_reset;
ohci_data.es2_compatibility = pdata-es2_compatibility;
- usbhs_data.ehci_data = ehci_data;
- usbhs_data.ohci_data = ohci_data;
if (cpu_is_omap34xx()) {
setup_ehci_io_mux(pdata-port_mode);
Just checking.. Have you tested that these patches also
still work without device tree?
Regards,
Tony
No ! with out device tree enabled , these patches does not work.
do I need to make a code such way that it works with and without
device tree..?
regards
keshava
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation
On Thu, Nov 01, 2012 at 09:19:48AM +0100, Munegowda, Keshava wrote:
From: Tony Lindgren [t...@atomide.com]
Sent: Wednesday, October 31, 2012 11:59 PM
To: Munegowda, Keshava
Cc: linux-omap@vger.kernel.org; devicetree-disc...@lists.ozlabs.org;
linux-...@vger.kernel.org; linux-...@vger.kernel.org; Balbi, Felipe;
sa...@linux.intel.com; Cousson, Benoit
Subject: Re: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree
node Adaptation
* Keshava Munegowda keshava_mgo...@ti.com [121031 07:29]:
The USB2 Host device node is extracted and used in the probe
of the driver to initialize the usb ports and controller. The
platform specific initialization is also performed.
Signed-off-by: Keshava Munegowda keshava_mgo...@ti.com
---
arch/arm/mach-omap2/usb-host.c |2 -
drivers/mfd/omap-usb-host.c| 163
+++-
include/linux/platform_data/usb-omap.h | 19 +++-
3 files changed, 133 insertions(+), 51 deletions(-)
diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
index d1dbe12..239c175 100644
--- a/arch/arm/mach-omap2/usb-host.c
+++ b/arch/arm/mach-omap2/usb-host.c
@@ -502,8 +502,6 @@ void __init usbhs_init(const struct
usbhs_omap_board_data *pdata)
}
ehci_data.phy_reset = pdata-phy_reset;
ohci_data.es2_compatibility = pdata-es2_compatibility;
- usbhs_data.ehci_data = ehci_data;
- usbhs_data.ohci_data = ohci_data;
if (cpu_is_omap34xx()) {
setup_ehci_io_mux(pdata-port_mode);
Just checking.. Have you tested that these patches also
still work without device tree?
Regards,
Tony
No ! with out device tree enabled , these patches does not work.
do I need to make a code such way that it works with and without
device tree..?
yes. OMAP3/4 still have lots of legacy platform_data-only board support
;-)
--
balbi
signature.asc
Description: Digital signature
RE: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation
From: Balbi, Felipe
Sent: Thursday, November 01, 2012 3:51 PM
To: Munegowda, Keshava
Cc: Tony Lindgren; linux-omap@vger.kernel.org;
devicetree-disc...@lists.ozlabs.org; linux-...@vger.kernel.org;
linux-...@vger.kernel.org; Balbi, Felipe; sa...@linux.intel.com; Cousson, Benoit
Subject: Re: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree
node Adaptation
On Thu, Nov 01, 2012 at 09:19:48AM +0100, Munegowda, Keshava wrote:
From: Tony Lindgren [t...@atomide.com]
Sent: Wednesday, October 31, 2012 11:59 PM
To: Munegowda, Keshava
Cc: linux-omap@vger.kernel.org; devicetree-disc...@lists.ozlabs.org;
linux-...@vger.kernel.org; linux-...@vger.kernel.org; Balbi, Felipe;
sa...@linux.intel.com; Cousson, Benoit
Subject: Re: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree
node Adaptation
* Keshava Munegowda keshava_mgo...@ti.com [121031 07:29]:
The USB2 Host device node is extracted and used in the probe
of the driver to initialize the usb ports and controller. The
platform specific initialization is also performed.
Signed-off-by: Keshava Munegowda keshava_mgo...@ti.com
---
arch/arm/mach-omap2/usb-host.c |2 -
drivers/mfd/omap-usb-host.c| 163
+++-
include/linux/platform_data/usb-omap.h | 19 +++-
3 files changed, 133 insertions(+), 51 deletions(-)
diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
index d1dbe12..239c175 100644
--- a/arch/arm/mach-omap2/usb-host.c
+++ b/arch/arm/mach-omap2/usb-host.c
@@ -502,8 +502,6 @@ void __init usbhs_init(const struct
usbhs_omap_board_data *pdata)
}
ehci_data.phy_reset = pdata-phy_reset;
ohci_data.es2_compatibility = pdata-es2_compatibility;
- usbhs_data.ehci_data = ehci_data;
- usbhs_data.ohci_data = ohci_data;
if (cpu_is_omap34xx()) {
setup_ehci_io_mux(pdata-port_mode);
Just checking.. Have you tested that these patches also
still work without device tree?
Regards,
Tony
No ! with out device tree enabled , these patches does not work.
do I need to make a code such way that it works with and without
device tree..?
yes. OMAP3/4 still have lots of legacy platform_data-only board support
;-)
Thanks Felipe.
I will do this.
regards
keshava
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation
* Keshava Munegowda keshava_mgo...@ti.com [121031 07:29]:
The USB2 Host device node is extracted and used in the probe
of the driver to initialize the usb ports and controller. The
platform specific initialization is also performed.
Signed-off-by: Keshava Munegowda keshava_mgo...@ti.com
---
arch/arm/mach-omap2/usb-host.c |2 -
drivers/mfd/omap-usb-host.c| 163
+++-
include/linux/platform_data/usb-omap.h | 19 +++-
3 files changed, 133 insertions(+), 51 deletions(-)
diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
index d1dbe12..239c175 100644
--- a/arch/arm/mach-omap2/usb-host.c
+++ b/arch/arm/mach-omap2/usb-host.c
@@ -502,8 +502,6 @@ void __init usbhs_init(const struct usbhs_omap_board_data
*pdata)
}
ehci_data.phy_reset = pdata-phy_reset;
ohci_data.es2_compatibility = pdata-es2_compatibility;
- usbhs_data.ehci_data = ehci_data;
- usbhs_data.ohci_data = ohci_data;
if (cpu_is_omap34xx()) {
setup_ehci_io_mux(pdata-port_mode);
Just checking.. Have you tested that these patches also
still work without device tree?
Regards,
Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
