Re: [RFC 1/2] OMAP3+: voltage / oscillator parameter segregation
Vishwanath Sripathy writes: [...] >> >> diff --git a/arch/arm/mach-omap2/opp3xxx_data.c b/arch/arm/mach- >> omap2/opp3xxx_data.c >> >> index d95f3f9..b5d8294 100644 >> >> --- a/arch/arm/mach-omap2/opp3xxx_data.c >> >> +++ b/arch/arm/mach-omap2/opp3xxx_data.c >> >> @@ -26,6 +26,16 @@ >> >> #include "pm.h" >> >> >> >> /* 34xx */ >> >> +/* OMAP VP parameter values */ >> >> +#define OMAP3430_VP1_VLIMITTO_VDDMIN 0x14 >> >> +#define OMAP3430_VP1_VLIMITTO_VDDMAX 0x42 >> >> +#define OMAP3430_VP2_VLIMITTO_VDDMIN 0x18 >> >> +#define OMAP3430_VP2_VLIMITTO_VDDMAX 0x2c >>> NAK -> we should be using voltages here -> depending on the PMIC >>> used, the rounding factor may not map to TWL4030. >> >> Agreed. >> >> > I had posted patch for this earlier I believe in series >> > http://marc.info/?l=linux-omap&m=130741297821372&w=2 >> >> I know you're a bit distracted currently ;) but is there any chance >> you can refresh at least this patch: >> >> OMAP3+: PM: VP: use uV for max and min voltage limits >> >> from your series on top of my current pm-wip/voltdm branch? >> >> If not, maybe point us to an archived version and Tero can pick it up >> and add it to this series. After a quick search, I couldn't find it >> in the marc.info archives. > > Below link should help I suppose. > https://patchwork.kernel.org/patch/855172/ > Yes, Tero should pick this one up and add it to his series to address Nishanth's concerns. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [RFC 1/2] OMAP3+: voltage / oscillator parameter segregation
> -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Saturday, August 27, 2011 4:55 AM > To: Menon, Nishanth > Cc: Tero Kristo; linux-omap@vger.kernel.org; Vishwanath Sripathy > Subject: Re: [RFC 1/2] OMAP3+: voltage / oscillator parameter > segregation > > Hi Nishanth, > > "Menon, Nishanth" writes: > > > here is my quick feedback: > > > > > > On Wed, Aug 3, 2011 at 10:29, Tero Kristo wrote: > >> > >> This patch separates board specific voltage and oscillator ramp / > setup > >> times from the core code. Things changed: > >> > >> - on/sleep/ret/off voltage setup moved from common twl code to > >> VC / VP data (opp_data.c files) > >> - added board support for vdd ramp up / down times > >> - added board support for oscillator setup time declaration > >> > >> Todo: split patch into more easily manageable parts. > >> > >> Applies on top of pm/wip/voltdm branch, based on work done by > Vishwanath > >> Sripathy. > >> > >> Signed-off-by: Tero Kristo > >> Cc: Vishwanath Sripathy > > [...] > > >> diff --git a/arch/arm/mach-omap2/opp3xxx_data.c b/arch/arm/mach- > omap2/opp3xxx_data.c > >> index d95f3f9..b5d8294 100644 > >> --- a/arch/arm/mach-omap2/opp3xxx_data.c > >> +++ b/arch/arm/mach-omap2/opp3xxx_data.c > >> @@ -26,6 +26,16 @@ > >> #include "pm.h" > >> > >> /* 34xx */ > >> +/* OMAP VP parameter values */ > >> +#define OMAP3430_VP1_VLIMITTO_VDDMIN 0x14 > >> +#define OMAP3430_VP1_VLIMITTO_VDDMAX 0x42 > >> +#define OMAP3430_VP2_VLIMITTO_VDDMIN 0x18 > >> +#define OMAP3430_VP2_VLIMITTO_VDDMAX 0x2c > > NAK -> we should be using voltages here -> depending on the PMIC > used, > > the rounding factor may not map to TWL4030. > > Agreed. > > > I had posted patch for this earlier I believe in series > > http://marc.info/?l=linux-omap&m=130741297821372&w=2 > > I know you're a bit distracted currently ;) but is there any chance > you > can refresh at least this patch: > > OMAP3+: PM: VP: use uV for max and min voltage limits > > from your series on top of my current pm-wip/voltdm branch? > > If not, maybe point us to an archived version and Tero can pick it > up > and add it to this series. After a quick search, I couldn't find it > in > the marc.info archives. Below link should help I suppose. https://patchwork.kernel.org/patch/855172/ Vishwa > > Thanks, > > Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 1/2] OMAP3+: voltage / oscillator parameter segregation
Hi Nishanth, "Menon, Nishanth" writes: > here is my quick feedback: > > > On Wed, Aug 3, 2011 at 10:29, Tero Kristo wrote: >> >> This patch separates board specific voltage and oscillator ramp / setup >> times from the core code. Things changed: >> >> - on/sleep/ret/off voltage setup moved from common twl code to >> VC / VP data (opp_data.c files) >> - added board support for vdd ramp up / down times >> - added board support for oscillator setup time declaration >> >> Todo: split patch into more easily manageable parts. >> >> Applies on top of pm/wip/voltdm branch, based on work done by Vishwanath >> Sripathy. >> >> Signed-off-by: Tero Kristo >> Cc: Vishwanath Sripathy [...] >> diff --git a/arch/arm/mach-omap2/opp3xxx_data.c >> b/arch/arm/mach-omap2/opp3xxx_data.c >> index d95f3f9..b5d8294 100644 >> --- a/arch/arm/mach-omap2/opp3xxx_data.c >> +++ b/arch/arm/mach-omap2/opp3xxx_data.c >> @@ -26,6 +26,16 @@ >> #include "pm.h" >> >> /* 34xx */ >> +/* OMAP VP parameter values */ >> +#define OMAP3430_VP1_VLIMITTO_VDDMIN 0x14 >> +#define OMAP3430_VP1_VLIMITTO_VDDMAX 0x42 >> +#define OMAP3430_VP2_VLIMITTO_VDDMIN 0x18 >> +#define OMAP3430_VP2_VLIMITTO_VDDMAX 0x2c > NAK -> we should be using voltages here -> depending on the PMIC used, > the rounding factor may not map to TWL4030. Agreed. > I had posted patch for this earlier I believe in series > http://marc.info/?l=linux-omap&m=130741297821372&w=2 I know you're a bit distracted currently ;) but is there any chance you can refresh at least this patch: OMAP3+: PM: VP: use uV for max and min voltage limits from your series on top of my current pm-wip/voltdm branch? If not, maybe point us to an archived version and Tero can pick it up and add it to this series. After a quick search, I couldn't find it in the marc.info archives. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 1/2] OMAP3+: voltage / oscillator parameter segregation
here is my quick feedback:
On Wed, Aug 3, 2011 at 10:29, Tero Kristo wrote:
>
> This patch separates board specific voltage and oscillator ramp / setup
> times from the core code. Things changed:
>
> - on/sleep/ret/off voltage setup moved from common twl code to
> VC / VP data (opp_data.c files)
> - added board support for vdd ramp up / down times
> - added board support for oscillator setup time declaration
>
> Todo: split patch into more easily manageable parts.
>
> Applies on top of pm/wip/voltdm branch, based on work done by Vishwanath
> Sripathy.
>
> Signed-off-by: Tero Kristo
> Cc: Vishwanath Sripathy
> ---
> arch/arm/mach-omap2/omap_opp_data.h | 15 +++
> arch/arm/mach-omap2/omap_twl.c | 59 --
> arch/arm/mach-omap2/opp3xxx_data.c | 62 ++
> arch/arm/mach-omap2/opp4xxx_data.c | 47
> arch/arm/mach-omap2/prcm.c | 11 ++
> arch/arm/mach-omap2/prm2xxx_3xxx.c | 6 +
> arch/arm/mach-omap2/prm2xxx_3xxx.h | 1 +
> arch/arm/mach-omap2/prm44xx.c | 7 +
> arch/arm/mach-omap2/prm44xx.h | 1 +
> arch/arm/mach-omap2/vc.c | 153
> +
> arch/arm/mach-omap2/vc.h | 1 -
> arch/arm/mach-omap2/voltage.c | 22
> arch/arm/mach-omap2/voltage.h | 55 -
> arch/arm/mach-omap2/voltagedomains3xxx_data.c | 8 ++
> arch/arm/mach-omap2/voltagedomains44xx_data.c | 8 ++
> arch/arm/mach-omap2/vp.c | 4 +-
> arch/arm/plat-omap/include/plat/prcm.h | 7 +
> 17 files changed, 377 insertions(+), 90 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_opp_data.h
> b/arch/arm/mach-omap2/omap_opp_data.h
> index c784c12..b5fe711 100644
> --- a/arch/arm/mach-omap2/omap_opp_data.h
> +++ b/arch/arm/mach-omap2/omap_opp_data.h
> @@ -86,11 +86,26 @@ extern int __init omap_init_opp_table(struct omap_opp_def
> *opp_def,
>
> extern struct omap_volt_data omap34xx_vddmpu_volt_data[];
> extern struct omap_volt_data omap34xx_vddcore_volt_data[];
> +extern struct omap_vp_param omap34xx_mpu_vp_data;
> +extern struct omap_vp_param omap34xx_core_vp_data;
> +extern struct omap_vc_param omap34xx_mpu_vc_data;
> +extern struct omap_vc_param omap34xx_core_vc_data;
> +
> extern struct omap_volt_data omap36xx_vddmpu_volt_data[];
> extern struct omap_volt_data omap36xx_vddcore_volt_data[];
> +extern struct omap_vp_param omap36xx_mpu_vp_data;
> +extern struct omap_vp_param omap36xx_core_vp_data;
> +extern struct omap_vc_param omap36xx_mpu_vc_data;
> +extern struct omap_vc_param omap36xx_core_vc_data;
>
> extern struct omap_volt_data omap44xx_vdd_mpu_volt_data[];
> extern struct omap_volt_data omap44xx_vdd_iva_volt_data[];
> extern struct omap_volt_data omap44xx_vdd_core_volt_data[];
> +extern struct omap_vp_param omap44xx_mpu_vp_data;
> +extern struct omap_vp_param omap44xx_iva_vp_data;
> +extern struct omap_vp_param omap44xx_core_vp_data;
> +extern struct omap_vc_param omap44xx_mpu_vc_data;
> +extern struct omap_vc_param omap44xx_iva_vc_data;
> +extern struct omap_vc_param omap44xx_core_vc_data;
>
> #endif /* __ARCH_ARM_MACH_OMAP2_OMAP_OPP_DATA_H */
> diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c
> index f515a1a..d239792 100644
> --- a/arch/arm/mach-omap2/omap_twl.c
> +++ b/arch/arm/mach-omap2/omap_twl.c
> @@ -30,16 +30,6 @@
> #define OMAP3_VP_VSTEPMAX_VSTEPMAX 0x04
> #define OMAP3_VP_VLIMITTO_TIMEOUT_US 200
>
> -#define OMAP3430_VP1_VLIMITTO_VDDMIN 0x14
> -#define OMAP3430_VP1_VLIMITTO_VDDMAX 0x42
> -#define OMAP3430_VP2_VLIMITTO_VDDMIN 0x18
> -#define OMAP3430_VP2_VLIMITTO_VDDMAX 0x2c
> -
> -#define OMAP3630_VP1_VLIMITTO_VDDMIN 0x18
> -#define OMAP3630_VP1_VLIMITTO_VDDMAX 0x3c
> -#define OMAP3630_VP2_VLIMITTO_VDDMIN 0x18
> -#define OMAP3630_VP2_VLIMITTO_VDDMAX 0x30
> -
> #define OMAP4_SRI2C_SLAVE_ADDR 0x12
> #define OMAP4_VDD_MPU_SR_VOLT_REG 0x55
> #define OMAP4_VDD_MPU_SR_CMD_REG 0x56
> @@ -53,13 +43,6 @@
> #define OMAP4_VP_VSTEPMAX_VSTEPMAX 0x04
> #define OMAP4_VP_VLIMITTO_TIMEOUT_US 200
>
> -#define OMAP4_VP_MPU_VLIMITTO_VDDMIN 0xA
> -#define OMAP4_VP_MPU_VLIMITTO_VDDMAX 0x39
> -#define OMAP4_VP_IVA_VLIMITTO_VDDMIN 0xA
> -#define OMAP4_VP_IVA_VLIMITTO_VDDMAX 0x2D
> -#define OMAP4_VP_CORE_VLIMITTO_VDDMIN 0xA
> -#define OMAP4_VP_CORE_VLIMITTO_VDDMAX 0x28
> -
> static bool is_offset_valid;
> static u8 smps_offset;
> /*
> @@ -158,16 +141,9 @@ static u8 twl6030_uv_to_vsel(unsigned long uv)
> static struct omap_voltdm_pmic omap3_mpu_pmic = {
> .slew_rate = 4000,
> .step_size = 12500,
> - .on_volt = 120,
> - .onlp_volt = 100,
> - .ret_volt = 975000,
> - .off_volt = 60,
> - .volt_setu
RE: [RFC 1/2] OMAP3+: voltage / oscillator parameter segregation
On Thu, 2011-08-04 at 15:57 +0200, Sripathy, Vishwanath wrote: > > Texas Instruments Oy, Tekniikantie 12, 02150 Espoo. Y-tunnus: 0115040-6. Kotipaikka: Helsinki -Original Message- > > From: Tero Kristo [mailto:t-kri...@ti.com] > > Sent: Wednesday, August 03, 2011 8:59 PM > > To: linux-omap@vger.kernel.org > > Cc: Vishwanath Sripathy > > Subject: [RFC 1/2] OMAP3+: voltage / oscillator parameter > > segregation > > > > This patch separates board specific voltage and oscillator ramp / > > setup > > times from the core code. Things changed: > > > > - on/sleep/ret/off voltage setup moved from common twl code to > > VC / VP data (opp_data.c files) > > - added board support for vdd ramp up / down times > > - added board support for oscillator setup time declaration > > > > Todo: split patch into more easily manageable parts. > > > > Applies on top of pm/wip/voltdm branch, based on work done by > > Vishwanath > > Sripathy. > > > > Signed-off-by: Tero Kristo > > Cc: Vishwanath Sripathy > > --- > > arch/arm/mach-omap2/omap_opp_data.h | 15 +++ > > arch/arm/mach-omap2/omap_twl.c| 59 -- > > arch/arm/mach-omap2/opp3xxx_data.c| 62 ++ > > arch/arm/mach-omap2/opp4xxx_data.c| 47 > > arch/arm/mach-omap2/prcm.c| 11 ++ > > arch/arm/mach-omap2/prm2xxx_3xxx.c|6 + > > arch/arm/mach-omap2/prm2xxx_3xxx.h|1 + > > arch/arm/mach-omap2/prm44xx.c |7 + > > arch/arm/mach-omap2/prm44xx.h |1 + > > arch/arm/mach-omap2/vc.c | 153 > > + > > arch/arm/mach-omap2/vc.h |1 - > > arch/arm/mach-omap2/voltage.c | 22 > > arch/arm/mach-omap2/voltage.h | 55 - > > arch/arm/mach-omap2/voltagedomains3xxx_data.c |8 ++ > > arch/arm/mach-omap2/voltagedomains44xx_data.c |8 ++ > > arch/arm/mach-omap2/vp.c |4 +- > > arch/arm/plat-omap/include/plat/prcm.h|7 + > > 17 files changed, 377 insertions(+), 90 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/omap_opp_data.h b/arch/arm/mach- > > omap2/omap_opp_data.h > > index c784c12..b5fe711 100644 > > --- a/arch/arm/mach-omap2/omap_opp_data.h > > +++ b/arch/arm/mach-omap2/omap_opp_data.h > > @@ -86,11 +86,26 @@ extern int __init omap_init_opp_table(struct > > omap_opp_def *opp_def, > > > > extern struct omap_volt_data omap34xx_vddmpu_volt_data[]; > > extern struct omap_volt_data omap34xx_vddcore_volt_data[]; > > +extern struct omap_vp_param omap34xx_mpu_vp_data; > > +extern struct omap_vp_param omap34xx_core_vp_data; > > +extern struct omap_vc_param omap34xx_mpu_vc_data; > > +extern struct omap_vc_param omap34xx_core_vc_data; > > + > > extern struct omap_volt_data omap36xx_vddmpu_volt_data[]; > > extern struct omap_volt_data omap36xx_vddcore_volt_data[]; > > +extern struct omap_vp_param omap36xx_mpu_vp_data; > > +extern struct omap_vp_param omap36xx_core_vp_data; > > +extern struct omap_vc_param omap36xx_mpu_vc_data; > > +extern struct omap_vc_param omap36xx_core_vc_data; > > > > extern struct omap_volt_data omap44xx_vdd_mpu_volt_data[]; > > extern struct omap_volt_data omap44xx_vdd_iva_volt_data[]; > > extern struct omap_volt_data omap44xx_vdd_core_volt_data[]; > > +extern struct omap_vp_param omap44xx_mpu_vp_data; > > +extern struct omap_vp_param omap44xx_iva_vp_data; > > +extern struct omap_vp_param omap44xx_core_vp_data; > > +extern struct omap_vc_param omap44xx_mpu_vc_data; > > +extern struct omap_vc_param omap44xx_iva_vc_data; > > +extern struct omap_vc_param omap44xx_core_vc_data; > > > > #endif /* __ARCH_ARM_MACH_OMAP2_OMAP_OPP_DATA_H */ > > diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach- > > omap2/omap_twl.c > > index f515a1a..d239792 100644 > > --- a/arch/arm/mach-omap2/omap_twl.c > > +++ b/arch/arm/mach-omap2/omap_twl.c > > @@ -30,16 +30,6 @@ > > #define OMAP3_VP_VSTEPMAX_VSTEPMAX 0x04 > > #define OMAP3_VP_VLIMITTO_TIMEOUT_US 200 > > > > -#define OMAP3430_VP1_VLIMITTO_VDDMIN 0x14 > > -#define OMAP3430_VP1_VLIMITTO_VDDMAX 0x42 > > -#define OMAP3430_VP2_VLIMITTO_VDDMIN 0x18 > > -#define OMAP3430_VP2_VLIMITTO_VDDMAX 0x2c > > - > > -#define OMAP3630_VP1_VLIMITTO_VDDMIN 0x18 > > -#define OMAP3630_VP1_VLIMITTO_VDDMAX 0x3c > > -#define OMAP3630_VP2_VLIMITTO_VDDMIN 0x18 > > -#define OMAP3630_VP2_VLIMITTO_VDDMAX 0x30 > > - > > #define OMAP4_SRI2C_SLAVE_ADDR 0x12 > > #define OMAP4_VDD_MPU_SR_VOLT_REG0x55 > > #define OMAP4_VDD_MPU_SR_CMD_REG 0x56 > > @@ -53,13 +43,6 @@ > > #define OMAP4_VP_VSTEPMAX_VSTEPMAX 0x04 > > #define OMAP4_VP_VLIMITTO_TIMEOUT_US 200 > > > > -#define OMAP4_VP_MPU_VLIMITTO_VDDMIN 0xA > > -#define OMAP4_VP_MPU_VLIMITTO_VDDMAX 0x39 > > -#define OMAP4_VP_IVA_VLIMITTO_VDDMIN 0xA > > -#define OMAP4_VP_IVA_VLIMITTO_VDDMAX 0x2D > > -#define OMAP4_VP_CORE_VLIMI
RE: [RFC 1/2] OMAP3+: voltage / oscillator parameter segregation
> -Original Message-
> From: Tero Kristo [mailto:t-kri...@ti.com]
> Sent: Wednesday, August 03, 2011 8:59 PM
> To: linux-omap@vger.kernel.org
> Cc: Vishwanath Sripathy
> Subject: [RFC 1/2] OMAP3+: voltage / oscillator parameter
> segregation
>
> This patch separates board specific voltage and oscillator ramp /
> setup
> times from the core code. Things changed:
>
> - on/sleep/ret/off voltage setup moved from common twl code to
> VC / VP data (opp_data.c files)
> - added board support for vdd ramp up / down times
> - added board support for oscillator setup time declaration
>
> Todo: split patch into more easily manageable parts.
>
> Applies on top of pm/wip/voltdm branch, based on work done by
> Vishwanath
> Sripathy.
>
> Signed-off-by: Tero Kristo
> Cc: Vishwanath Sripathy
> ---
> arch/arm/mach-omap2/omap_opp_data.h | 15 +++
> arch/arm/mach-omap2/omap_twl.c| 59 --
> arch/arm/mach-omap2/opp3xxx_data.c| 62 ++
> arch/arm/mach-omap2/opp4xxx_data.c| 47
> arch/arm/mach-omap2/prcm.c| 11 ++
> arch/arm/mach-omap2/prm2xxx_3xxx.c|6 +
> arch/arm/mach-omap2/prm2xxx_3xxx.h|1 +
> arch/arm/mach-omap2/prm44xx.c |7 +
> arch/arm/mach-omap2/prm44xx.h |1 +
> arch/arm/mach-omap2/vc.c | 153
> +
> arch/arm/mach-omap2/vc.h |1 -
> arch/arm/mach-omap2/voltage.c | 22
> arch/arm/mach-omap2/voltage.h | 55 -
> arch/arm/mach-omap2/voltagedomains3xxx_data.c |8 ++
> arch/arm/mach-omap2/voltagedomains44xx_data.c |8 ++
> arch/arm/mach-omap2/vp.c |4 +-
> arch/arm/plat-omap/include/plat/prcm.h|7 +
> 17 files changed, 377 insertions(+), 90 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_opp_data.h b/arch/arm/mach-
> omap2/omap_opp_data.h
> index c784c12..b5fe711 100644
> --- a/arch/arm/mach-omap2/omap_opp_data.h
> +++ b/arch/arm/mach-omap2/omap_opp_data.h
> @@ -86,11 +86,26 @@ extern int __init omap_init_opp_table(struct
> omap_opp_def *opp_def,
>
> extern struct omap_volt_data omap34xx_vddmpu_volt_data[];
> extern struct omap_volt_data omap34xx_vddcore_volt_data[];
> +extern struct omap_vp_param omap34xx_mpu_vp_data;
> +extern struct omap_vp_param omap34xx_core_vp_data;
> +extern struct omap_vc_param omap34xx_mpu_vc_data;
> +extern struct omap_vc_param omap34xx_core_vc_data;
> +
> extern struct omap_volt_data omap36xx_vddmpu_volt_data[];
> extern struct omap_volt_data omap36xx_vddcore_volt_data[];
> +extern struct omap_vp_param omap36xx_mpu_vp_data;
> +extern struct omap_vp_param omap36xx_core_vp_data;
> +extern struct omap_vc_param omap36xx_mpu_vc_data;
> +extern struct omap_vc_param omap36xx_core_vc_data;
>
> extern struct omap_volt_data omap44xx_vdd_mpu_volt_data[];
> extern struct omap_volt_data omap44xx_vdd_iva_volt_data[];
> extern struct omap_volt_data omap44xx_vdd_core_volt_data[];
> +extern struct omap_vp_param omap44xx_mpu_vp_data;
> +extern struct omap_vp_param omap44xx_iva_vp_data;
> +extern struct omap_vp_param omap44xx_core_vp_data;
> +extern struct omap_vc_param omap44xx_mpu_vc_data;
> +extern struct omap_vc_param omap44xx_iva_vc_data;
> +extern struct omap_vc_param omap44xx_core_vc_data;
>
> #endif /* __ARCH_ARM_MACH_OMAP2_OMAP_OPP_DATA_H */
> diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-
> omap2/omap_twl.c
> index f515a1a..d239792 100644
> --- a/arch/arm/mach-omap2/omap_twl.c
> +++ b/arch/arm/mach-omap2/omap_twl.c
> @@ -30,16 +30,6 @@
> #define OMAP3_VP_VSTEPMAX_VSTEPMAX 0x04
> #define OMAP3_VP_VLIMITTO_TIMEOUT_US 200
>
> -#define OMAP3430_VP1_VLIMITTO_VDDMIN 0x14
> -#define OMAP3430_VP1_VLIMITTO_VDDMAX 0x42
> -#define OMAP3430_VP2_VLIMITTO_VDDMIN 0x18
> -#define OMAP3430_VP2_VLIMITTO_VDDMAX 0x2c
> -
> -#define OMAP3630_VP1_VLIMITTO_VDDMIN 0x18
> -#define OMAP3630_VP1_VLIMITTO_VDDMAX 0x3c
> -#define OMAP3630_VP2_VLIMITTO_VDDMIN 0x18
> -#define OMAP3630_VP2_VLIMITTO_VDDMAX 0x30
> -
> #define OMAP4_SRI2C_SLAVE_ADDR 0x12
> #define OMAP4_VDD_MPU_SR_VOLT_REG0x55
> #define OMAP4_VDD_MPU_SR_CMD_REG 0x56
> @@ -53,13 +43,6 @@
> #define OMAP4_VP_VSTEPMAX_VSTEPMAX 0x04
> #define OMAP4_VP_VLIMITTO_TIMEOUT_US 200
>
> -#define OMAP4_VP_MPU_VLIMITTO_VDDMIN 0xA
> -#define OMAP4_VP_MPU_VLIMITTO_VDDMAX 0x39
> -#define OMAP4_VP_IVA_VLIMITTO_VDDMIN 0xA
> -#define OMAP4_VP_IVA_VLIMITTO_VDDMAX 0x2D
> -#define OMAP4_VP_CORE_VLIMITTO_VDDMIN0xA
> -#define OMAP4_VP_CORE_VLIMITTO_VDDMAX0x28
> -
> static bool is_offset_valid;
> static u8 smps_offset;
> /*
> @@ -158,16 +141,9 @@ static u8 twl6030_uv_to_vsel(unsigned long uv)
> static struct omap_voltdm_pmic omap3_mpu_pmic = {
> .slew_rate = 4000,
> .step_size = 12500,
> - .on_volt= 1
