Re: [PATCH] omap3: feature: fix OMAP3_IVA_MASK

2010-11-17 Thread Nishanth Menon

Tony Lindgren wrote, on 11/16/2010 03:27 PM:

* Nishanth Menon  [101105 17:29]:

From: Arno Steffen

OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT

Signed-off-by: Arno Steffen
---
Sending on behalf of Arno - he pointed at the change and everything
except for the patch ;)
Reported here:
http://marc.info/?l=linux-omap&m=128896969832702&w=2


Hmm, until we have an official verbal-patch-to-unified-diff translator,
I guess the right thing to do here is to make it be:

From: Nishanth Menon

OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT

Reported-by: Arno Steffen
Signed-off-by: Nishanth Menon

Can you please repost or confirm that's OK for you?


I would prefer if Arno resubmit the patch under his name - but if he 
cannot do so, I can take ownership.


Arno,
please comment.



Tony


  arch/arm/mach-omap2/control.h |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
index b6c6b7c..5325297 100644
--- a/arch/arm/mach-omap2/control.h
+++ b/arch/arm/mach-omap2/control.h
@@ -309,7 +309,7 @@
  #define   FEAT_SGX_NONE   2

  #define OMAP3_IVA_SHIFT   12
-#define OMAP3_IVA_MASK (1<<  OMAP3_SGX_SHIFT)
+#define OMAP3_IVA_MASK (1<<  OMAP3_IVA_SHIFT)
  #define   FEAT_IVA0
  #define   FEAT_IVA_NONE   1

--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] omap3: feature: fix OMAP3_IVA_MASK

2010-11-16 Thread Tony Lindgren
* Nishanth Menon  [101105 17:29]:
> From: Arno Steffen 
> 
> OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
> 
> Signed-off-by: Arno Steffen 
> ---
> Sending on behalf of Arno - he pointed at the change and everything
> except for the patch ;)
> Reported here:
> http://marc.info/?l=linux-omap&m=128896969832702&w=2

Hmm, until we have an official verbal-patch-to-unified-diff translator,
I guess the right thing to do here is to make it be:

From: Nishanth Menon 

OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT

Reported-by: Arno Steffen 
Signed-off-by: Nishanth Menon 

Can you please repost or confirm that's OK for you?

Tony
 
>  arch/arm/mach-omap2/control.h |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
> index b6c6b7c..5325297 100644
> --- a/arch/arm/mach-omap2/control.h
> +++ b/arch/arm/mach-omap2/control.h
> @@ -309,7 +309,7 @@
>  #define  FEAT_SGX_NONE   2
>  
>  #define OMAP3_IVA_SHIFT  12
> -#define OMAP3_IVA_MASK   (1 << OMAP3_SGX_SHIFT)
> +#define OMAP3_IVA_MASK   (1 << OMAP3_IVA_SHIFT)
>  #define  FEAT_IVA0
>  #define  FEAT_IVA_NONE   1
>  
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html