Re: [PATCH 0/2] OMAP: convert boards that use SMSC911x to use gpmc-smsc911x
* Tony Lindgren [110419 14:42]: > * Mike Rapoport [110419 14:32]: > > Hi Tony, > > > > On Mon, Apr 18, 2011 at 2:21 PM, Tony Lindgren wrote: > > > * Mike Rapoport [110417 01:21]: > > > Nice job Mike :) > > > > There's a _lot_ of very similar code in different board files. If > > you'd like to I can try to create something like > > common-board-devices.c and move most of that code there. It's not the > > real consolidation Linus wanted, but at least all the copy-pasted > > device initialization code would be removed. > > Yes please do if you can, that helps a lot. Also most beagle > related boards could probably have a common board-beagle.c file. > > Eventually the board configuration will come from device tree. > But until that's available, we can consolidate the code within > arch/arm/*omap*/ as the common platform init functions will still > be needed with configuration coming from DT. Oh one more thing, can you please repost this series with linux-arm-kernel list also Cc'd? That way I can apply it without having to repost it for review. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] OMAP: convert boards that use SMSC911x to use gpmc-smsc911x
* Mike Rapoport [110419 14:32]: > Hi Tony, > > On Mon, Apr 18, 2011 at 2:21 PM, Tony Lindgren wrote: > > * Mike Rapoport [110417 01:21]: > > Nice job Mike :) > > There's a _lot_ of very similar code in different board files. If > you'd like to I can try to create something like > common-board-devices.c and move most of that code there. It's not the > real consolidation Linus wanted, but at least all the copy-pasted > device initialization code would be removed. Yes please do if you can, that helps a lot. Also most beagle related boards could probably have a common board-beagle.c file. Eventually the board configuration will come from device tree. But until that's available, we can consolidate the code within arch/arm/*omap*/ as the common platform init functions will still be needed with configuration coming from DT. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] OMAP: convert boards that use SMSC911x to use gpmc-smsc911x
Hi Tony, On Mon, Apr 18, 2011 at 2:21 PM, Tony Lindgren wrote: > * Mike Rapoport [110417 01:21]: > Nice job Mike :) There's a _lot_ of very similar code in different board files. If you'd like to I can try to create something like common-board-devices.c and move most of that code there. It's not the real consolidation Linus wanted, but at least all the copy-pasted device initialization code would be removed. > Tony > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Sincerely Yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] OMAP: convert boards that use SMSC911x to use gpmc-smsc911x
* Mike Rapoport [110417 01:21]: > There are several OMAP boards that use SMSC911x Ethernet controller. Convert > them all to use gpmc-smsc911x for device registration. > > Mike Rapoport (2): > OMAP: gpmc-smsc911x: always set irq flags to IORESOURCE_IRQ_LOWLEVEL > OMAP: convert boards that use SMSC911x to use gpmc-smsc911x > > arch/arm/mach-omap2/board-cm-t35.c | 84 +++-- > arch/arm/mach-omap2/board-igep0020.c| 53 ++--- > arch/arm/mach-omap2/board-ldp.c | 65 ++-- > arch/arm/mach-omap2/board-omap3evm.c| 71 +++--- > arch/arm/mach-omap2/board-omap3logic.c |1 - > arch/arm/mach-omap2/board-omap3stalker.c| 48 ++-- > arch/arm/mach-omap2/board-overo.c | 108 > --- > arch/arm/mach-omap2/board-zoom-debugboard.c | 56 ++ > arch/arm/mach-omap2/gpmc-smsc911x.c |7 +- > 9 files changed, 70 insertions(+), 423 deletions(-) Nice job Mike :) Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
