Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 MD5 driver
On Tue, Mar 23, 2010 at 07:32:39PM +0800, Herbert Xu wrote:
My only question is what's your plan with respect to HMAC? If
you're going to do it in hardware then it's fine as it is.
Otherwise you need to implement export/import and we also need
to add ahash support to hmac.c.
Dmitry, did you answer this before or did it get lost in the mail :)
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 MD5 driver
On 23/03/10 13:32, ext Herbert Xu wrote: On Wed, Mar 17, 2010 at 03:12:49PM +0200, Dmitry Kasatkin wrote: Earlier kernel contained omap sha1 and md5 driver, which was not maintained, was not ported to new crypto APIs and removed from the source tree. This driver implements async and sync crypto API. It still contains pr_debug() for debugging purpose. Will be remove for integration. Dmitry Kasatkin (2): sec: omap sha1 md5 driver sec: Makefile/Kconfig update for omap sha1 md5 driver It looks good to me as far as the Crypto API is concerned. My only question is what's your plan with respect to HMAC? If you're going to do it in hardware then it's fine as it is. Otherwise you need to implement export/import and we also need to add ahash support to hmac.c. Thanks, Hello, Thanks for looking to it. No hw is not doing hmac. I need to look to this then. Will comeback in a while. - Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 MD5 driver
On Wed, Mar 17, 2010 at 03:12:49PM +0200, Dmitry Kasatkin wrote:
Earlier kernel contained omap sha1 and md5 driver, which was not maintained,
was not ported to new crypto APIs and removed from the source tree.
This driver implements async and sync crypto API.
It still contains pr_debug() for debugging purpose.
Will be remove for integration.
Dmitry Kasatkin (2):
sec: omap sha1 md5 driver
sec: Makefile/Kconfig update for omap sha1 md5 driver
It looks good to me as far as the Crypto API is concerned.
My only question is what's your plan with respect to HMAC? If
you're going to do it in hardware then it's fine as it is.
Otherwise you need to implement export/import and we also need
to add ahash support to hmac.c.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
