Re: [PATCH 4/9] ARM: dts: OMAP3: Add support for OMAP3430 SDP board
On Tue, Mar 12, 2013 at 3:42 AM, Kumar, Anil anilkuma...@ti.com wrote:
On Mon, Mar 11, 2013 at 23:23:32, Hunter, Jon wrote:
On 03/08/2013 08:25 PM, Anil Kumar wrote:
Hi Jon,
On Fri, Mar 8, 2013 at 10:57 PM, Jon Hunter jon-hun...@ti.com wrote:
Adds basic device-tree support for OMAP3430 SDP board which has 256MB
of RAM and uses the TWL4030 power management IC.
I think this board support should be in separate patch series with
related patches.
Well I wanted to keep them altogether so that I can send a pull request
to Benoit and Tony.
Sorry, but can you please tell what makes you to think that you
can send pull request only when they are altogether ?
Is there any logical dependency with other patches except
[PATCH 6/9] ARM: dts: Add OMAP3430 SDP flash memory bindings is on
top of this patch ?
Signed-off-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/omap3430-sdp.dts | 46
2 files changed, 47 insertions(+)
create mode 100644 arch/arm/boot/dts/omap3430-sdp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 9c62558..89013ed 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -119,6 +119,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
omap3-beagle-xm.dtb \
omap3-evm.dtb \
omap3-tobi.dtb \
+ omap3430-sdp.dtb \
omap4-panda.dtb \
omap4-panda-a4.dtb \
omap4-panda-es.dtb \
diff --git a/arch/arm/boot/dts/omap3430-sdp.dts
b/arch/arm/boot/dts/omap3430-sdp.dts
new file mode 100644
index 000..be0650d
--- /dev/null
+++ b/arch/arm/boot/dts/omap3430-sdp.dts
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ omap3.dtsi
+
+/ {
+ model = TI OMAP3430 SDP;
+ compatible = ti,omap3430-sdp, ti,omap3;
I have not seen any related changes in board-generic.c for your board.
So just wanted know, how this board is booting ?
If you look at board-generic.c you will see that ti,omap3 will match
the OMAP3 generic machine. So you don't need to modify the board-generic.c.
According to this omap3-beagle.dts and omap3-beagle-xm.dts are also
booting in some way. So it is not clear to me, why there two
DT_MACHINE_START for omap3. I have seen there is only one
different in init_time for the same.
Hi Anil,
You may take a look to commit:
7dd9d50 ARM: OMAP3: Add generic machine descriptor for boards with
OMAP3 GP device
So, the second DT_MACHINE_START is meant to be used by OMAP3 boards
which use GP devices and this is not the case for ti,omap3430-sdp
afaiu.
I wonder if instead of adding each OMAP3 board with GP devices such as
ti,omap3-beagle, is not better to have a ti,omap3-gp compatible
property.
The whole point of DT is to decouple the hardware description from the
kernel code so in general we should use the more generic compatible
string (ti,omap3) unless the hardware has some specifics that have
to be addressed, such as these boards that use GP devices.
+
+ memory {
+ device_type = memory;
+ reg = 0x8000 0x1000; /* 256 MB */
+ };
+};
+
+i2c1 {
+ clock-frequency = 260;
+
+ twl: twl@48 {
+ reg = 0x48;
+ interrupts = 7; /* SYS_NIRQ cascaded to intc */
+ interrupt-parent = intc;
+ };
+};
+
+/include/ twl4030.dtsi
+
+mmc1 {
+ vmmc-supply = vmmc1;
+ vmmc_aux-supply = vsim;
+ bus-width = 8;
+};
+
+mmc2 {
+ status = disabled;
+};
+
+mmc3 {
+ status = disabled;
+};
I think you should disable modules those are not currently used
as they are enabled by default in omap3.dtsi.
exp:-
mcbsp2 {
status = disabled;
};
Well may be we could do that in a follow-up patch. If you look at other
omap3 boards we have not gone through and disabled all unused modules
either. So although I agree, right now I just want to get minimal
support added.
Hmm... But it makes the kernel to call unused driver probe and get failed
those required some platform date from DT? you can see the kernel boot logs.
Thanks,
Anil
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/9] ARM: dts: OMAP3: Add support for OMAP3430 SDP board
On 03/11/2013 09:42 PM, Kumar, Anil wrote:
On Mon, Mar 11, 2013 at 23:23:32, Hunter, Jon wrote:
On 03/08/2013 08:25 PM, Anil Kumar wrote:
Hi Jon,
On Fri, Mar 8, 2013 at 10:57 PM, Jon Hunter jon-hun...@ti.com wrote:
Adds basic device-tree support for OMAP3430 SDP board which has 256MB
of RAM and uses the TWL4030 power management IC.
I think this board support should be in separate patch series with
related patches.
Well I wanted to keep them altogether so that I can send a pull request
to Benoit and Tony.
Sorry, but can you please tell what makes you to think that you
can send pull request only when they are altogether ?
That's not the point.
Is there any logical dependency with other patches except
[PATCH 6/9] ARM: dts: Add OMAP3430 SDP flash memory bindings is on
top of this patch ?
Per the $subject of the series these a various DT patches I have pending.
Yes I could break this series up into many separate series, one for PMU,
one for DMA, one for GPMC, one for OMAP3 SDP, but I thought it would be
easier for Tony and Benoit to pull as a single series.
If Tony or Benoit wish for me to separate these out, I will.
Signed-off-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/omap3430-sdp.dts | 46
2 files changed, 47 insertions(+)
create mode 100644 arch/arm/boot/dts/omap3430-sdp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 9c62558..89013ed 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -119,6 +119,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
omap3-beagle-xm.dtb \
omap3-evm.dtb \
omap3-tobi.dtb \
+ omap3430-sdp.dtb \
omap4-panda.dtb \
omap4-panda-a4.dtb \
omap4-panda-es.dtb \
diff --git a/arch/arm/boot/dts/omap3430-sdp.dts
b/arch/arm/boot/dts/omap3430-sdp.dts
new file mode 100644
index 000..be0650d
--- /dev/null
+++ b/arch/arm/boot/dts/omap3430-sdp.dts
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ omap3.dtsi
+
+/ {
+ model = TI OMAP3430 SDP;
+ compatible = ti,omap3430-sdp, ti,omap3;
I have not seen any related changes in board-generic.c for your board.
So just wanted know, how this board is booting ?
If you look at board-generic.c you will see that ti,omap3 will match
the OMAP3 generic machine. So you don't need to modify the board-generic.c.
According to this omap3-beagle.dts and omap3-beagle-xm.dts are also
booting in some way. So it is not clear to me, why there two
DT_MACHINE_START for omap3. I have seen there is only one
different in init_time for the same.
OMAP3 beagle uses the machine descriptor OMAP3_GP_DT where as OMAP3
beagle-xm (and OMAP3 SDP) use the machine descriptor OMAP3_DT. The
real difference in these machine descriptors is the init_time
function pointer.
+
+ memory {
+ device_type = memory;
+ reg = 0x8000 0x1000; /* 256 MB */
+ };
+};
+
+i2c1 {
+ clock-frequency = 260;
+
+ twl: twl@48 {
+ reg = 0x48;
+ interrupts = 7; /* SYS_NIRQ cascaded to intc */
+ interrupt-parent = intc;
+ };
+};
+
+/include/ twl4030.dtsi
+
+mmc1 {
+ vmmc-supply = vmmc1;
+ vmmc_aux-supply = vsim;
+ bus-width = 8;
+};
+
+mmc2 {
+ status = disabled;
+};
+
+mmc3 {
+ status = disabled;
+};
I think you should disable modules those are not currently used
as they are enabled by default in omap3.dtsi.
exp:-
mcbsp2 {
status = disabled;
};
Well may be we could do that in a follow-up patch. If you look at other
omap3 boards we have not gone through and disabled all unused modules
either. So although I agree, right now I just want to get minimal
support added.
Hmm... But it makes the kernel to call unused driver probe and get failed
those required some platform date from DT? you can see the kernel boot logs.
Here is the console output I see on the omap3 sdp. There are a few warnings
around pin-mux settings but nothing major AFAICT ...
[0.00] Booting Linux on physical CPU 0x0
[0.00] Linux version 3.9.0-rc2-39794-g1c71698 (jenkins@cfasvr1) (gcc
version 4.6.1 (Sourcery CodeBench Lite 2011.09-70) ) #4 SMP Tue Mar 12 15:59:47
CDT 2013
[0.00] CPU: ARMv7 Processor [411fc083] revision 3 (ARMv7), cr=10c53c7d
[0.00] CPU: PIPT / VIPT nonaliasing data cache, VIPT nonaliasing
instruction cache
[0.00] Machine: Generic OMAP3 (Flattened Device Tree), model: TI
OMAP3430 SDP
[0.00] cma: CMA: reserved 16
RE: [PATCH 4/9] ARM: dts: OMAP3: Add support for OMAP3430 SDP board
On Tue, Mar 12, 2013 at 14:20:48, Javier Martinez Canillas wrote:
On Tue, Mar 12, 2013 at 3:42 AM, Kumar, Anil anilkuma...@ti.com wrote:
On Mon, Mar 11, 2013 at 23:23:32, Hunter, Jon wrote:
On 03/08/2013 08:25 PM, Anil Kumar wrote:
Hi Jon,
On Fri, Mar 8, 2013 at 10:57 PM, Jon Hunter jon-hun...@ti.com wrote:
Adds basic device-tree support for OMAP3430 SDP board which has 256MB
of RAM and uses the TWL4030 power management IC.
I think this board support should be in separate patch series with
related patches.
Well I wanted to keep them altogether so that I can send a pull request
to Benoit and Tony.
Sorry, but can you please tell what makes you to think that you
can send pull request only when they are altogether ?
Is there any logical dependency with other patches except
[PATCH 6/9] ARM: dts: Add OMAP3430 SDP flash memory bindings is on
top of this patch ?
Signed-off-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/omap3430-sdp.dts | 46
2 files changed, 47 insertions(+)
create mode 100644 arch/arm/boot/dts/omap3430-sdp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 9c62558..89013ed 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -119,6 +119,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
omap3-beagle-xm.dtb \
omap3-evm.dtb \
omap3-tobi.dtb \
+ omap3430-sdp.dtb \
omap4-panda.dtb \
omap4-panda-a4.dtb \
omap4-panda-es.dtb \
diff --git a/arch/arm/boot/dts/omap3430-sdp.dts
b/arch/arm/boot/dts/omap3430-sdp.dts
new file mode 100644
index 000..be0650d
--- /dev/null
+++ b/arch/arm/boot/dts/omap3430-sdp.dts
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2013 Texas Instruments Incorporated -
http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ omap3.dtsi
+
+/ {
+ model = TI OMAP3430 SDP;
+ compatible = ti,omap3430-sdp, ti,omap3;
I have not seen any related changes in board-generic.c for your board.
So just wanted know, how this board is booting ?
If you look at board-generic.c you will see that ti,omap3 will match
the OMAP3 generic machine. So you don't need to modify the board-generic.c.
According to this omap3-beagle.dts and omap3-beagle-xm.dts are also
booting in some way. So it is not clear to me, why there two
DT_MACHINE_START for omap3. I have seen there is only one
different in init_time for the same.
Hi Anil,
You may take a look to commit:
7dd9d50 ARM: OMAP3: Add generic machine descriptor for boards with
OMAP3 GP device
So, the second DT_MACHINE_START is meant to be used by OMAP3 boards
which use GP devices and this is not the case for ti,omap3430-sdp
afaiu.
I wonder if instead of adding each OMAP3 board with GP devices such as
ti,omap3-beagle, is not better to have a ti,omap3-gp compatible
property.
Sound good to me.
@Benoit,
Is this makes any sense for you?
The whole point of DT is to decouple the hardware description from the
kernel code so in general we should use the more generic compatible
string (ti,omap3) unless the hardware has some specifics that have
to be addressed, such as these boards that use GP devices.
Thanks you very much. It really help full for me.
Thanks,
Anil
RE: [PATCH 4/9] ARM: dts: OMAP3: Add support for OMAP3430 SDP board
On Wed, Mar 13, 2013 at 02:57:04, Hunter, Jon wrote:
On 03/11/2013 09:42 PM, Kumar, Anil wrote:
On Mon, Mar 11, 2013 at 23:23:32, Hunter, Jon wrote:
On 03/08/2013 08:25 PM, Anil Kumar wrote:
Hi Jon,
On Fri, Mar 8, 2013 at 10:57 PM, Jon Hunter jon-hun...@ti.com wrote:
Adds basic device-tree support for OMAP3430 SDP board which has 256MB
of RAM and uses the TWL4030 power management IC.
I think this board support should be in separate patch series with
related patches.
Well I wanted to keep them altogether so that I can send a pull request
to Benoit and Tony.
Sorry, but can you please tell what makes you to think that you
can send pull request only when they are altogether ?
That's not the point.
Is there any logical dependency with other patches except
[PATCH 6/9] ARM: dts: Add OMAP3430 SDP flash memory bindings is on
top of this patch ?
Per the $subject of the series these a various DT patches I have pending.
Yes I could break this series up into many separate series, one for PMU,
one for DMA, one for GPMC, one for OMAP3 SDP, but I thought it would be
easier for Tony and Benoit to pull as a single series.
I am really Sorry, If I said any nonsense here. I did not know that
we can do like that also.
Thanks,
Anil
N�r��yb�X��ǧv�^�){.n�+{��f��{ay� ʇڙ�,j��f���h���z� �w���
���j:+v���w�j�mzZ+�ݢj��!�i
Re: [PATCH 4/9] ARM: dts: OMAP3: Add support for OMAP3430 SDP board
On 03/08/2013 08:25 PM, Anil Kumar wrote:
Hi Jon,
On Fri, Mar 8, 2013 at 10:57 PM, Jon Hunter jon-hun...@ti.com wrote:
Adds basic device-tree support for OMAP3430 SDP board which has 256MB
of RAM and uses the TWL4030 power management IC.
I think this board support should be in separate patch series with
related patches.
Well I wanted to keep them altogether so that I can send a pull request
to Benoit and Tony.
Signed-off-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/omap3430-sdp.dts | 46
2 files changed, 47 insertions(+)
create mode 100644 arch/arm/boot/dts/omap3430-sdp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 9c62558..89013ed 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -119,6 +119,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
omap3-beagle-xm.dtb \
omap3-evm.dtb \
omap3-tobi.dtb \
+ omap3430-sdp.dtb \
omap4-panda.dtb \
omap4-panda-a4.dtb \
omap4-panda-es.dtb \
diff --git a/arch/arm/boot/dts/omap3430-sdp.dts
b/arch/arm/boot/dts/omap3430-sdp.dts
new file mode 100644
index 000..be0650d
--- /dev/null
+++ b/arch/arm/boot/dts/omap3430-sdp.dts
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ omap3.dtsi
+
+/ {
+ model = TI OMAP3430 SDP;
+ compatible = ti,omap3430-sdp, ti,omap3;
I have not seen any related changes in board-generic.c for your board.
So just wanted know, how this board is booting ?
If you look at board-generic.c you will see that ti,omap3 will match
the OMAP3 generic machine. So you don't need to modify the board-generic.c.
+
+ memory {
+ device_type = memory;
+ reg = 0x8000 0x1000; /* 256 MB */
+ };
+};
+
+i2c1 {
+ clock-frequency = 260;
+
+ twl: twl@48 {
+ reg = 0x48;
+ interrupts = 7; /* SYS_NIRQ cascaded to intc */
+ interrupt-parent = intc;
+ };
+};
+
+/include/ twl4030.dtsi
+
+mmc1 {
+ vmmc-supply = vmmc1;
+ vmmc_aux-supply = vsim;
+ bus-width = 8;
+};
+
+mmc2 {
+ status = disabled;
+};
+
+mmc3 {
+ status = disabled;
+};
I think you should disable modules those are not currently used
as they are enabled by default in omap3.dtsi.
exp:-
mcbsp2 {
status = disabled;
};
Well may be we could do that in a follow-up patch. If you look at other
omap3 boards we have not gone through and disabled all unused modules
either. So although I agree, right now I just want to get minimal
support added.
Jon
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/9] ARM: dts: OMAP3: Add support for OMAP3430 SDP board
On 03/10/2013 09:45 PM, Anil Kumar wrote:
Hi Jon,
On Fri, Mar 8, 2013 at 10:57 PM, Jon Hunter jon-hun...@ti.com wrote:
Adds basic device-tree support for OMAP3430 SDP board which has 256MB
of RAM and uses the TWL4030 power management IC.
Signed-off-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/omap3430-sdp.dts | 46
2 files changed, 47 insertions(+)
create mode 100644 arch/arm/boot/dts/omap3430-sdp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 9c62558..89013ed 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -119,6 +119,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
omap3-beagle-xm.dtb \
omap3-evm.dtb \
omap3-tobi.dtb \
+ omap3430-sdp.dtb \
omap4-panda.dtb \
omap4-panda-a4.dtb \
omap4-panda-es.dtb \
diff --git a/arch/arm/boot/dts/omap3430-sdp.dts
b/arch/arm/boot/dts/omap3430-sdp.dts
new file mode 100644
index 000..be0650d
--- /dev/null
+++ b/arch/arm/boot/dts/omap3430-sdp.dts
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ omap3.dtsi
+
+/ {
+ model = TI OMAP3430 SDP;
+ compatible = ti,omap3430-sdp, ti,omap3;
+
+ memory {
+ device_type = memory;
+ reg = 0x8000 0x1000; /* 256 MB */
+ };
+};
+
+i2c1 {
+ clock-frequency = 260;
+
+ twl: twl@48 {
+ reg = 0x48;
+ interrupts = 7; /* SYS_NIRQ cascaded to intc */
+ interrupt-parent = intc;
No need of interrupt-parent = intc as it is with root node
already.
Yes you are correct. Will update.
Thanks
Jon
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 4/9] ARM: dts: OMAP3: Add support for OMAP3430 SDP board
On Mon, Mar 11, 2013 at 23:23:32, Hunter, Jon wrote:
On 03/08/2013 08:25 PM, Anil Kumar wrote:
Hi Jon,
On Fri, Mar 8, 2013 at 10:57 PM, Jon Hunter jon-hun...@ti.com wrote:
Adds basic device-tree support for OMAP3430 SDP board which has 256MB
of RAM and uses the TWL4030 power management IC.
I think this board support should be in separate patch series with
related patches.
Well I wanted to keep them altogether so that I can send a pull request
to Benoit and Tony.
Sorry, but can you please tell what makes you to think that you
can send pull request only when they are altogether ?
Is there any logical dependency with other patches except
[PATCH 6/9] ARM: dts: Add OMAP3430 SDP flash memory bindings is on
top of this patch ?
Signed-off-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/omap3430-sdp.dts | 46
2 files changed, 47 insertions(+)
create mode 100644 arch/arm/boot/dts/omap3430-sdp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 9c62558..89013ed 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -119,6 +119,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
omap3-beagle-xm.dtb \
omap3-evm.dtb \
omap3-tobi.dtb \
+ omap3430-sdp.dtb \
omap4-panda.dtb \
omap4-panda-a4.dtb \
omap4-panda-es.dtb \
diff --git a/arch/arm/boot/dts/omap3430-sdp.dts
b/arch/arm/boot/dts/omap3430-sdp.dts
new file mode 100644
index 000..be0650d
--- /dev/null
+++ b/arch/arm/boot/dts/omap3430-sdp.dts
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ omap3.dtsi
+
+/ {
+ model = TI OMAP3430 SDP;
+ compatible = ti,omap3430-sdp, ti,omap3;
I have not seen any related changes in board-generic.c for your board.
So just wanted know, how this board is booting ?
If you look at board-generic.c you will see that ti,omap3 will match
the OMAP3 generic machine. So you don't need to modify the board-generic.c.
According to this omap3-beagle.dts and omap3-beagle-xm.dts are also
booting in some way. So it is not clear to me, why there two
DT_MACHINE_START for omap3. I have seen there is only one
different in init_time for the same.
+
+ memory {
+ device_type = memory;
+ reg = 0x8000 0x1000; /* 256 MB */
+ };
+};
+
+i2c1 {
+ clock-frequency = 260;
+
+ twl: twl@48 {
+ reg = 0x48;
+ interrupts = 7; /* SYS_NIRQ cascaded to intc */
+ interrupt-parent = intc;
+ };
+};
+
+/include/ twl4030.dtsi
+
+mmc1 {
+ vmmc-supply = vmmc1;
+ vmmc_aux-supply = vsim;
+ bus-width = 8;
+};
+
+mmc2 {
+ status = disabled;
+};
+
+mmc3 {
+ status = disabled;
+};
I think you should disable modules those are not currently used
as they are enabled by default in omap3.dtsi.
exp:-
mcbsp2 {
status = disabled;
};
Well may be we could do that in a follow-up patch. If you look at other
omap3 boards we have not gone through and disabled all unused modules
either. So although I agree, right now I just want to get minimal
support added.
Hmm... But it makes the kernel to call unused driver probe and get failed
those required some platform date from DT? you can see the kernel boot logs.
Thanks,
Anil
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/9] ARM: dts: OMAP3: Add support for OMAP3430 SDP board
Hi Jon,
On Fri, Mar 8, 2013 at 10:57 PM, Jon Hunter jon-hun...@ti.com wrote:
Adds basic device-tree support for OMAP3430 SDP board which has 256MB
of RAM and uses the TWL4030 power management IC.
Signed-off-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/omap3430-sdp.dts | 46
2 files changed, 47 insertions(+)
create mode 100644 arch/arm/boot/dts/omap3430-sdp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 9c62558..89013ed 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -119,6 +119,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
omap3-beagle-xm.dtb \
omap3-evm.dtb \
omap3-tobi.dtb \
+ omap3430-sdp.dtb \
omap4-panda.dtb \
omap4-panda-a4.dtb \
omap4-panda-es.dtb \
diff --git a/arch/arm/boot/dts/omap3430-sdp.dts
b/arch/arm/boot/dts/omap3430-sdp.dts
new file mode 100644
index 000..be0650d
--- /dev/null
+++ b/arch/arm/boot/dts/omap3430-sdp.dts
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ omap3.dtsi
+
+/ {
+ model = TI OMAP3430 SDP;
+ compatible = ti,omap3430-sdp, ti,omap3;
+
+ memory {
+ device_type = memory;
+ reg = 0x8000 0x1000; /* 256 MB */
+ };
+};
+
+i2c1 {
+ clock-frequency = 260;
+
+ twl: twl@48 {
+ reg = 0x48;
+ interrupts = 7; /* SYS_NIRQ cascaded to intc */
+ interrupt-parent = intc;
No need of interrupt-parent = intc as it is with root node
already.
Thanks,
Anil
[...]
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/9] ARM: dts: OMAP3: Add support for OMAP3430 SDP board
Hi Jon,
On Fri, Mar 8, 2013 at 10:57 PM, Jon Hunter jon-hun...@ti.com wrote:
Adds basic device-tree support for OMAP3430 SDP board which has 256MB
of RAM and uses the TWL4030 power management IC.
I think this board support should be in separate patch series with
related patches.
Signed-off-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/omap3430-sdp.dts | 46
2 files changed, 47 insertions(+)
create mode 100644 arch/arm/boot/dts/omap3430-sdp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 9c62558..89013ed 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -119,6 +119,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
omap3-beagle-xm.dtb \
omap3-evm.dtb \
omap3-tobi.dtb \
+ omap3430-sdp.dtb \
omap4-panda.dtb \
omap4-panda-a4.dtb \
omap4-panda-es.dtb \
diff --git a/arch/arm/boot/dts/omap3430-sdp.dts
b/arch/arm/boot/dts/omap3430-sdp.dts
new file mode 100644
index 000..be0650d
--- /dev/null
+++ b/arch/arm/boot/dts/omap3430-sdp.dts
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ omap3.dtsi
+
+/ {
+ model = TI OMAP3430 SDP;
+ compatible = ti,omap3430-sdp, ti,omap3;
I have not seen any related changes in board-generic.c for your board.
So just wanted know, how this board is booting ?
+
+ memory {
+ device_type = memory;
+ reg = 0x8000 0x1000; /* 256 MB */
+ };
+};
+
+i2c1 {
+ clock-frequency = 260;
+
+ twl: twl@48 {
+ reg = 0x48;
+ interrupts = 7; /* SYS_NIRQ cascaded to intc */
+ interrupt-parent = intc;
+ };
+};
+
+/include/ twl4030.dtsi
+
+mmc1 {
+ vmmc-supply = vmmc1;
+ vmmc_aux-supply = vsim;
+ bus-width = 8;
+};
+
+mmc2 {
+ status = disabled;
+};
+
+mmc3 {
+ status = disabled;
+};
I think you should disable modules those are not currently used
as they are enabled by default in omap3.dtsi.
exp:-
mcbsp2 {
status = disabled;
};
--
1.7.10.4
___
devicetree-discuss mailing list
devicetree-disc...@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
