Re: [PATCH 8/9] OMAP2: add board file for Nokia N800 and N810
On Fri, Aug 14, 2009 at 2:08 PM, Tony Lindgrent...@atomide.com wrote:
+static struct musb_hdrc_platform_data tusb_data = {
+ .mode = BOARD_MODE,
+ .set_power = tusb_set_power,
+ .set_clock = tusb_set_clock,
+ .min_power = 25, /* x2 = 50 mA drawn from VBUS as peripheral */
+ .power = 100, /* Max 100 mA VBUS for host mode */
+ .clock = osc_ck,
Still passing clock names around?
Sorry, I'm not familiar with this. How should I fix it?
This should be fixed with the clkdev alias, see omap24xx_clks[].
But we need to check how the fix affects other platforms for
drivers/usb/musb/musb_core.c and send the patch via linux-usb.
Maybe take a quick look, and if it looks like a bigger change,
then leave out the tusb_data for now and let's do it in a separate
patch?
Thanks, I'll take a look.
Tony, do you want me to send v2?
Sure, it's best that you update it.
I'll send v2 later today.
Kalle
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 8/9] OMAP2: add board file for Nokia N800 and N810
Tony Lindgren t...@atomide.com writes: Still passing clock names around? Sorry, I'm not familiar with this. How should I fix it? This should be fixed with the clkdev alias, see omap24xx_clks[]. But we need to check how the fix affects other platforms for drivers/usb/musb/musb_core.c and send the patch via linux-usb. Maybe take a quick look, and if it looks like a bigger change, then leave out the tusb_data for now and let's do it in a separate patch? I'm not familiar enough the clock framework and right now I don't have enough time to study it properly. So I decided to remove tusb_data and also rest of the now unusable usb code from the board file. I'll send a v2 shortly. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 8/9] OMAP2: add board file for Nokia N800 and N810
Russell King - ARM Linux li...@arm.linux.org.uk writes:
On Tue, Aug 11, 2009 at 12:55:58PM +0300, Tony Lindgren wrote:
+#include mach/gpio.h
linux/gpio.h
+#include mach/io.h
linux/io.h
Thanks, will fix.
+static struct musb_hdrc_platform_data tusb_data = {
+.mode = BOARD_MODE,
+.set_power = tusb_set_power,
+.set_clock = tusb_set_clock,
+.min_power = 25, /* x2 = 50 mA drawn from VBUS as peripheral */
+.power = 100, /* Max 100 mA VBUS for host mode */
+.clock = osc_ck,
Still passing clock names around?
Sorry, I'm not familiar with this. How should I fix it?
Tony, do you want me to send v2?
--
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 8/9] OMAP2: add board file for Nokia N800 and N810
* Kalle Valo kalle.v...@iki.fi [090814 09:01]:
Russell King - ARM Linux li...@arm.linux.org.uk writes:
On Tue, Aug 11, 2009 at 12:55:58PM +0300, Tony Lindgren wrote:
+#include mach/gpio.h
linux/gpio.h
+#include mach/io.h
linux/io.h
Thanks, will fix.
+static struct musb_hdrc_platform_data tusb_data = {
+ .mode = BOARD_MODE,
+ .set_power = tusb_set_power,
+ .set_clock = tusb_set_clock,
+ .min_power = 25, /* x2 = 50 mA drawn from VBUS as peripheral */
+ .power = 100, /* Max 100 mA VBUS for host mode */
+ .clock = osc_ck,
Still passing clock names around?
Sorry, I'm not familiar with this. How should I fix it?
This should be fixed with the clkdev alias, see omap24xx_clks[].
But we need to check how the fix affects other platforms for
drivers/usb/musb/musb_core.c and send the patch via linux-usb.
Maybe take a quick look, and if it looks like a bigger change,
then leave out the tusb_data for now and let's do it in a separate
patch?
Tony, do you want me to send v2?
Sure, it's best that you update it.
Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 8/9] OMAP2: add board file for Nokia N800 and N810
On Tue, Aug 11, 2009 at 12:55:58PM +0300, Tony Lindgren wrote:
+#include mach/gpio.h
linux/gpio.h
+#include mach/io.h
linux/io.h
+static struct musb_hdrc_platform_data tusb_data = {
+ .mode = BOARD_MODE,
+ .set_power = tusb_set_power,
+ .set_clock = tusb_set_clock,
+ .min_power = 25, /* x2 = 50 mA drawn from VBUS as peripheral */
+ .power = 100, /* Max 100 mA VBUS for host mode */
+ .clock = osc_ck,
Still passing clock names around?
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
