Re: [PATCH v2 0/3] Add support for charging battery in Nokia RX-51

2013-11-19 Thread Sebastian Reichel
Hi Pali,

On Tue, Nov 19, 2013 at 11:18:02AM +0100, Pali Rohár wrote:
 This patch series finally bringing support for charging battery on
 Nokia N900 (RX-51) without any proprietary Nokia bits in userspace.

YAY! :)

 I removed hook function from bq2415x_charger driver and replaced it
 by Jenny TC power_supply notifier code. This simplify usage of
 bq2415x driver and also allow adding DT support in future because
 driver does not need board specific function anymore (only static data).
 
 I tested this series with linux 3.12-rc5 on Nokia N900.

cool :)

Do you want me to take this up and add DT support?

-- Sebastian


signature.asc
Description: Digital signature


Re: [PATCH v2 0/3] Add support for charging battery in Nokia RX-51

2013-11-19 Thread Tony Lindgren
* Sebastian Reichel s...@debian.org [131119 06:45]:
 Hi Pali,
 
 On Tue, Nov 19, 2013 at 11:18:02AM +0100, Pali Rohár wrote:
  This patch series finally bringing support for charging battery on
  Nokia N900 (RX-51) without any proprietary Nokia bits in userspace.
 
 YAY! :)
 
  I removed hook function from bq2415x_charger driver and replaced it
  by Jenny TC power_supply notifier code. This simplify usage of
  bq2415x driver and also allow adding DT support in future because
  driver does not need board specific function anymore (only static data).
  
  I tested this series with linux 3.12-rc5 on Nokia N900.
 
 cool :)
 
 Do you want me to take this up and add DT support?

Great news, yeah let's add this with DT support instead as we're
planning to switch over to DT only booting anyways. The values can be
probably set directly in the charger driver based on the compatible
flag.

Note that we can also still add the I2C devices as needed from
the pdata-quirks.c, but in this case there should not be any need
for it :)

Regards,

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 0/3] Add support for charging battery in Nokia RX-51

2013-11-19 Thread Pali Rohár
On Tuesday 19 November 2013 15:44:09 Sebastian Reichel wrote:
 Hi Pali,
 
 On Tue, Nov 19, 2013 at 11:18:02AM +0100, Pali Rohár wrote:
  This patch series finally bringing support for charging
  battery on Nokia N900 (RX-51) without any proprietary Nokia
  bits in userspace.
 
 YAY! :)
 
  I removed hook function from bq2415x_charger driver and
  replaced it by Jenny TC power_supply notifier code. This
  simplify usage of bq2415x driver and also allow adding DT
  support in future because driver does not need board
  specific function anymore (only static data).
  
  I tested this series with linux 3.12-rc5 on Nokia N900.
 
 cool :)
 
 Do you want me to take this up and add DT support?
 
 -- Sebastian

Hello, if you have time, can you add DT support code?

-- 
Pali Rohár
pali.ro...@gmail.com


signature.asc
Description: This is a digitally signed message part.