Re: [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage
* Ivan Djelic ivan.dje...@parrot.com [121010 09:40]: I ran several mtd regression tests on a Beagle Board on your gpmc-czimage-v2 tag. All BCH error correcting tests passed successfully. I occasionally had weird read errors though, especially when reading blank pages: the omap driver returned 512-byte sectors containing something like: 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff instead of: I was able to reproduce the problem also on l2-mtd tip, albeit less often. The problem seems to occur quite randomly, it may be a hardware issue on my board... Things like this typically happen in the GPMC timings are not correct. Maybe add #define DEBUG to top of gpmc.c and compare the timings before and after Afzal's patches? Anyway, the ECC handling part looks OK to me. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage
Hi Ivan, On Tuesday 16 October 2012 11:36 PM, Tony Lindgren wrote: * Ivan Djelicivan.dje...@parrot.com [121010 09:40]: I ran several mtd regression tests on a Beagle Board on your gpmc-czimage-v2 tag. All BCH error correcting tests passed successfully. I occasionally had weird read errors though, especially when reading blank pages: the omap driver returned 512-byte sectors containing something like: I was able to reproduce the problem also on l2-mtd tip, albeit less often. The problem seems to occur quite randomly, it may be a hardware issue on my board... Things like this typically happen in the GPMC timings are not correct. Maybe add #define DEBUG to top of gpmc.c and compare the timings before and after Afzal's patches? Latest series for gpmc related cleanup for common zImage removed dependency on minor timing cleanups (this series was dependent on on another series that did minor timing cleanups). A pull request for the new series on gpmc cleanup for common zImage that does not contain timing related changes and without dependency on timing related changes has been sent to Tony (forwarded to you now). He has pulled those changes onto l-o in omap-for-v3.8/cleanup-headers-gpmc As there are no changes w.r.t timing's in the new series, behaviour should be same as without. Anyway, the ECC handling part looks OK to me. Regards Afzal -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage
On Mon, Oct 08, 2012 at 07:08:08AM +0100, Mohammed, Afzal wrote: Hi Ivan, On Mon, Oct 08, 2012 at 11:05:56, Mohammed, Afzal wrote: This series cleans up omap-gpmc related code so that omap can be a part of common zImage. This series moves gpmc.h from plat-omap/include/plat to mach-omap2 so that header file is local. Patches 7 8 cleans up the already moved platform data header files to contain only platform data. Also gpmc-nand information is moved to nand platform data header. Patches 9-13 makes nand driver independent of gpmc header file And the final patch localizes gpmc header. BCH[48] support that you have added on OMAP using gpmc exported symbols has been changed such that nand driver now takes care of BCH support without relying on gpmc exported symbols. This is more or less a cut paste of your implementation, which was necessitated now due to common ARM zImage cleanup w.r.t header files. Please verify that BCH[48] works as earlier with this series. Hi Afzal, I ran several mtd regression tests on a Beagle Board on your gpmc-czimage-v2 tag. All BCH error correcting tests passed successfully. I occasionally had weird read errors though, especially when reading blank pages: the omap driver returned 512-byte sectors containing something like: 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff 30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff instead of: I was able to reproduce the problem also on l2-mtd tip, albeit less often. The problem seems to occur quite randomly, it may be a hardware issue on my board... Anyway, the ECC handling part looks OK to me. Best regards, -- Ivan -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage
On Wed, Oct 10, 2012 at 22:08:41, Ivan Djelic wrote: On Mon, Oct 08, 2012 at 07:08:08AM +0100, Mohammed, Afzal wrote: Please verify that BCH[48] works as earlier with this series. I ran several mtd regression tests on a Beagle Board on your gpmc-czimage-v2 tag. All BCH error correcting tests passed successfully. I occasionally had weird read errors though, especially when reading blank pages: the omap driver returned 512-byte sectors containing something like: I was able to reproduce the problem also on l2-mtd tip, albeit less often. The problem seems to occur quite randomly, it may be a hardware issue on my board... Anyway, the ECC handling part looks OK to me. Thanks Ivan Regards Afzal
RE: [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage
Hi Ivan,
On Mon, Oct 08, 2012 at 11:05:56, Mohammed, Afzal wrote:
This series cleans up omap-gpmc related code so that omap can
be a part of common zImage.
This series moves gpmc.h from plat-omap/include/plat to mach-omap2
so that header file is local.
Patches 7 8 cleans up the already moved platform data header files
to contain only platform data. Also gpmc-nand information is moved
to nand platform data header.
Patches 9-13 makes nand driver independent of gpmc header file
And the final patch localizes gpmc header.
BCH[48] support that you have added on OMAP using gpmc exported
symbols has been changed such that nand driver now takes care
of BCH support without relying on gpmc exported symbols.
This is more or less a cut paste of your implementation, which was
necessitated now due to common ARM zImage cleanup w.r.t header files.
Please verify that BCH[48] works as earlier with this series.
Regards
Afzal
This series is available
@ git://gitorious.org/x0148406-public/linux-kernel.git gpmc-czimage-v2
and is based on
linux-next (next-20121005)
and is dependent on
http://marc.info/?l=linux-omapm=134945131602622w=2
N�r��yb�X��ǧv�^�){.n�+{��f��{ay� ʇڙ�,j��f���h���z� �w���
���j:+v���w�j�mzZ+�ݢj��!�i
