Re: [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle
* Suman Anna s-a...@ti.com [150805 08:35]: Hi Tony, On 08/05/2015 05:28 AM, Tony Lindgren wrote: * Dave Gerlach d-gerl...@ti.com [150717 13:59]: --- a/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt +++ b/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt @@ -75,6 +75,14 @@ data that represent the following: Cell #3 (usr_id) - mailbox user id for identifying the interrupt line associated with generating a tx/rx fifo interrupt. +Optional Properties: + +- ti,mbox-send-noirq: Quirk flag to allow the client user of this sub-mailbox +to send messages without triggering a Tx ready interrupt, +and to control the Tx ticker. Should be used only on +sub-mailboxes used to communicate with WkupM3 remote +processor on AM33xx/AM43xx SoCs. + Hmm can't you do this just by setting a flag in the device driver based on the compatible string? We can't because there can be other users like PRUSS which will use a sub-mailbox in a regular fashion. The compatible serves the IP and there can be multiple sub-mailboxes underneath it, and this quirk is needed only on the one that's used by the WkupM3. OK Do you have any comments on this? Up to you guys then to figure out what property is used for it then. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle
* Dave Gerlach d-gerl...@ti.com [150717 13:59]: --- a/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt +++ b/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt @@ -75,6 +75,14 @@ data that represent the following: Cell #3 (usr_id) - mailbox user id for identifying the interrupt line associated with generating a tx/rx fifo interrupt. +Optional Properties: + +- ti,mbox-send-noirq: Quirk flag to allow the client user of this sub-mailbox +to send messages without triggering a Tx ready interrupt, +and to control the Tx ticker. Should be used only on +sub-mailboxes used to communicate with WkupM3 remote +processor on AM33xx/AM43xx SoCs. + Hmm can't you do this just by setting a flag in the device driver based on the compatible string? Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle
Hi Tony, On 08/05/2015 05:28 AM, Tony Lindgren wrote: * Dave Gerlach d-gerl...@ti.com [150717 13:59]: --- a/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt +++ b/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt @@ -75,6 +75,14 @@ data that represent the following: Cell #3 (usr_id) - mailbox user id for identifying the interrupt line associated with generating a tx/rx fifo interrupt. +Optional Properties: + +- ti,mbox-send-noirq: Quirk flag to allow the client user of this sub-mailbox +to send messages without triggering a Tx ready interrupt, +and to control the Tx ticker. Should be used only on +sub-mailboxes used to communicate with WkupM3 remote +processor on AM33xx/AM43xx SoCs. + Hmm can't you do this just by setting a flag in the device driver based on the compatible string? We can't because there can be other users like PRUSS which will use a sub-mailbox in a regular fashion. The compatible serves the IP and there can be multiple sub-mailboxes underneath it, and this quirk is needed only on the one that's used by the WkupM3. Jassi, Do you have any comments on this? regards Suman -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html