Re: [PATCHv3 2/9] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking

2012-06-04 Thread Tero Kristo 
On Fri, 2012-06-01 at 04:27 -0600, Paul Walmsley wrote:
 On Fri, 1 Jun 2012, Menon, Nishanth wrote:
 
  On Thu, May 31, 2012 at 8:28 AM, Tero Kristo t-kri...@ti.com wrote:
  minor comment:
   +void pwrdm_clkdm_enable(struct powerdomain *pwrdm)
  snip
   +void pwrdm_clkdm_disable(struct powerdomain *pwrdm)
  
  I know the understand that rest of the code lacks kernel-doc,
 
 Almost all of the powerdomain code has kerneldoc present.
 
  but at least can we ensure that the new functions does?
 
 Indeed:
 
 http://www.spinics.net/lists/arm-kernel/msg164548.html

Mmm yea, I'll add those for next rev.

-Tero


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv3 2/9] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking

2012-06-01 Thread Menon, Nishanth 
On Thu, May 31, 2012 at 8:28 AM, Tero Kristo t-kri...@ti.com wrote:
minor comment:
 +void pwrdm_clkdm_enable(struct powerdomain *pwrdm)
snip
 +void pwrdm_clkdm_disable(struct powerdomain *pwrdm)

I know the understand that rest of the code lacks kernel-doc, but at
least can we ensure that the new functions does?

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv3 2/9] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking

2012-06-01 Thread Paul Walmsley 
On Fri, 1 Jun 2012, Menon, Nishanth wrote:

 On Thu, May 31, 2012 at 8:28 AM, Tero Kristo t-kri...@ti.com wrote:
 minor comment:
  +void pwrdm_clkdm_enable(struct powerdomain *pwrdm)
 snip
  +void pwrdm_clkdm_disable(struct powerdomain *pwrdm)
 
 I know the understand that rest of the code lacks kernel-doc,

Almost all of the powerdomain code has kerneldoc present.

 but at least can we ensure that the new functions does?

Indeed:

http://www.spinics.net/lists/arm-kernel/msg164548.html


- Paul
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html