Hi Manjunath,
Thanks for the review, Please find my response inline.
With Regards
Srinath
-Original Message-
From: G, Manjunath Kondaiah [mailto:manj...@ti.com]
Sent: Thursday, December 02, 2010 11:56 AM
To: srin...@mistralsolutions.com
Cc: linux-omap@vger.kernel.org; j...@ti.com; t...@atomide.com;
linux-ker...@vger.kernel.org; li...@arm.linux.org.uk;
linux-arm-ker...@lists.infradead.org; khil...@deeprootsystems.com;
n...@ti.com; nagen...@mistralsolutions.com; ume...@mistralsolutions.com
Subject: Re: [Patch v3] AM35xx: Craneboard: Add USB EHCI support
* srin...@mistralsolutions.com srin...@mistralsolutions.com [2010-12-01
22:28:50 +0530]:
From: Srinath srin...@mistralsolutions.com
AM3517/05 Craneboard has one EHCI interface on board using port1.
GPIO35 is used as power enable.
GPIO38 is used as port1 PHY reset.
History:
http://marc.info/?l=linux-omapw=2r=1s=Craneboard%3A+Add+USB+EHCI+support;
q=t
Signed-off-by: Srinath srin...@mistralsolutions.com
---
arch/arm/mach-omap2/board-am3517crane.c | 40
+++
1 files changed, 40 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-am3517crane.c
b/arch/arm/mach-omap2/board-am3517crane.c
index 13ead33..6fd5dfe 100644
--- a/arch/arm/mach-omap2/board-am3517crane.c
+++ b/arch/arm/mach-omap2/board-am3517crane.c
@@ -28,8 +28,13 @@
[...]
static void __init am3517_crane_init(void)
{
+ int ret;
+
omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
omap_serial_init();
+
+ /* Configure GPIO for EHCI port */
+ omap_mux_init_gpio(GPIO_USB_POWER, OMAP_PIN_OUTPUT);
This is non void function. You can consider return value for further
processing.
Srinath Sure, I will put check and resend patch
+
+ ret = gpio_request(GPIO_USB_POWER, usb_ehci_enable);
+ if (ret 0) {
+ pr_err(Cannot request GPIO %d\n, GPIO_USB_POWER);
+ return;
+ }
+
+ ret = gpio_direction_output(GPIO_USB_POWER, 1);
+ if (ret 0)
+ goto err;
+
+ omap_mux_init_gpio(GPIO_USB_NRESET, OMAP_PIN_OUTPUT);
-Ditto-
Srinath Sure, I will put check and resend patch
Also, why there is no gpio_request for GPIO_USB_NRESET
Srinath This is taken care by USB driver in drivers/usb/host/ehci-omap.c
-Manjunath
[...]
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
