Re: [Resending - PATCH 1/3] Triton BCI driver board/device setup for OMAP3430
* Felipe Balbi <[EMAIL PROTECTED]> [080805 17:06]: > On Tue, Aug 05, 2008 at 04:35:51PM +0300, Tony Lindgren wrote: > > * Felipe Balbi <[EMAIL PROTECTED]> [080723 10:32]: > > > > > > > > > On Wed, 23 Jul 2008 10:16:27 +0530, "Madhusudhan Chikkature" > > > <[EMAIL PROTECTED]> wrote: > > > > Hi Felipe, > > > > > > > >> Tony, weird that we still have these prototypes in these headers. > > > >> Could be some merging conflict ? > > > > Yes. I see that these prototypes are still present in the board3430 and > > > > board2430 header files in the omap tree. > > > > > > > >> Anyways, please apply the attached patch. We're using > > > >> usb_musb_init() and usb_ehci_init() now. > > > > You mean I should apply the attached patch you sent for local use, > > > > right? > > > > And I guess I dont need to resend this perticular BCI patch, am I > > > correct? > > > > > > No :-) > > > > > > that was to Tony. Just replied to your mail so it's easy to see why we > > > need > > > that patch :-) > > > > Pushing these today. Do you have a patch for moving the extern > > prototypes into the twl header? > > I was talking about these: > > From: Felipe Balbi <[EMAIL PROTECTED]> > > arch: omap: get rid of usb_init() protytpes > > we now use usb_musb_init() and usb_ehci_init() functions OK, thanks. Will push today. Tony > Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]> > --- > > diff --git a/include/asm-arm/arch-omap/board-2430sdp.h > b/include/asm-arm/arch-omap/board-2430sdp.h > index fde6915..83d0eec 100644 > --- a/include/asm-arm/arch-omap/board-2430sdp.h > +++ b/include/asm-arm/arch-omap/board-2430sdp.h > @@ -36,6 +36,5 @@ > > /* Function prototypes */ > extern void sdp2430_flash_init(void); > -extern void sdp2430_usb_init(void); > > #endif /* __ASM_ARCH_OMAP_2430SDP_H */ > diff --git a/include/asm-arm/arch-omap/board-3430sdp.h > b/include/asm-arm/arch-omap/board-3430sdp.h > index d583008..85f769e 100644 > --- a/include/asm-arm/arch-omap/board-3430sdp.h > +++ b/include/asm-arm/arch-omap/board-3430sdp.h > @@ -29,7 +29,6 @@ > #ifndef __ASM_ARCH_OMAP_3430SDP_H > #define __ASM_ARCH_OMAP_3430SDP_H > > -extern void sdp3430_usb_init(void); > extern void sdp3430_flash_init(void); > > #define DEBUG_BASE 0x0800 /* debug board */ > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Resending - PATCH 1/3] Triton BCI driver board/device setup for OMAP3430
On Tue, Aug 05, 2008 at 04:35:51PM +0300, Tony Lindgren wrote: > * Felipe Balbi <[EMAIL PROTECTED]> [080723 10:32]: > > > > > > On Wed, 23 Jul 2008 10:16:27 +0530, "Madhusudhan Chikkature" > > <[EMAIL PROTECTED]> wrote: > > > Hi Felipe, > > > > > >> Tony, weird that we still have these prototypes in these headers. > > >> Could be some merging conflict ? > > > Yes. I see that these prototypes are still present in the board3430 and > > > board2430 header files in the omap tree. > > > > > >> Anyways, please apply the attached patch. We're using > > >> usb_musb_init() and usb_ehci_init() now. > > > You mean I should apply the attached patch you sent for local use, right? > > > And I guess I dont need to resend this perticular BCI patch, am I > > correct? > > > > No :-) > > > > that was to Tony. Just replied to your mail so it's easy to see why we need > > that patch :-) > > Pushing these today. Do you have a patch for moving the extern > prototypes into the twl header? I was talking about these: From: Felipe Balbi <[EMAIL PROTECTED]> arch: omap: get rid of usb_init() protytpes we now use usb_musb_init() and usb_ehci_init() functions Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]> --- diff --git a/include/asm-arm/arch-omap/board-2430sdp.h b/include/asm-arm/arch-omap/board-2430sdp.h index fde6915..83d0eec 100644 --- a/include/asm-arm/arch-omap/board-2430sdp.h +++ b/include/asm-arm/arch-omap/board-2430sdp.h @@ -36,6 +36,5 @@ /* Function prototypes */ extern void sdp2430_flash_init(void); -extern void sdp2430_usb_init(void); #endif /* __ASM_ARCH_OMAP_2430SDP_H */ diff --git a/include/asm-arm/arch-omap/board-3430sdp.h b/include/asm-arm/arch-omap/board-3430sdp.h index d583008..85f769e 100644 --- a/include/asm-arm/arch-omap/board-3430sdp.h +++ b/include/asm-arm/arch-omap/board-3430sdp.h @@ -29,7 +29,6 @@ #ifndef __ASM_ARCH_OMAP_3430SDP_H #define __ASM_ARCH_OMAP_3430SDP_H -extern void sdp3430_usb_init(void); extern void sdp3430_flash_init(void); #define DEBUG_BASE 0x0800 /* debug board */ -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Resending - PATCH 1/3] Triton BCI driver board/device setup for OMAP3430
* Felipe Balbi <[EMAIL PROTECTED]> [080723 10:32]: > > > On Wed, 23 Jul 2008 10:16:27 +0530, "Madhusudhan Chikkature" > <[EMAIL PROTECTED]> wrote: > > Hi Felipe, > > > >> Tony, weird that we still have these prototypes in these headers. > >> Could be some merging conflict ? > > Yes. I see that these prototypes are still present in the board3430 and > > board2430 header files in the omap tree. > > > >> Anyways, please apply the attached patch. We're using > >> usb_musb_init() and usb_ehci_init() now. > > You mean I should apply the attached patch you sent for local use, right? > > And I guess I dont need to resend this perticular BCI patch, am I > correct? > > No :-) > > that was to Tony. Just replied to your mail so it's easy to see why we need > that patch :-) Pushing these today. Do you have a patch for moving the extern prototypes into the twl header? Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Resending - PATCH 1/3] Triton BCI driver board/device setup for OMAP3430
On Wed, 23 Jul 2008 10:16:27 +0530, "Madhusudhan Chikkature" <[EMAIL PROTECTED]> wrote: > Hi Felipe, > >> Tony, weird that we still have these prototypes in these headers. >> Could be some merging conflict ? > Yes. I see that these prototypes are still present in the board3430 and > board2430 header files in the omap tree. > >> Anyways, please apply the attached patch. We're using >> usb_musb_init() and usb_ehci_init() now. > You mean I should apply the attached patch you sent for local use, right? > And I guess I dont need to resend this perticular BCI patch, am I correct? No :-) that was to Tony. Just replied to your mail so it's easy to see why we need that patch :-) -- Best Regards, Felipe Balbi http://blog.felipebalbi.com [EMAIL PROTECTED] -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Resending - PATCH 1/3] Triton BCI driver board/device setup for OMAP3430
Hi Felipe, > Tony, weird that we still have these prototypes in these headers. > Could be some merging conflict ? Yes. I see that these prototypes are still present in the board3430 and board2430 header files in the omap tree. > Anyways, please apply the attached patch. We're using > usb_musb_init() and usb_ehci_init() now. You mean I should apply the attached patch you sent for local use, right? And I guess I dont need to resend this perticular BCI patch, am I correct? Regards, Madhu - Original Message - From: "Felipe Balbi" <[EMAIL PROTECTED]> To: "Tony Lindgren" <[EMAIL PROTECTED]> Cc: "Madhusudhan Chikkature" <[EMAIL PROTECTED]>; ; <[EMAIL PROTECTED]> Sent: Tuesday, July 22, 2008 6:03 PM Subject: Re: [Resending - PATCH 1/3] Triton BCI driver board/device setup for OMAP3430 > Hi, > > > On Tue, 22 Jul 2008 17:25:33 +0530 (IST), "Madhusudhan Chikkature" > <[EMAIL PROTECTED]> wrote: >> extern void sdp3430_usb_init(void); > > Tony, weird that we still have these prototypes in these headers. > Could be some merging conflict ? > > Anyways, please apply the attached patch. We're using > usb_musb_init() and usb_ehci_init() now. > > > > -- > Best Regards, > > Felipe Balbi > http://blog.felipebalbi.com > [EMAIL PROTECTED] -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Resending - PATCH 1/3] Triton BCI driver board/device setup for OMAP3430
Hi, On Tue, 22 Jul 2008 17:25:33 +0530 (IST), "Madhusudhan Chikkature" <[EMAIL PROTECTED]> wrote: > extern void sdp3430_usb_init(void); Tony, weird that we still have these prototypes in these headers. Could be some merging conflict ? Anyways, please apply the attached patch. We're using usb_musb_init() and usb_ehci_init() now. -- Best Regards, Felipe Balbi http://blog.felipebalbi.com [EMAIL PROTECTED]From cf96bd037227979a448e03779ec44d0c31c1fa29 Mon Sep 17 00:00:00 2001 From: Felipe Balbi <[EMAIL PROTECTED]> Date: Tue, 22 Jul 2008 15:07:08 +0300 Subject: [PATCH] arch: omap: remove unused prototypes We don't have those functions anymore. Probably some merge conflict put the prototypes back. Removing them. Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]> --- include/asm-arm/arch-omap/board-2430sdp.h |1 - include/asm-arm/arch-omap/board-3430sdp.h |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/asm-arm/arch-omap/board-2430sdp.h b/include/asm-arm/arch-omap/board-2430sdp.h index fde6915..83d0eec 100644 --- a/include/asm-arm/arch-omap/board-2430sdp.h +++ b/include/asm-arm/arch-omap/board-2430sdp.h @@ -36,6 +36,5 @@ /* Function prototypes */ extern void sdp2430_flash_init(void); -extern void sdp2430_usb_init(void); #endif /* __ASM_ARCH_OMAP_2430SDP_H */ diff --git a/include/asm-arm/arch-omap/board-3430sdp.h b/include/asm-arm/arch-omap/board-3430sdp.h index d583008..85f769e 100644 --- a/include/asm-arm/arch-omap/board-3430sdp.h +++ b/include/asm-arm/arch-omap/board-3430sdp.h @@ -29,7 +29,6 @@ #ifndef __ASM_ARCH_OMAP_3430SDP_H #define __ASM_ARCH_OMAP_3430SDP_H -extern void sdp3430_usb_init(void); extern void sdp3430_flash_init(void); #define DEBUG_BASE 0x0800 /* debug board */ -- 1.5.6.1.156.ge903b
