Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Fri, Feb 20, 2009 at 3:23 PM, Gadiyar, Anand gadi...@ti.com wrote: Don't worry, you're not the only one TIred here... Grrr. I'm in no mood to take any TI puns right now. That was unwarranted. Was it? I agree with Felipe (Balbi) there's more people tired of this stuff. I don't know which way you would have preferred him to express his frustration, or maybe you don't want any negative feedback at all. So here's the quick mail you want: I may or may not be able to clean up this driver in the near future. Felipe Balbi graciously agress to do it for us. So I am pleased to announce he will clean up this driver and send it upstream. If he needs any help with this, I will try to provide it to him (or anyone else for that matter) on a best-effort basis. Good luck. Anyways, I'll keep going with my cleanups and when I get a platform to test ehci, I'll try to test the patches and keep going with the workarounds. If you want help with testing, I can give it to you. If not, you can test it yourself - I couldn't care less. And you want me to agree with it ? I really was hoping we could work together with TI but seems I'm the only one who still believes in that. I made that offer - so there is at least one other believer of working together. You're the one that wants to do this on your own - and I'm okay with that. I don't know the history of this patch series, so perhaps I'm misinterpreting this, but it looks like he submitted some patches and you said it was the wrong way to do it and *you* would come up with a proper patch. A collaborative way to fix this issue would be to comment on the specific pieces of code you would want changed, perhaps even re-send the patches with the suggested changes so other people could review, comment, test, etc. This would probably generate a few rounds of patch series until it gets finally merged. Instead you said you where going to provide a proper fix and never did so. There might be valid reasons for not coming up with the patches (like the difficulty of the task), but there's no excuse for the lack of communication. As you said yourself, you couldn't care less right ? You couldn't care less if the driver works or not, you couldn't care less if we have good omap support out of mainline kernel, you couldn't care less if the driver is readable or not, etc etc etc. That's not true. I do care. It __is__ important to me that OMAP support goes to mainline. And I do not like it that it hasn't happened yet. Sorry. Personally I find your position to be not collaborative at all. Do you care or not? If you do, you could test Felipe's patches, review, comment, rewrite, etc. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Sun, Feb 22, 2009 at 7:21 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Feb 20, 2009 at 3:23 PM, Gadiyar, Anand gadi...@ti.com wrote: Don't worry, you're not the only one TIred here... Grrr. I'm in no mood to take any TI puns right now. That was unwarranted. Was it? I agree with Felipe (Balbi) there's more people tired of this stuff. I don't know which way you would have preferred him to express his frustration, or maybe you don't want any negative feedback at all. This comment was specific to the pun on TI. That pun was completely unwarranted. He's not the only one frustrated here. Just because I have an @ti.com id is not reason enough to blame all of TI. There are people in TI doing real work. So here's the quick mail you want: I may or may not be able to clean up this driver in the near future. Felipe Balbi graciously agress to do it for us. So I am pleased to announce he will clean up this driver and send it upstream. If he needs any help with this, I will try to provide it to him (or anyone else for that matter) on a best-effort basis. Good luck. Anyways, I'll keep going with my cleanups and when I get a platform to test ehci, I'll try to test the patches and keep going with the workarounds. If you want help with testing, I can give it to you. If not, you can test it yourself - I couldn't care less. And you want me to agree with it ? I really was hoping we could work together with TI but seems I'm the only one who still believes in that. I made that offer - so there is at least one other believer of working together. You're the one that wants to do this on your own - and I'm okay with that. I don't know the history of this patch series, so perhaps I'm misinterpreting this, but it looks like he submitted some patches and you said it was the wrong way to do it and *you* would come up with a proper patch. Then I suggest you read up the history. You __are__ misinterpreting this. He did not submit any patches. He had a list of some tens of drivers that he was planning to send to mainline sometime last September. I thought I'll save everyone some time and would take care of sending in at least the EHCI part so he could concentrate on other stuff that he was doing. Unfortunately, I got preempted more than once. A collaborative way to fix this issue would be to comment on the specific pieces of code you would want changed, perhaps even re-send the patches with the suggested changes so other people could review, comment, test, etc. This would probably generate a few rounds of patch series until it gets finally merged. I am not against collaboration. Felipe said on Friday that he could do the cleanups but had no way of testing. I do not have the bandwidth to do those changes myself, but I did offer to test it for him. If this is not collaboration, I do not know what is. Felipe got mad at me and said he would rather read the errata and implement it himself. And my response to that is above. If he wants to work on EHCI himself, that's great. It'll save me the trouble of testing and I'm guessing we'll see him return to the list 6 months from now, just like I did :) Reading up just the mail exchanges we've had on Friday is sufficient to show who wants to work alone and who wants to collaborate. Instead you said you where going to provide a proper fix and never did so. There might be valid reasons for not coming up with the patches (like the difficulty of the task), but there's no excuse for the lack of communication. As you said yourself, you couldn't care less right ? You couldn't care less if the driver works or not, you couldn't care less if we have good omap support out of mainline kernel, you couldn't care less if the driver is readable or not, etc etc etc. That's not true. I do care. It __is__ important to me that OMAP support goes to mainline. And I do not like it that it hasn't happened yet. Sorry. Personally I find your position to be not collaborative at all. Do you care or not? If you do, you could test Felipe's patches, review, comment, rewrite, etc. Read the history before making your comments dude. I __have__ offered to test. I do intend to spend time reviewing - but I will not guarantee it. Felipe's the one that flew off the handle before I did. Personally, I do not find it at all amusing that everytime someone @nokia.com gets shouted at on-list by someone @ti.com, all Nokia-ites gang up on the TI-er. Give us a break. It's not like we are against working with the community. - Anand -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
Hi, not trying to keep the thread alive, but... On Sun, Feb 22, 2009 at 09:29:30PM +0530, Anand Gadiyar wrote: Then I suggest you read up the history. You __are__ misinterpreting this. He did not submit any patches. He had a list of some tens of drivers that he was planning to send to mainline sometime last September. I thought I'll save everyone some time and would take care http://marc.info/?l=linux-omapm=122124472931396w=2 I've even mailed you and/or Vikram 4 patches on ehci for you make your patches on top of them. (can't really remember if you or Vikram was working on that driver at that time) of sending in at least the EHCI part so he could concentrate on other stuff that he was doing. Unfortunately, I got preempted more than once. heh, I know how that feels... -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Sun, Feb 22, 2009 at 10:20 PM, Felipe Balbi m...@felipebalbi.com wrote: Hi, not trying to keep the thread alive, but... On Sun, Feb 22, 2009 at 09:29:30PM +0530, Anand Gadiyar wrote: Then I suggest you read up the history. You __are__ misinterpreting this. He did not submit any patches. He had a list of some tens of drivers that he was planning to send to mainline sometime last September. I thought I'll save everyone some time and would take care http://marc.info/?l=linux-omapm=122124472931396w=2 I've even mailed you and/or Vikram 4 patches on ehci for you make your patches on top of them. (can't really remember if you or Vikram was working on that driver at that time) I must have missed the patchset, or I wasn't on the CC list. Anyway, let's end this here and figure out how to get the driver functional, cleaned-up and in mainline. I'm willing to help out in any way I can. I've got hardware if you would like to test something. I've got a decent bit of knowledge on the controller hardware, (plus tons of knowledge on it's failings ;) ) Plus partially done work... Let me know how you would like to go about this. - Anand P.S. I'm out of office taking my first break in months. I can only start once I get back next week. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Sun, Feb 22, 2009 at 10:34:03PM +0530, Anand Gadiyar wrote: I must have missed the patchset, or I wasn't on the CC list. Anyway, let's end this here and figure out how to get the driver functional, cleaned-up and in mainline. I'm willing to help out in any way I can. I've got hardware if you would like to test something. I've got a decent bit of knowledge on the controller hardware, (plus tons of knowledge on it's failings ;) ) Plus partially done work... Let me know how you would like to go about this. cool, mailed you a tarball with my preliminary patches. This should get ehci better for the eyes and hopefully I got rid of all infinite loops. Later I wanna work on getting AUTOIDLE re-enabled and get this driver reach off mode. P.S. I'm out of office taking my first break in months. I can only start once I get back next week. have fun ;-) -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Friday Feb 20, 2009 Grazvydas Ignotas wrote: On Fri, Feb 20, 2009 at 12:46 AM, Felipe Balbi m...@felipebalbi.com wrote: On Thu, Feb 19, 2009 at 02:43:36PM -0800, Steve Sakoman wrote: EHCI omap driver definitely needs some work - there is machine specific stuff in there that rightfully belongs in platform data. I haven't had time to work on it :-( For sure, and there's still workaround for clk framework stuff that should already move there. I'll try to start with some cleanups already during this weekend (yeah, I've got no life :-p) and post as RFT asap. After the cleanups are ok, then I'll start moving platform code out of there and for the clock workarounds I'll need help from Paul Walmsley, probably :-) Great, I'll be watching the list and gladly test them on pandora too. It would be nice to have those remote wakeup issues [1] sorted out too. 1: http://marc.info/?l=linux-omapm=122911571519657w=2 Sorry, that is not something that will be fixed in ES3.1. It also affects suspend-resume, not just remote-wakeup. However, there is a software workaround that is being tested right now - the one mentioned in the link does not work reliably. The new workaround should be ready shortly (maybe after Felipe is done with the cleanups he plans). - Anand -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Fri, Feb 20, 2009 at 11:44:25AM +0100, Anand Gadiyar wrote: On Friday Feb 20, 2009 Grazvydas Ignotas wrote: On Fri, Feb 20, 2009 at 12:46 AM, Felipe Balbi m...@felipebalbi.com wrote: On Thu, Feb 19, 2009 at 02:43:36PM -0800, Steve Sakoman wrote: EHCI omap driver definitely needs some work - there is machine specific stuff in there that rightfully belongs in platform data. I haven't had time to work on it :-( For sure, and there's still workaround for clk framework stuff that should already move there. I'll try to start with some cleanups already during this weekend (yeah, I've got no life :-p) and post as RFT asap. After the cleanups are ok, then I'll start moving platform code out of there and for the clock workarounds I'll need help from Paul Walmsley, probably :-) Great, I'll be watching the list and gladly test them on pandora too. It would be nice to have those remote wakeup issues [1] sorted out too. 1: http://marc.info/?l=linux-omapm=122911571519657w=2 Sorry, that is not something that will be fixed in ES3.1. It also affects suspend-resume, not just remote-wakeup. However, there is a software workaround that is being tested right now - the one mentioned in the link does not work reliably. The new workaround should be ready shortly (maybe after Felipe is done with the cleanups he plans). well, it's been about 5 months since you said TI would be doing such cleanups, I've even had my patches dropped at that time because of that and till now nothing happened. About the workaround, I'd rather read the errata myself and implement it. -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
snip well, it's been about 5 months since you said TI would be doing such cleanups, I've even had my patches dropped at that time because of that and till now nothing happened. About the workaround, I'd rather read the errata myself and implement it. Well, I've said time and again that I haven't been able to get around to it. You can read the errata yourself and implement it if you wish. Frankly, I don't give a damn. I've spent the last five months finding the workarounds for all the erratas affecting EHCI, which is __the whole reason__ why I have not been able to fix up the EHCI driver. - Anand -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Fri, Feb 20, 2009 at 01:40:32PM +0100, Anand Gadiyar wrote: snip well, it's been about 5 months since you said TI would be doing such cleanups, I've even had my patches dropped at that time because of that and till now nothing happened. About the workaround, I'd rather read the errata myself and implement it. Well, I've said time and again that I haven't been able to get around to it. You can read the errata yourself and implement it if you wish. Frankly, I don't give a damn. I've spent the last five months finding the workarounds for all the erratas affecting EHCI, which is __the whole reason__ why I have not been able to fix up the EHCI driver. A quick mail explaining that you wouldn't be able to fix ehci at that time would've been enough to avoid it. Then we could have gotten it cleaned up and then just integrate your latest workarounds. Still, the driver will need lots of cleanups before we think about adding workarounds and we have to think about how to integrate the workarounds for different ehci/omap silicon revisions, etc... Anyways, I'll keep going with my cleanups and when I get a platform to test ehci, I'll try to test the patches and keep going with the workarounds. -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Fri, Feb 20, 2009 at 01:40:32PM +0100, Anand Gadiyar wrote: snip well, it's been about 5 months since you said TI would be doing such cleanups, I've even had my patches dropped at that time because of that and till now nothing happened. About the workaround, I'd rather read the errata myself and implement it. Well, I've said time and again that I haven't been able to get around to it. You can read the errata yourself and implement it if you wish. Frankly, I don't give a damn. I've spent the last five months finding the workarounds for all the erratas affecting EHCI, which is __the whole reason__ why I have not been able to fix up the EHCI driver. A quick mail explaining that you wouldn't be able to fix ehci at that time would've been enough to avoid it. Then we could have gotten it cleaned up and then just integrate your latest workarounds. Still, the driver will need lots of cleanups before we think about adding workarounds and we have to think about how to integrate the workarounds for different ehci/omap silicon revisions, etc... Well, the way it went was I discovered errata after errata. Everytime I thought this is the last one and I can finally get around to that cleanup, three days later I would end up working on the next failure. I've spent so much time on it, I'm sick of it. So here's the quick mail you want: I may or may not be able to clean up this driver in the near future. Felipe Balbi graciously agress to do it for us. So I am pleased to announce he will clean up this driver and send it upstream. If he needs any help with this, I will try to provide it to him (or anyone else for that matter) on a best-effort basis. Good luck. Anyways, I'll keep going with my cleanups and when I get a platform to test ehci, I'll try to test the patches and keep going with the workarounds. If you want help with testing, I can give it to you. If not, you can test it yourself - I couldn't care less. - Anand -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Fri, Feb 20, 2009 at 01:57:14PM +0100, Anand Gadiyar wrote: On Fri, Feb 20, 2009 at 01:40:32PM +0100, Anand Gadiyar wrote: snip well, it's been about 5 months since you said TI would be doing such cleanups, I've even had my patches dropped at that time because of that and till now nothing happened. About the workaround, I'd rather read the errata myself and implement it. Well, I've said time and again that I haven't been able to get around to it. You can read the errata yourself and implement it if you wish. Frankly, I don't give a damn. I've spent the last five months finding the workarounds for all the erratas affecting EHCI, which is __the whole reason__ why I have not been able to fix up the EHCI driver. A quick mail explaining that you wouldn't be able to fix ehci at that time would've been enough to avoid it. Then we could have gotten it cleaned up and then just integrate your latest workarounds. Still, the driver will need lots of cleanups before we think about adding workarounds and we have to think about how to integrate the workarounds for different ehci/omap silicon revisions, etc... Well, the way it went was I discovered errata after errata. Everytime I thought this is the last one and I can finally get around to that cleanup, three days later I would end up working on the next failure. I've spent so much time on it, I'm sick of it. Don't worry, you're not the only one TIred here... So here's the quick mail you want: I may or may not be able to clean up this driver in the near future. Felipe Balbi graciously agress to do it for us. So I am pleased to announce he will clean up this driver and send it upstream. If he needs any help with this, I will try to provide it to him (or anyone else for that matter) on a best-effort basis. Good luck. Anyways, I'll keep going with my cleanups and when I get a platform to test ehci, I'll try to test the patches and keep going with the workarounds. If you want help with testing, I can give it to you. If not, you can test it yourself - I couldn't care less. And you want me to agree with it ? I really was hoping we could work together with TI but seems I'm the only one who still believes in that. As you said yourself, you couldn't care less right ? You couldn't care less if the driver works or not, you couldn't care less if we have good omap support out of mainline kernel, you couldn't care less if the driver is readable or not, etc etc etc. I imagine if all of us would be taking the same behavior as you are... Well, I'm not here to flood the list discussing this kinds of issues with you. -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
Don't worry, you're not the only one TIred here... Grrr. I'm in no mood to take any TI puns right now. That was unwarranted. So here's the quick mail you want: I may or may not be able to clean up this driver in the near future. Felipe Balbi graciously agress to do it for us. So I am pleased to announce he will clean up this driver and send it upstream. If he needs any help with this, I will try to provide it to him (or anyone else for that matter) on a best-effort basis. Good luck. Anyways, I'll keep going with my cleanups and when I get a platform to test ehci, I'll try to test the patches and keep going with the workarounds. If you want help with testing, I can give it to you. If not, you can test it yourself - I couldn't care less. And you want me to agree with it ? I really was hoping we could work together with TI but seems I'm the only one who still believes in that. I made that offer - so there is at least one other believer of working together. You're the one that wants to do this on your own - and I'm okay with that. As you said yourself, you couldn't care less right ? You couldn't care less if the driver works or not, you couldn't care less if we have good omap support out of mainline kernel, you couldn't care less if the driver is readable or not, etc etc etc. That's not true. I do care. It __is__ important to me that OMAP support goes to mainline. And I do not like it that it hasn't happened yet. Sorry. What happened with EHCI here is kind of similar to what you've done with MUSB patches recently anyway. I imagine if all of us would be taking the same behavior as you are... I don't understand what you mean, but I'm guessing it doesn't matter. Well, I'm not here to flood the list discussing this kinds of issues with you. Standard behavior for you. That's the way you end all discussions that go beyond 5 mails!-- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Fri, Feb 20, 2009 at 02:23:33PM +0100, Anand Gadiyar wrote: That's not true. I do care. It __is__ important to me that OMAP support goes to mainline. And I do not like it that it hasn't happened yet. Sorry. What happened with EHCI here is kind of similar to what you've done with MUSB patches recently anyway. sure... but then Dave helped right... We had some discussions off list in order for that to happen. Well, I'm not here to flood the list discussing this kinds of issues with you. Standard behavior for you. That's the way you end all discussions that go beyond 5 mails! yeah... for sure. If you wanna keep discussing it, just keep sending your mails... -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Fri, Feb 20, 2009 at 06:27:14PM +0530, Gadiyar, Anand wrote: ... If you want help with testing, I can give it to you. If not, you can test it yourself - I couldn't care less. It would be nice to know if your venerable employer (TI) share your opinion?... -otto -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Thu, Feb 19, 2009 at 01:04:30PM -0800, Tony Lindgren wrote: * Felipe Balbi m...@felipebalbi.com [090219 12:58]: On Thu, Feb 19, 2009 at 02:29:38PM +0200, Felipe Balbi wrote: Hi Tony, the final version is already going to mainline via linux-input, you might wanna apply these to l-o to avoid conflicts later. mainline had a few comments to this driver which will come as an extra cleanup patch since there's no functionality change, only style changes so far. These should be safe to apply. OK, will push today. Cool thanks, now that we're in the push drivers upstream season, what abou the ehci driver ? Did you get any patches from TI tony ? I asked you to drop some patches from me because they said they would come up with a better solution. If I get a board to test ehci, I'll push that driver upstream as well, it's been too long waiting and TI still didn't give us the patches for ehci, nor ohci. -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
* Felipe Balbi m...@felipebalbi.com [090219 13:19]: On Thu, Feb 19, 2009 at 01:04:30PM -0800, Tony Lindgren wrote: * Felipe Balbi m...@felipebalbi.com [090219 12:58]: On Thu, Feb 19, 2009 at 02:29:38PM +0200, Felipe Balbi wrote: Hi Tony, the final version is already going to mainline via linux-input, you might wanna apply these to l-o to avoid conflicts later. mainline had a few comments to this driver which will come as an extra cleanup patch since there's no functionality change, only style changes so far. These should be safe to apply. OK, will push today. Cool thanks, now that we're in the push drivers upstream season, what abou the ehci driver ? Did you get any patches from TI tony ? I asked you to drop some patches from me because they said they would come up with a better solution. If I get a board to test ehci, I'll push that driver upstream as well, it's been too long waiting and TI still didn't give us the patches for ehci, nor ohci. No patches from TI :( It would be nice to get that driver into the out of the linux-omap tree. Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Thu, Feb 19, 2009 at 1:29 PM, Tony Lindgren t...@atomide.com wrote: * Felipe Balbi m...@felipebalbi.com [090219 13:19]: On Thu, Feb 19, 2009 at 01:04:30PM -0800, Tony Lindgren wrote: * Felipe Balbi m...@felipebalbi.com [090219 12:58]: On Thu, Feb 19, 2009 at 02:29:38PM +0200, Felipe Balbi wrote: Hi Tony, the final version is already going to mainline via linux-input, you might wanna apply these to l-o to avoid conflicts later. mainline had a few comments to this driver which will come as an extra cleanup patch since there's no functionality change, only style changes so far. These should be safe to apply. OK, will push today. Cool thanks, now that we're in the push drivers upstream season, what abou the ehci driver ? Did you get any patches from TI tony ? I asked you to drop some patches from me because they said they would come up with a better solution. If I get a board to test ehci, I'll push that driver upstream as well, it's been too long waiting and TI still didn't give us the patches for ehci, nor ohci. No patches from TI :( It would be nice to get that driver into the out of the linux-omap tree. EHCI omap driver definitely needs some work - there is machine specific stuff in there that rightfully belongs in platform data. I haven't had time to work on it :-( Steve -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Thu, Feb 19, 2009 at 02:43:36PM -0800, Steve Sakoman wrote: EHCI omap driver definitely needs some work - there is machine specific stuff in there that rightfully belongs in platform data. I haven't had time to work on it :-( For sure, and there's still workaround for clk framework stuff that should already move there. I'll try to start with some cleanups already during this weekend (yeah, I've got no life :-p) and post as RFT asap. After the cleanups are ok, then I'll start moving platform code out of there and for the clock workarounds I'll need help from Paul Walmsley, probably :-) -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)
On Friday Feb 20, 2009 Felipe Balbi wrote: Cool thanks, now that we're in the push drivers upstream season, what abou the ehci driver ? Did you get any patches from TI tony ? I asked you to drop some patches from me because they said they would come up with a better solution. If I get a board to test ehci, I'll push that driver upstream as well, it's been too long waiting and TI still didn't give us the patches for ehci, nor ohci. No patches from TI :( It would be nice to get that driver into the out of the linux-omap tree. I could patch but wouldn't have how to test it :-( My beagle doesn't have ehci port, too bad. I've got the hardware. If you want to fix up that driver, I can test it for you. - Anand -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
