Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c
On Wed, 24 Mar 2010 20:20:19 -0300, Marcelo Jimenez said: - debug(skt, 2, mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n, I will redo it, no problem. But just for my information, in that particular case, is it usefull to grep using format specifiers? Until you find the format string, you really don't know for sure if it's a %d or a %u or a %alt-ctl-cokebottle so you end up grepping like this: egrep 'mask: .*flags: .*Vcc .* Vpp .* irq' basically wildcarding your way across whatever %foo might be there. pgp0HaMqVd2zw.pgp Description: PGP signature ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
[git pull] PCMCIA bugfixes for 2.6.34-rc3
Linus, some PCMCIA bugfixes for 2.6.34-rc3 are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git urgent Please pull from that location. The diffstat and list of changes follows. The PM-related change is ACKed by Rafael and needed for the PCMCIA bugfix. Thanks, Dominik Dominik Brodowski (4): pcmcia: do not use ioports 0x100 on x86 pcmcia: allow for four multifunction subdevices (again) power: support _noirq actions on device types and classes pcmcia: use dev_pm_ops for class pcmcia_socket_class Komuro (1): pd6729: Coding Style fixes drivers/base/power/main.c | 31 ++ drivers/pcmcia/at91_cf.c|2 - drivers/pcmcia/au1000_generic.c | 13 drivers/pcmcia/bfin_cf_pcmcia.c | 12 drivers/pcmcia/cs.c | 124 --- drivers/pcmcia/db1xxx_ss.c | 27 - drivers/pcmcia/ds.c |8 ++- drivers/pcmcia/i82092.c | 16 - drivers/pcmcia/i82365.c | 11 drivers/pcmcia/m32r_cfc.c | 11 drivers/pcmcia/m32r_pcc.c | 12 drivers/pcmcia/m8xx_pcmcia.c| 17 - drivers/pcmcia/omap_cf.c| 12 drivers/pcmcia/pd6729.c | 80 - drivers/pcmcia/pxa2xx_base.c|8 +-- drivers/pcmcia/rsrc_nonstatic.c |7 ++ drivers/pcmcia/sa1100_generic.c | 13 drivers/pcmcia/sa_generic.c | 12 drivers/pcmcia/tcic.c | 12 drivers/pcmcia/vrc4171_card.c | 13 drivers/pcmcia/yenta_socket.c | 17 +- include/pcmcia/ss.h |6 -- 22 files changed, 149 insertions(+), 315 deletions(-) ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c
On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote: Hello. Russell King - ARM Linux wrote: - debug(skt, 2, mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n, - (state-csc_mask==0)?NONE :, - (state-csc_maskSS_DETECT)?DETECT :, - (state-csc_maskSS_READY)?READY :, - (state-csc_maskSS_BATDEAD)?BATDEAD :, - (state-csc_maskSS_BATWARN)?BATWARN :, - (state-csc_maskSS_STSCHG)?STSCHG :, - (state-flags==0)?NONE :, - (state-flagsSS_PWR_AUTO)?PWR_AUTO :, - (state-flagsSS_IOCARD)?IOCARD :, - (state-flagsSS_RESET)?RESET :, - (state-flagsSS_SPKR_ENA)?SPKR_ENA :, - (state-flagsSS_OUTPUT_ENA)?OUTPUT_ENA :, + debug(skt, 2, mask: %s%s%s%s%s%s + flags: %s%s%s%s%s%s Vcc %d Vpp %d irq %d\n, NAK. Breaking kernel messages across multiple lines makes them impossible to grep for. checkpatch.pl is wrong on this one. I'd disagree in this case. Anybody will hardly grep for mask: %s%s%s%s%s%sflags: %s%s%s%s%s%s. Well, I disagree on a matter of principle with you. If you want to avoid the line going over 80 columns, move the entire string onto the next line. Then we can have the entire string intact _and_ we can have it fitting within 80 columns. ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
[Bug 7304] no PCI irq, Cardbus support disabled
https://bugzilla.kernel.org/show_bug.cgi?id=7304 --- Comment #83 from Thomas Nemeth nemeth.tho...@gmail.com 2010-03-26 21:18:34 --- Created an attachment (id=25724) -- (https://bugzilla.kernel.org/attachment.cgi?id=25724) Output of cbdump on 2.6.34-rc2 with the eth card in the non-working slot -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
[Bug 7304] no PCI irq, Cardbus support disabled
https://bugzilla.kernel.org/show_bug.cgi?id=7304 --- Comment #84 from Thomas Nemeth nemeth.tho...@gmail.com 2010-03-26 21:20:02 --- Created an attachment (id=25725) -- (https://bugzilla.kernel.org/attachment.cgi?id=25725) Output of cbdump on 2.6.34-rc2 with the eth card in the working slot -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
[Bug 7304] no PCI irq, Cardbus support disabled
https://bugzilla.kernel.org/show_bug.cgi?id=7304 --- Comment #85 from Thomas Nemeth nemeth.tho...@gmail.com 2010-03-26 21:23:40 --- (In reply to comment #82) This is with both socket-cb_irq = 11; dev-irq = 11; ? Yes. tho...@cixi:exether$ grep = 11; linux-2.6.34-rc2/drivers/pcmcia/yenta_socket.c socket-cb_irq = 11; dev-irq = 11; What's the cbdump output of each socket, with the card inserted? (I'm asking as one bit which should be set to 0 is set to 1 in the last cbdump output, and that confuses me) Here is the diff between the two dumps (hope this helps): tho...@cixi:~$ diff cbdump-2.6.34-rc2-slitaz-nonworkingslot cbdump-2.6.34-rc2-slitaz-workingslot --- cbdump-2.6.34-rc2-slitaz-nonworkingslot 2010-03-26 22:15:39.0 +0100 +++ cbdump-2.6.34-rc2-slitaz-workingslot2010-03-26 22:15:40.0 +0100 @@ -12,20 +12,20 @@ IO Limit 0 [30] : 0x18fc IO Base 1 [34] : 0x1c00 IO Limit 1 [38] : 0x1cfc - Bridge control [3e] : 0x0500 + Bridge control [3e] : 0x0580 Subsystem vendor ID[40] : 0x1179 Subsystem device ID[42] : 0x0001 Legacy mode base [44] : 0x0001 -- cardbus registers CB_SOCKET_EVENT[00] : 0x CB_SOCKET_MASK [04] : 0x0006 - CB_SOCKET_STATE[08] : 0x3828 + CB_SOCKET_STATE[08] : 0x3007 CB_SOCKET_FORCE[0c] : 0x - CB_SOCKET_CONTROL [10] : 0x0033 + CB_SOCKET_CONTROL [10] : 0x CB_SOCKET_POWER[20] : 0x -- exca registers I365_IDENT [00] : 0x83 - I365_STATUS[01] : 0x8e + I365_STATUS[01] : 0xb2 I365_POWER [02] : 0x40 I365_INTCTL[03] : 0x40 I365_CSC [04] : 0x00 @@ -73,20 +73,20 @@ IO Limit 0 [30] : 0x10fc IO Base 1 [34] : 0x1400 IO Limit 1 [38] : 0x14fc - Bridge control [3e] : 0x0580 + Bridge control [3e] : 0x0500 Subsystem vendor ID[40] : 0x1179 Subsystem device ID[42] : 0x0001 Legacy mode base [44] : 0x0001 -- cardbus registers CB_SOCKET_EVENT[00] : 0x CB_SOCKET_MASK [04] : 0x0006 - CB_SOCKET_STATE[08] : 0x3087 + CB_SOCKET_STATE[08] : 0x3828 CB_SOCKET_FORCE[0c] : 0x - CB_SOCKET_CONTROL [10] : 0x + CB_SOCKET_CONTROL [10] : 0x0033 CB_SOCKET_POWER[20] : 0x -- exca registers I365_IDENT [00] : 0x83 - I365_STATUS[01] : 0xb2 + I365_STATUS[01] : 0x8e I365_POWER [02] : 0x40 I365_INTCTL[03] : 0x40 I365_CSC [04] : 0x00 tho...@cixi:~$ -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c
On Fri, Mar 26, 2010 at 15:18, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote: I'd disagree in this case. Anybody will hardly grep for mask: %s%s%s%s%s%sflags: %s%s%s%s%s%s. Well, I disagree on a matter of principle with you. If you want to avoid the line going over 80 columns, move the entire string onto the next line. Then we can have the entire string intact _and_ we can have it fitting within 80 columns. This is no big deal. Also, I have already submitted the new patch and Valdis had a good point for egrep. Regards, Marcelo. ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c
On Fri, Mar 26, 2010 at 06:57:07PM -0300, Marcelo Jimenez wrote: On Fri, Mar 26, 2010 at 15:18, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote: I'd disagree in this case. Anybody will hardly grep for mask: %s%s%s%s%s%sflags: %s%s%s%s%s%s. Well, I disagree on a matter of principle with you. If you want to avoid the line going over 80 columns, move the entire string onto the next line. Then we can have the entire string intact _and_ we can have it fitting within 80 columns. This is no big deal. Also, I have already submitted the new patch and Valdis had a good point for egrep. Sorry, I'm having stability issues with my MTA which inexplicably died about 12 hours ago, presumably due to the level of crap flying around the 'net nowadays. This appears to be becoming a regular occurance in the last week. ;( ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
