Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c
On Thu, Mar 25, 2010 at 06:04:40PM +0100, Dominik Brodowski wrote: do you prefer me pushing these patches upstream (possibly even for -rc3), or do you wish to take these patches? I'll take them through the patch system, but as they're not bug fixes I'd queue them for the next merge window. ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c
On Sun, Mar 28, 2010 at 10:44:08AM +0100, Russell King - ARM Linux wrote: On Thu, Mar 25, 2010 at 06:04:40PM +0100, Dominik Brodowski wrote: do you prefer me pushing these patches upstream (possibly even for -rc3), or do you wish to take these patches? I'll take them through the patch system, but as they're not bug fixes I'd queue them for the next merge window. Excellent, thanks a lot. Best, Dominik ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
[Bug 7304] no PCI irq, Cardbus support disabled
https://bugzilla.kernel.org/show_bug.cgi?id=7304 --- Comment #88 from Dominik Brodowski li...@brodo.de 2010-03-28 11:54:21 --- Thanks. Both sockets look properly configured (for PCI IRQ = 11); the workaround (trying to use ISA IRQs for PCI) does not work as expected -- at least from what I determine out of the ToPIC97 datasheet found at the pcmcia-cs homepage. :( -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: pci_bus_for_each_resource, transparent bridges and rsrc_nonstatic.c
On Sat, Mar 27, 2010 at 08:03:40PM +0100, Peter Stuge wrote:
Dominik Brodowski wrote:
can we safely trust BIOS authors to get it right?
As a long time member of the coreboot project I can assure you that
the answer to that is No!!
Thanks. Jesse, Bjorn: recalling my mesage of 22 March 2010, what's your
opinion on the two options spelled out there:
| (1) The best way seems to be to skip all resources of type
| PCI_SUBTRACTIVE_DECODE, but this flag is only stored in
| struct pci_bus_resource, which is hard to access, and nonexistent for the
| first four resources. Actually, the flag field is unused otherwise. Could
| we set res-flags |= PCI_SUBTRACTIVE_DECODE instead? (it probably needs to
| be != 0x1 then, but anyways). Then it's trivial in rsrc_nonstatic.c
|
| (2) An alternative would be to
|
| diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c
| index ba3a53e..b0e60a1 100644
| --- a/drivers/pcmcia/rsrc_nonstatic.c
| +++ b/drivers/pcmcia/rsrc_nonstatic.c
| @@ -933,7 +933,8 @@ static int nonstatic_autoadd_resources(struct
pcmcia_socket *s)
| return -EINVAL;
| #endif
|
| - pci_bus_for_each_resource(s-cb_dev-bus, res, i) {
| + for (i = 0; i PCI_BRIDGE_RESOURCE_NUM; i++) {
| + res = s-cb_dev-bus-resource[i];
| if (!res)
| continue;
Best,
Dominik
___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia
[PATCH] Don't link pcmcia-check-broken-cis against libsysfs
It uses the SYSFS_PATH_MAX macro from sysfs/libsysfs.h, but nothing that requires run-time linkage. Signed-off-by: Colin Watson cjwat...@debian.org --- Makefile |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 26f3e4b..a265873 100644 --- a/Makefile +++ b/Makefile @@ -150,10 +150,12 @@ CFLAGS += -I$(PWD)/src CFLAGS += $(WARNINGS) -I$(GCCINCDIR) LIB_OBJS = -lc -lsysfs +LIB_PLAIN_OBJS = -lc LIB_PCI_OBJS = -lc -lpci ifeq ($(strip $(STATIC)),true) LIB_OBJS = -lsysfs + LIB_PLAIN_OBJS = LIB_PCI_OBJS = -lpci LDFLAGS += -static else @@ -230,7 +232,7 @@ $(PCCARDCTL): $(LIBC) src/$(PCCARDCTL).o src/$(PCCARDCTL).c $(OBJS) $(HEADERS) $(QUIET) $(STRIPCMD) $@ $(PCMCIA_CHECK_BROKEN_CIS): $(LIBC) src/$(PCMCIA_CHECK_BROKEN_CIS).o src/read-cis.o $(OBJS) $(HEADERS) - $(QUIET) $(LD) $(LDFLAGS) -o $@ $(CRT0) src/$(PCMCIA_CHECK_BROKEN_CIS).o src/read-cis.o $(LIB_OBJS) $(ARCH_LIB_OBJS) + $(QUIET) $(LD) $(LDFLAGS) -o $@ $(CRT0) src/$(PCMCIA_CHECK_BROKEN_CIS).o src/read-cis.o $(LIB_PLAIN_OBJS) $(ARCH_LIB_OBJS) $(QUIET) $(STRIPCMD) $@ $(PCMCIA_SOCKET_STARTUP): $(LIBC) src/startup.o src/yacc_config.o src/lex_config.o $(OBJS) $(HEADERS) -- 1.7.0.2 ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
