Re: [PATCH 2/5] Dynamic ID addition doesn't need get_driver()
On Tue, Jan 24, 2012 at 01:34:41PM -0500, Alan Stern wrote: As part of the removal of get_driver()/put_driver(), this patch (as1511) changes all the places that add dynamic IDs for drivers. Since these additions are done by writing to the drivers' sysfs attribute files, and the attributes are removed when the drivers are unregistered, there is no reason to take an extra reference to the drivers. The one exception is the pci-stub driver, which calls pci_add_dynid() as part of its registration. But again, there's no reason to take an extra reference here, because the driver can't be unloaded while it is being registered. Signed-off-by: Alan Stern st...@rowland.harvard.edu CC: Dmitry Torokhov dmitry.torok...@gmail.com CC: Jiri Kosina jkos...@suse.cz CC: Jesse Barnes jbar...@virtuousgeek.org CC: Dominik Brodowski li...@dominikbrodowski.net For the PCMCIA part: Acked-by: Dominik Brodowski li...@dominikbrodowski.net Thanks, Dominik ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [PATCH resend] Clean up new_id and remove_id sysfs attribute routines
On Tue, Jan 24, 2012 at 04:59:36PM -0800, Jesse Barnes wrote: On Tue, 24 Jan 2012 16:33:13 -0800 Greg KH g...@kroah.com wrote: On Tue, Jan 24, 2012 at 02:35:13PM -0500, Alan Stern wrote: This patch (as1514) cleans up some places where new_id and remove_id sysfs attributes are created and deleted. Handling both attributes in a single routine rather than a pair of routines makes the code smaller. It also prevents certain kinds of errors, like one we currently have in the USB subsystem: The removeid attribute is often created even when newid isn't (because the driver's no_dynamid_id flag is set). In the case of the PCMCIA subsystem, the newid attribute is created but never explicitly deleted. The patch adds a deletion routine. Signed-off-by: Alan Stern st...@rowland.harvard.edu CC: Jesse Barnes jbar...@virtuousgeek.org CC: Dominik Brodowski li...@dominikbrodowski.net Jesse and Dominik, any objection for me to take this through my tree? No objection here, thanks guys. And none from me, neither. Thanks! Best, Dominik ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
